Issues in CommentCreateForm.php (master) - Issues in master - rmrevin/yii2-comments - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

forms/CommentCreateForm.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * CommentCreateForm.php
 * @author Revin Roman
 * @link https://rmrevin.ru
 */

namespace rmrevin\yii\module\Comments\forms;

use rmrevin\yii\module\Comments;

/**
 * Class CommentCreateForm
 * @package rmrevin\yii\module\Comments\forms
 */
class CommentCreateForm extends \yii\base\Model
{

    public $id;
    public $entity;
    public $from;
    public $text;

    /** @var Comments\models\Comment */
    public $Comment;

    public function init()
    {
        $Comment = $this->Comment;

        if (false === $this->Comment->isNewRecord) {
            $this->id = $Comment->id;
            $this->entity = $Comment->entity;
            $this->from = $Comment->from;
            $this->text = $Comment->text;
        } elseif (!\Yii::$app->getUser()->getIsGuest()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $User = \Yii::$app->getUser()->getIdentity();

            $this->from = $User instanceof Comments\interfaces\CommentatorInterface
                ? $User->getCommentatorName()
                : null;
        }
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        $CommentModelClassName = Comments\Module::instance()->model('comment');

        return [
            [['entity', 'text'], 'required'],
            [['entity', 'from', 'text'], 'string'],
            [['id'], 'integer'],
            [['id'], 'exist', 'targetClass' => $CommentModelClassName, 'targetAttribute' => 'id'],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'entity' => \Yii::t('app', 'Entity'),
            'from' => \Yii::t('app', 'Your name'),
            'text' => \Yii::t('app', 'Text'),
        ];
    }

    /**
     * @return bool
     * @throws \yii\web\NotFoundHttpException
     */
    public function save()
    {
        $Comment = $this->Comment;

        $CommentModelClassName = Comments\Module::instance()->model('comment');

        if (empty($this->id)) {
            $Comment = \Yii::createObject($CommentModelClassName);
        } elseif ($this->id > 0 && $Comment->id !== $this->id) {
            /** @var Comments\models\Comment $CommentModel */
            $CommentModel = \Yii::createObject($CommentModelClassName);
            $Comment = $CommentModel::find()
                ->byId($this->id)
                ->one();

            if (!($Comment instanceof Comments\models\Comment)) {
                throw new \yii\web\NotFoundHttpException;
            }
        }

        $Comment->entity = $this->entity;
        $Comment->from = $this->from;
        $Comment->text = $this->text;

        $result = $Comment->save();

        if ($Comment->hasErrors()) {
            foreach ($Comment->getErrors() as $attribute => $messages) {
                foreach ($messages as $mes) {
                    $this->addError($attribute, $mes);
                }
            }
        }

        $this->Comment = $Comment;

        return $result;
    }
}


1			<?php
2			/**
3			* CommentCreateForm.php
4			* @author Revin Roman
5			* @link https://rmrevin.ru
6			*/
7
8			namespace rmrevin\yii\module\Comments\forms;
9
10			use rmrevin\yii\module\Comments;
11
12			/**
13			* Class CommentCreateForm
14			* @package rmrevin\yii\module\Comments\forms
15			*/
16			class CommentCreateForm extends \yii\base\Model
17			{
18
19			public $id;
20			public $entity;
21			public $from;
22			public $text;
23
24			/** @var Comments\models\Comment */
25			public $Comment;
26
27			public function init()
28			{
29			$Comment = $this->Comment;
30
31			if (false === $this->Comment->isNewRecord) {
32			$this->id = $Comment->id;
33			$this->entity = $Comment->entity;
34			$this->from = $Comment->from;
35			$this->text = $Comment->text;
36			} elseif (!\Yii::$app->getUser()->getIsGuest()) {
			0 ignored issues – show Bug introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getUser` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37			$User = \Yii::$app->getUser()->getIdentity();
38
39			$this->from = $User instanceof Comments\interfaces\CommentatorInterface
40			? $User->getCommentatorName()
41			: null;
42			}
43			}
44
45			/**
46			* @inheritdoc
47			*/
48			public function rules()
49			{
50			$CommentModelClassName = Comments\Module::instance()->model('comment');
51
52			return [
53			[['entity', 'text'], 'required'],
54			[['entity', 'from', 'text'], 'string'],
55			[['id'], 'integer'],
56			[['id'], 'exist', 'targetClass' => $CommentModelClassName, 'targetAttribute' => 'id'],
57			];
58			}
59
60			/**
61			* @inheritdoc
62			*/
63			public function attributeLabels()
64			{
65			return [
66			'entity' => \Yii::t('app', 'Entity'),
67			'from' => \Yii::t('app', 'Your name'),
68			'text' => \Yii::t('app', 'Text'),
69			];
70			}
71
72			/**
73			* @return bool
74			* @throws \yii\web\NotFoundHttpException
75			*/
76			public function save()
77			{
78			$Comment = $this->Comment;
79
80			$CommentModelClassName = Comments\Module::instance()->model('comment');
81
82			if (empty($this->id)) {
83			$Comment = \Yii::createObject($CommentModelClassName);
84			} elseif ($this->id > 0 && $Comment->id !== $this->id) {
85			/** @var Comments\models\Comment $CommentModel */
86			$CommentModel = \Yii::createObject($CommentModelClassName);
87			$Comment = $CommentModel::find()
88			->byId($this->id)
89			->one();
90
91			if (!($Comment instanceof Comments\models\Comment)) {
92			throw new \yii\web\NotFoundHttpException;
93			}
94			}
95
96			$Comment->entity = $this->entity;
97			$Comment->from = $this->from;
98			$Comment->text = $this->text;
99
100			$result = $Comment->save();
101
102			if ($Comment->hasErrors()) {
103			foreach ($Comment->getErrors() as $attribute => $messages) {
104			foreach ($messages as $mes) {
105			$this->addError($attribute, $mes);
106			}
107			}
108			}
109
110			$this->Comment = $Comment;
111
112			return $result;
113			}
114			}
115

rmrevin / yii2-comments

Issues (14)

Security Analysis not enabled

forms/CommentCreateForm.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like