Comment::canCreate() - Code Metrics - rmrevin/yii2-comments - Measure and Improve Code Quality continuously with Scrutinizer

Comment::canCreate() A
last analyzed 2016-06-27 10:38 UTC

↳ Parent: Comment

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	6
ccs	0
cts	4
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php
/**
 * Comment.php
 * @author Revin Roman
 * @link https://rmrevin.ru
 */

namespace rmrevin\yii\module\Comments\models;

use rmrevin\yii\module\Comments;
use yii\behaviors\BlameableBehavior;
use yii\behaviors\TimestampBehavior;

/**
 * Class Comment
 * @package rmrevin\yii\module\Comments\models
 *
 * @property integer $id
 * @property string $entity
 * @property string $from
 * @property string $text
 * @property integer $deleted
 * @property integer $created_by
 * @property integer $updated_by
 * @property integer $created_at
 * @property integer $updated_at
 *
 * @property \yii\db\ActiveRecord $author
 * @property \yii\db\ActiveRecord $lastUpdateAuthor
 *
 * @method queries\CommentQuery hasMany(string $class, array $link) see BaseActiveRecord::hasMany() for more info
 * @method queries\CommentQuery hasOne(string $class, array $link) see BaseActiveRecord::hasOne() for more info
 */
class Comment extends \yii\db\ActiveRecord
{

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'blameable' => BlameableBehavior::className(),
            'timestamp' => TimestampBehavior::className(),
        ];
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['text'], 'required'],
            [['from', 'text'], 'string'],
            [['created_by', 'updated_by', 'created_at', 'updated_at'], 'integer'],
            [['deleted'], 'boolean'],
            [['deleted'], 'default', 'value' => self::NOT_DELETED],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => \Yii::t('app', 'ID'),
            'entity' => \Yii::t('app', 'Entity'),
            'from' => \Yii::t('app', 'Comment author'),
            'text' => \Yii::t('app', 'Text'),
            'created_by' => \Yii::t('app', 'Created by'),
            'updated_by' => \Yii::t('app', 'Updated by'),
            'created_at' => \Yii::t('app', 'Created at'),
            'updated_at' => \Yii::t('app', 'Updated at'),
        ];
    }

    /**
     * @return bool
     */
    public function isEdited()
    {
        return $this->created_at !== $this->updated_at;
    }

    /**
     * @return bool
     */
    public function isDeleted()
    {
        return $this->deleted === self::DELETED;
    }

    /**
     * @return bool
     */
    public static function canCreate()
    {
        return Comments\Module::instance()->useRbac === true
            ? \Yii::$app->getUser()->can(Comments\Permission::CREATE)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            : true;
    }

    /**
     * @return bool
     */
    public function canUpdate()

    {
        $User = \Yii::$app->getUser();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return Comments\Module::instance()->useRbac === true
            ? (\Yii::$app->getUser()->can(Comments\Permission::UPDATE) || \Yii::$app->getUser()->can(Comments\Permission::UPDATE_OWN, ['Comment' => $this]))
            : ($User->isGuest ? false : ($this->created_by === $User->id));
    }

    /**
     * @return bool
     */
    public function canDelete()

    {
        $User = \Yii::$app->getUser();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return Comments\Module::instance()->useRbac === true
            ? (\Yii::$app->getUser()->can(Comments\Permission::DELETE) || \Yii::$app->getUser()->can(Comments\Permission::DELETE_OWN, ['Comment' => $this]))
            : ($User->isGuest ? false : ($this->created_by === $User->id));
    }

    /**
     * @return queries\CommentQuery
     */
    public function getAuthor()
    {
        return $this->hasOne(Comments\Module::instance()->userIdentityClass, ['id' => 'created_by']);
    }

    /**
     * @return queries\CommentQuery
     */
    public function getLastUpdateAuthor()
    {
        return $this->hasOne(Comments\Module::instance()->userIdentityClass, ['id' => 'updated_by']);
    }

    /**
     * @return queries\CommentQuery
     */
    public static function find()
    {
        return \Yii::createObject(
            Comments\Module::instance()->model('commentQuery'),
            [get_called_class()]
        );
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%comment}}';
    }

    const NOT_DELETED = 0;
    const DELETED = 1;
}

1		<?php
2		/**
3		* Comment.php
4		* @author Revin Roman
5		* @link https://rmrevin.ru
6		*/
7
8		namespace rmrevin\yii\module\Comments\models;
9
10		use rmrevin\yii\module\Comments;
11		use yii\behaviors\BlameableBehavior;
12		use yii\behaviors\TimestampBehavior;
13
14		/**
15		* Class Comment
16		* @package rmrevin\yii\module\Comments\models
17		*
18		* @property integer $id
19		* @property string $entity
20		* @property string $from
21		* @property string $text
22		* @property integer $deleted
23		* @property integer $created_by
24		* @property integer $updated_by
25		* @property integer $created_at
26		* @property integer $updated_at
27		*
28		* @property \yii\db\ActiveRecord $author
29		* @property \yii\db\ActiveRecord $lastUpdateAuthor
30		*
31		* @method queries\CommentQuery hasMany(string $class, array $link) see BaseActiveRecord::hasMany() for more info
32		* @method queries\CommentQuery hasOne(string $class, array $link) see BaseActiveRecord::hasOne() for more info
33		*/
34		class Comment extends \yii\db\ActiveRecord
35		{
36
37		/**
38		* @inheritdoc
39		*/
40		public function behaviors()
41		{
42		return [
43		'blameable' => BlameableBehavior::className(),
44		'timestamp' => TimestampBehavior::className(),
45		];
46		}
47
48		/**
49		* @inheritdoc
50		*/
51		public function rules()
52		{
53		return [
54		[['text'], 'required'],
55		[['from', 'text'], 'string'],
56		[['created_by', 'updated_by', 'created_at', 'updated_at'], 'integer'],
57		[['deleted'], 'boolean'],
58		[['deleted'], 'default', 'value' => self::NOT_DELETED],
59		];
60		}
61
62		/**
63		* @inheritdoc
64		*/
65		public function attributeLabels()
66		{
67		return [
68		'id' => \Yii::t('app', 'ID'),
69		'entity' => \Yii::t('app', 'Entity'),
70		'from' => \Yii::t('app', 'Comment author'),
71		'text' => \Yii::t('app', 'Text'),
72		'created_by' => \Yii::t('app', 'Created by'),
73		'updated_by' => \Yii::t('app', 'Updated by'),
74		'created_at' => \Yii::t('app', 'Created at'),
75		'updated_at' => \Yii::t('app', 'Updated at'),
76		];
77		}
78
79		/**
80		* @return bool
81		*/
82		public function isEdited()
83		{
84		return $this->created_at !== $this->updated_at;
85		}
86
87		/**
88		* @return bool
89		*/
90		public function isDeleted()
91		{
92		return $this->deleted === self::DELETED;
93		}
94
95		/**
96		* @return bool
97		*/
98		public static function canCreate()
99		{
100		return Comments\Module::instance()->useRbac === true
101		? \Yii::$app->getUser()->can(Comments\Permission::CREATE)
		0 ignored issues – show Bug introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report The method `getUser` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
102		: true;
103		}
104
105		/**
106		* @return bool
107		*/
108	View Code Duplication	public function canUpdate()
		0 ignored issues – show Duplication introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		$User = \Yii::$app->getUser();
		0 ignored issues – show Bug introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report The method `getUser` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
111
112		return Comments\Module::instance()->useRbac === true
113		? (\Yii::$app->getUser()->can(Comments\Permission::UPDATE) \|\| \Yii::$app->getUser()->can(Comments\Permission::UPDATE_OWN, ['Comment' => $this]))
114		: ($User->isGuest ? false : ($this->created_by === $User->id));
115		}
116
117		/**
118		* @return bool
119		*/
120	View Code Duplication	public function canDelete()
		0 ignored issues – show Duplication introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		$User = \Yii::$app->getUser();
		0 ignored issues – show Bug introduced 2016-02-28 08:52 UTC by Report Bug Copy Issue Report The method `getUser` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
123
124		return Comments\Module::instance()->useRbac === true
125		? (\Yii::$app->getUser()->can(Comments\Permission::DELETE) \|\| \Yii::$app->getUser()->can(Comments\Permission::DELETE_OWN, ['Comment' => $this]))
126		: ($User->isGuest ? false : ($this->created_by === $User->id));
127		}
128
129		/**
130		* @return queries\CommentQuery
131		*/
132		public function getAuthor()
133		{
134		return $this->hasOne(Comments\Module::instance()->userIdentityClass, ['id' => 'created_by']);
135		}
136
137		/**
138		* @return queries\CommentQuery
139		*/
140		public function getLastUpdateAuthor()
141		{
142		return $this->hasOne(Comments\Module::instance()->userIdentityClass, ['id' => 'updated_by']);
143		}
144
145		/**
146		* @return queries\CommentQuery
147		*/
148		public static function find()
149		{
150		return \Yii::createObject(
151		Comments\Module::instance()->model('commentQuery'),
152		[get_called_class()]
153		);
154		}
155
156		/**
157		* @inheritdoc
158		*/
159		public static function tableName()
160		{
161		return '{{%comment}}';
162		}
163
164		const NOT_DELETED = 0;
165		const DELETED = 1;
166		}

rmrevin / yii2-comments

Comment::canCreate() A last analyzed 2016-06-27 10:38 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Comment::canCreate() A
last analyzed 2016-06-27 10:38 UTC