Complex classes like Requests_Cookie often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Requests_Cookie, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Requests_Cookie { |
||
| 16 | /** |
||
| 17 | * Cookie name. |
||
| 18 | * |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | public $name; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * Cookie value. |
||
| 25 | * |
||
| 26 | * @var string |
||
| 27 | */ |
||
| 28 | public $value; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Cookie attributes |
||
| 32 | * |
||
| 33 | * Valid keys are (currently) path, domain, expires, max-age, secure and |
||
| 34 | * httponly. |
||
| 35 | * |
||
| 36 | * @var Requests_Utility_CaseInsensitiveDictionary|array Array-like object |
||
| 37 | */ |
||
| 38 | public $attributes = array(); |
||
| 39 | |||
| 40 | /** |
||
| 41 | * Cookie flags |
||
| 42 | * |
||
| 43 | * Valid keys are (currently) creation, last-access, persistent and |
||
| 44 | * host-only. |
||
| 45 | * |
||
| 46 | * @var array |
||
| 47 | */ |
||
| 48 | public $flags = array(); |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Reference time for relative calculations |
||
| 52 | * |
||
| 53 | * This is used in place of `time()` when calculating Max-Age expiration and |
||
| 54 | * checking time validity. |
||
| 55 | * |
||
| 56 | * @var int |
||
| 57 | */ |
||
| 58 | public $reference_time = 0; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Create a new cookie object |
||
| 62 | * |
||
| 63 | * @param string $name |
||
| 64 | * @param string $value |
||
| 65 | * @param array|Requests_Utility_CaseInsensitiveDictionary $attributes Associative array of attribute data |
||
| 66 | */ |
||
| 67 | public function __construct($name, $value, $attributes = array(), $flags = array(), $reference_time = null) { |
||
| 86 | |||
| 87 | /** |
||
| 88 | * Check if a cookie is expired. |
||
| 89 | * |
||
| 90 | * Checks the age against $this->reference_time to determine if the cookie |
||
| 91 | * is expired. |
||
| 92 | * |
||
| 93 | * @return boolean True if expired, false if time is valid. |
||
| 94 | */ |
||
| 95 | public function is_expired() { |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Check if a cookie is valid for a given URI |
||
| 115 | * |
||
| 116 | * @param Requests_IRI $uri URI to check |
||
| 117 | * @return boolean Whether the cookie is valid for the given URI |
||
| 118 | */ |
||
| 119 | public function uri_matches(Requests_IRI $uri) { |
||
| 130 | |||
| 131 | /** |
||
| 132 | * Check if a cookie is valid for a given domain |
||
| 133 | * |
||
| 134 | * @param string $string Domain to check |
||
| 135 | * @return boolean Whether the cookie is valid for the given domain |
||
| 136 | */ |
||
| 137 | public function domain_matches($string) { |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Check if a cookie is valid for a given path |
||
| 180 | * |
||
| 181 | * From the path-match check in RFC 6265 section 5.1.4 |
||
| 182 | * |
||
| 183 | * @param string $request_path Path to check |
||
| 184 | * @return boolean Whether the cookie is valid for the given path |
||
| 185 | */ |
||
| 186 | public function path_matches($request_path) { |
||
| 222 | |||
| 223 | /** |
||
| 224 | * Normalize cookie and attributes |
||
| 225 | * |
||
| 226 | * @return boolean Whether the cookie was successfully normalized |
||
| 227 | */ |
||
| 228 | public function normalize() { |
||
| 244 | |||
| 245 | /** |
||
| 246 | * Parse an individual cookie attribute |
||
| 247 | * |
||
| 248 | * Handles parsing individual attributes from the cookie values. |
||
| 249 | * |
||
| 250 | * @param string $name Attribute name |
||
| 251 | * @param string|boolean $value Attribute value (string value, or true if empty/flag) |
||
| 252 | * @return mixed Value if available, or null if the attribute value is invalid (and should be skipped) |
||
| 253 | */ |
||
| 254 | protected function normalize_attribute($name, $value) { |
||
| 255 | switch (strtolower($name)) { |
||
| 256 | case 'expires': |
||
| 257 | // Expiration parsing, as per RFC 6265 section 5.2.1 |
||
| 258 | if (is_int($value)) { |
||
| 259 | return $value; |
||
| 260 | } |
||
| 261 | |||
| 262 | $expiry_time = strtotime($value); |
||
| 263 | if ($expiry_time === false) { |
||
| 264 | return null; |
||
| 265 | } |
||
| 266 | |||
| 267 | return $expiry_time; |
||
| 268 | |||
| 269 | case 'max-age': |
||
| 270 | // Expiration parsing, as per RFC 6265 section 5.2.2 |
||
| 271 | if (is_int($value)) { |
||
| 272 | return $value; |
||
| 273 | } |
||
| 274 | |||
| 275 | // Check that we have a valid age |
||
| 276 | if (!preg_match('/^-?\d+$/', $value)) { |
||
| 277 | return null; |
||
| 278 | } |
||
| 279 | |||
| 280 | $delta_seconds = (int) $value; |
||
| 281 | if ($delta_seconds <= 0) { |
||
| 282 | $expiry_time = 0; |
||
| 283 | } |
||
| 284 | else { |
||
| 285 | $expiry_time = $this->reference_time + $delta_seconds; |
||
| 286 | } |
||
| 287 | |||
| 288 | return $expiry_time; |
||
| 289 | |||
| 290 | case 'domain': |
||
| 291 | // Domains are not required as per RFC 6265 section 5.2.3 |
||
| 292 | if (empty($value)) { |
||
| 293 | return null; |
||
| 294 | } |
||
| 295 | |||
| 296 | // Domain normalization, as per RFC 6265 section 5.2.3 |
||
| 297 | if ($value[0] === '.') { |
||
| 298 | $value = substr($value, 1); |
||
| 299 | } |
||
| 300 | |||
| 301 | return $value; |
||
| 302 | |||
| 303 | default: |
||
| 304 | return $value; |
||
| 305 | } |
||
| 306 | } |
||
| 307 | |||
| 308 | /** |
||
| 309 | * Format a cookie for a Cookie header |
||
| 310 | * |
||
| 311 | * This is used when sending cookies to a server. |
||
| 312 | * |
||
| 313 | * @return string Cookie formatted for Cookie header |
||
| 314 | */ |
||
| 315 | public function format_for_header() { |
||
| 318 | |||
| 319 | /** |
||
| 320 | * Format a cookie for a Cookie header |
||
| 321 | * |
||
| 322 | * @codeCoverageIgnore |
||
| 323 | * @deprecated Use {@see Requests_Cookie::format_for_header} |
||
| 324 | * @return string |
||
| 325 | */ |
||
| 326 | public function formatForHeader() { |
||
| 329 | |||
| 330 | /** |
||
| 331 | * Format a cookie for a Set-Cookie header |
||
| 332 | * |
||
| 333 | * This is used when sending cookies to clients. This isn't really |
||
| 334 | * applicable to client-side usage, but might be handy for debugging. |
||
| 335 | * |
||
| 336 | * @return string Cookie formatted for Set-Cookie header |
||
| 337 | */ |
||
| 338 | public function format_for_set_cookie() { |
||
| 356 | |||
| 357 | /** |
||
| 358 | * Format a cookie for a Set-Cookie header |
||
| 359 | * |
||
| 360 | * @codeCoverageIgnore |
||
| 361 | * @deprecated Use {@see Requests_Cookie::format_for_set_cookie} |
||
| 362 | * @return string |
||
| 363 | */ |
||
| 364 | public function formatForSetCookie() { |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Get the cookie value |
||
| 370 | * |
||
| 371 | * Attributes and other data can be accessed via methods. |
||
| 372 | */ |
||
| 373 | public function __toString() { |
||
| 376 | |||
| 377 | /** |
||
| 378 | * Parse a cookie string into a cookie object |
||
| 379 | * |
||
| 380 | * Based on Mozilla's parsing code in Firefox and related projects, which |
||
| 381 | * is an intentional deviation from RFC 2109 and RFC 2616. RFC 6265 |
||
| 382 | * specifies some of this handling, but not in a thorough manner. |
||
| 383 | * |
||
| 384 | * @param string Cookie header value (from a Set-Cookie header) |
||
| 385 | * @return Requests_Cookie Parsed cookie object |
||
| 386 | */ |
||
| 387 | public static function parse($string, $name = '', $reference_time = null) { |
||
| 430 | |||
| 431 | /** |
||
| 432 | * Parse all Set-Cookie headers from request headers |
||
| 433 | * |
||
| 434 | * @param Requests_Response_Headers $headers Headers to parse from |
||
| 435 | * @param Requests_IRI|null $origin URI for comparing cookie origins |
||
| 436 | * @param int|null $time Reference time for expiration calculation |
||
| 437 | * @return array |
||
| 438 | */ |
||
| 439 | public static function parse_from_headers(Requests_Response_Headers $headers, Requests_IRI $origin = null, $time = null) { |
||
| 494 | |||
| 495 | /** |
||
| 496 | * Parse all Set-Cookie headers from request headers |
||
| 497 | * |
||
| 498 | * @codeCoverageIgnore |
||
| 499 | * @deprecated Use {@see Requests_Cookie::parse_from_headers} |
||
| 500 | * @return array |
||
| 501 | */ |
||
| 502 | public static function parseFromHeaders(Requests_Response_Headers $headers) { |
||
| 505 | } |
||
| 506 |