Connection::write() - Code Metrics - rlunar/tinker-server - Measure and Improve Code Quality continuously with Scrutinizer

Connection::write() A
last analyzed 2019-08-05 20:26 UTC

↳ Parent: Connection

Complexity

Conditions	5
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	9
nop	1
dl	0
loc	28
rs	9.1608
c	0
b	0
f	0

<?php

namespace RedMoon\TinkerServer;

class Connection
{
    /** @var int */
    protected $socket;

    /** @var string */
    protected $host;

    /**
     * Connection constructor.
     *
     * @param string $host
     */
    public function __construct(string $host)
    {
        $this->host = $host;
    }

    /**
     * Write.
     *
     * @param  array  $namedParameters
     *
     * @return bool
     */
    public function write(array $namedParameters): bool
    {
        if (! $this->socket = $this->socket ?: $this->createSocket()) {
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            return false;
        }

        set_error_handler([self::class, 'nullErrorHandler']);

        try {
            $encodedPayload = base64_encode(serialize($namedParameters))."\n";

            if (-1 !== stream_socket_sendto($this->socket, $encodedPayload)) {
                return true;
            }

            stream_socket_shutdown($this->socket, STREAM_SHUT_RDWR);
            fclose($this->socket);
            $this->socket = $this->createSocket();


            if (-1 !== stream_socket_sendto($this->socket, $encodedPayload)) {
                return true;
            }
        } finally {
            restore_error_handler();
        }

        return false;
    }

    /**
     * nullErrorHandler.
     *
     * @param  $t
     * @param  $m
     *
     * @return void
     */
    private static function nullErrorHandler($t, $m)

    {
        // no-op
    }

    /**
     * Create Socket.
     *
     * @return resource
     */
    private function createSocket()
    {
        set_error_handler([self::class, 'nullErrorHandler']);
        try {
            return stream_socket_client($this->host, $errno, $errstr, 3, STREAM_CLIENT_CONNECT);
        } finally {
            restore_error_handler();
        }
    }
}


1			<?php
2
3			namespace RedMoon\TinkerServer;
4
5			class Connection
6			{
7			/** @var int */
8			protected $socket;
9
10			/** @var string */
11			protected $host;
12
13			/**
14			* Connection constructor.
15			*
16			* @param string $host
17			*/
18			public function __construct(string $host)
19			{
20			$this->host = $host;
21			}
22
23			/**
24			* Write.
25			*
26			* @param array $namedParameters
27			*
28			* @return bool
29			*/
30			public function write(array $namedParameters): bool
31			{
32			if (! $this->socket = $this->socket ?: $this->createSocket()) {
			0 ignored issues – show Documentation Bug introduced 2019-08-04 23:04 UTC by Report Bug Copy Issue Report It seems like `$this->socket ?: $this->createSocket()` can also be of type `resource`. However, the property `$socket` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
33			return false;
34			}
35
36			set_error_handler([self::class, 'nullErrorHandler']);
37
38			try {
39			$encodedPayload = base64_encode(serialize($namedParameters))."\n";
40
41			if (-1 !== stream_socket_sendto($this->socket, $encodedPayload)) {
42			return true;
43			}
44
45			stream_socket_shutdown($this->socket, STREAM_SHUT_RDWR);
46			fclose($this->socket);
47			$this->socket = $this->createSocket();
			0 ignored issues – show Documentation Bug introduced 2019-08-04 23:04 UTC by Report Bug Copy Issue Report It seems like `$this->createSocket()` of type `resource` is incompatible with the declared type `integer` of property `$socket`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
48
49			if (-1 !== stream_socket_sendto($this->socket, $encodedPayload)) {
50			return true;
51			}
52			} finally {
53			restore_error_handler();
54			}
55
56			return false;
57			}
58
59			/**
60			* nullErrorHandler.
61			*
62			* @param $t
63			* @param $m
64			*
65			* @return void
66			*/
67			private static function nullErrorHandler($t, $m)
			0 ignored issues – show Unused Code introduced 2019-08-04 22:33 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history... Unused Code introduced 2019-08-04 22:33 UTC by Report Bug Copy Issue Report The parameter `$t` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2019-08-04 22:33 UTC by Report Bug Copy Issue Report The parameter `$m` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
68			{
69			// no-op
70			}
71
72			/**
73			* Create Socket.
74			*
75			* @return resource
76			*/
77			private function createSocket()
78			{
79			set_error_handler([self::class, 'nullErrorHandler']);
80			try {
81			return stream_socket_client($this->host, $errno, $errstr, 3, STREAM_CLIENT_CONNECT);
82			} finally {
83			restore_error_handler();
84			}
85			}
86			}
87

rlunar / tinker-server

Connection::write() A last analyzed 2019-08-05 20:26 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Connection::write() A
last analyzed 2019-08-05 20:26 UTC