UserListModel::getAllInfo() - Code Metrics - Inspection of "Merge pull request #3 from rl404/analysis-zEMKWZ" - rl404/MAL-Scraper - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — feature/super-model ( 86f2ea...9eaa75 )

by axel

created 2018-12-15 10:17 UTC

UserListModel::getAllInfo() A

↳ Parent: UserListModel

Complexity

Conditions	5
Paths	2

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	16
nc	2
nop	0
dl	0
loc	27
rs	9.4222
c	0
b	0
f	0

<?php

namespace MalScraper\Model\User;

use MalScraper\Helper\Helper;
use MalScraper\Model\MainModel;

/**
 * UserListModel class.
 */
class UserListModel extends MainModel
{
    /**
     * Username.
     *
     * @var string
     */
    private $_user;

    /**
     * Either anime or manga.
     *
     * @var string
     */
    private $_type;

    /**
     * Anime/manga status.
     *
     * @var string
     */
    private $_status;

    /**
     * Default constructor.
     *
     * @param string $user
     * @param string $type
     * @param string $status
     * @param string $parserArea
     *
     * @return void
     */
    public function __construct($user, $type, $status, $parserArea = '#content')
    {
        $this->_user = $user;
        $this->_type = $type;
        $this->_status = $status;
        $this->_url = $this->_myAnimeListUrl.'/'.$type.'list/'.$user.'?status='.$status;
        $this->_parserArea = $parserArea;

        parent::errorCheck($this);
    }

    /**
     * Default call.
     *
     * @param string $method
     * @param array  $arguments
     *
     * @return array|string|int
     */
    public function __call($method, $arguments)
    {
        if ($this->_error) {
            return $this->_error;
        }

        return call_user_func_array([$this, $method], $arguments);
    }

    /**
     * Get user list.
     *
     * @return string
     */
    private function getAllInfo()
    {
        $data = [];
        $offset = 0;
        while (true) {
            $url = $this->_myAnimeListUrl.'/'.$this->_type.'list/'.$this->_user.'/load.json?offset='.$offset.'&status='.$this->_status;

            $content = json_decode(file_get_contents($url), true);

            if ($content) {
                for ($i = 0; $i < count($content); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                    if (!empty($content[$i]['anime_image_path'])) {
                        $content[$i]['anime_image_path'] = Helper::imageUrlCleaner($content[$i]['anime_image_path']);
                    } else {
                        $content[$i]['manga_image_path'] = Helper::imageUrlCleaner($content[$i]['manga_image_path']);
                    }
                }

                $data = array_merge($data, $content);

                $offset += 300;
            } else {
                break;
            }
        }

        return $data;

    }
}


1			<?php
2
3			namespace MalScraper\Model\User;
4
5			use MalScraper\Helper\Helper;
6			use MalScraper\Model\MainModel;
7
8			/**
9			* UserListModel class.
10			*/
11			class UserListModel extends MainModel
12			{
13			/**
14			* Username.
15			*
16			* @var string
17			*/
18			private $_user;
19
20			/**
21			* Either anime or manga.
22			*
23			* @var string
24			*/
25			private $_type;
26
27			/**
28			* Anime/manga status.
29			*
30			* @var string
31			*/
32			private $_status;
33
34			/**
35			* Default constructor.
36			*
37			* @param string $user
38			* @param string $type
39			* @param string $status
40			* @param string $parserArea
41			*
42			* @return void
43			*/
44			public function __construct($user, $type, $status, $parserArea = '#content')
45			{
46			$this->_user = $user;
47			$this->_type = $type;
48			$this->_status = $status;
49			$this->_url = $this->_myAnimeListUrl.'/'.$type.'list/'.$user.'?status='.$status;
50			$this->_parserArea = $parserArea;
51
52			parent::errorCheck($this);
53			}
54
55			/**
56			* Default call.
57			*
58			* @param string $method
59			* @param array $arguments
60			*
61			* @return array\|string\|int
62			*/
63			public function __call($method, $arguments)
64			{
65			if ($this->_error) {
66			return $this->_error;
67			}
68
69			return call_user_func_array([$this, $method], $arguments);
70			}
71
72			/**
73			* Get user list.
74			*
75			* @return string
76			*/
77			private function getAllInfo()
78			{
79			$data = [];
80			$offset = 0;
81			while (true) {
82			$url = $this->_myAnimeListUrl.'/'.$this->_type.'list/'.$this->_user.'/load.json?offset='.$offset.'&status='.$this->_status;
83
84			$content = json_decode(file_get_contents($url), true);
85
86			if ($content) {
87			for ($i = 0; $i < count($content); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-10-26 06:48 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
88			if (!empty($content[$i]['anime_image_path'])) {
89			$content[$i]['anime_image_path'] = Helper::imageUrlCleaner($content[$i]['anime_image_path']);
90			} else {
91			$content[$i]['manga_image_path'] = Helper::imageUrlCleaner($content[$i]['manga_image_path']);
92			}
93			}
94
95			$data = array_merge($data, $content);
96
97			$offset += 300;
98			} else {
99			break;
100			}
101			}
102
103			return $data;
			0 ignored issues – show Bug Best Practice introduced 2018-12-15 10:26 UTC by Report Bug Copy Issue Report The expression `return $data` returns the type `array` which is incompatible with the documented return type `string`. Loading history...
104			}
105			}
106

rl404 / MAL-Scraper

Push — feature/super-model ( 86f2ea...9eaa75 )

UserListModel::getAllInfo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like