CallbackViewFactory - Code Metrics - Inspection of "- Minor changes" - rkrx/php-view - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 83fa52...e2a1f2 )

by Ron

created 2016-05-06 14:03 UTC

CallbackViewFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	34.04 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
wmc	7
c	3
b	0
f	2
lcom	1
cbo	1
dl	16
loc	47
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	create()	8	8	3
A	deriveFactory()	8	8	3

How to fix Duplicated Code

<?php
namespace View\Factories;

use View\Helpers\Directories;
use View\Renderer;
use View\ViewFactory;

class CallbackViewFactory implements ViewFactory {
	/** @var callable */
	private $callback;
	/** @var null */
	private $baseDir;
	/** @var array */
	private $vars;

	/**
	 * @param callable $callback
	 * @param string $baseDir
	 * @param array $vars
	 */
	public function __construct($callback, $baseDir = null, array $vars = []) {
		$this->callback = $callback;
		$this->baseDir = $baseDir;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		$this->vars = $vars;
	}

	/**
	 * @param string $baseDir
	 * @param array $vars
	 * @return Renderer
	 */
	public function create($baseDir = null, array $vars = []) {

		if($baseDir === null) {
			$baseDir = $this->baseDir;
		} elseif($this->baseDir !== null) {
			$baseDir = Directories::concat($this->baseDir, $baseDir);
		}
		return call_user_func($this->callback, $baseDir, $vars);
	}

	/**
	 * @param string $baseDir
	 * @param array $vars
	 * @return $this
	 */
	public function deriveFactory($baseDir = null, array $vars = []) {

		if($baseDir === null) {
			$baseDir = $this->baseDir;
		} elseif($this->baseDir !== null) {
			$baseDir = Directories::concat($this->baseDir, $baseDir);
		}
		return new static($this->callback, $baseDir, array_merge($this->vars, $vars));
	}
}


1		<?php
2		namespace View\Factories;
3
4		use View\Helpers\Directories;
5		use View\Renderer;
6		use View\ViewFactory;
7
8		class CallbackViewFactory implements ViewFactory {
9		/** @var callable */
10		private $callback;
11		/** @var null */
12		private $baseDir;
13		/** @var array */
14		private $vars;
15
16		/**
17		* @param callable $callback
18		* @param string $baseDir
19		* @param array $vars
20		*/
21		public function __construct($callback, $baseDir = null, array $vars = []) {
22		$this->callback = $callback;
23		$this->baseDir = $baseDir;
		0 ignored issues – show Documentation Bug introduced 2016-05-06 14:06 UTC by Report Bug Copy Issue Report It seems like `$baseDir` can also be of type `string`. However, the property `$baseDir` is declared as type `null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
24		$this->vars = $vars;
25		}
26
27		/**
28		* @param string $baseDir
29		* @param array $vars
30		* @return Renderer
31		*/
32	View Code Duplication	public function create($baseDir = null, array $vars = []) {
		0 ignored issues – show Duplication introduced 2016-05-06 14:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		if($baseDir === null) {
34		$baseDir = $this->baseDir;
35		} elseif($this->baseDir !== null) {
36		$baseDir = Directories::concat($this->baseDir, $baseDir);
37		}
38		return call_user_func($this->callback, $baseDir, $vars);
39		}
40
41		/**
42		* @param string $baseDir
43		* @param array $vars
44		* @return $this
45		*/
46	View Code Duplication	public function deriveFactory($baseDir = null, array $vars = []) {
		0 ignored issues – show Duplication introduced 2016-05-06 14:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		if($baseDir === null) {
48		$baseDir = $this->baseDir;
49		} elseif($this->baseDir !== null) {
50		$baseDir = Directories::concat($this->baseDir, $baseDir);
51		}
52		return new static($this->callback, $baseDir, array_merge($this->vars, $vars));
53		}
54		}
55

rkrx / php-view

Push — master ( 83fa52...e2a1f2 )

CallbackViewFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like