Complex classes like RunnableSelect often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RunnableSelect, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | class RunnableSelect extends Select implements IteratorAggregate { |
||
| 19 | /** @var array */ |
||
| 20 | private $values = array(); |
||
| 21 | /** @var bool */ |
||
| 22 | private $preserveTypes = false; |
||
| 23 | /** @var string */ |
||
| 24 | private $defaultClassName = false; |
||
| 25 | /** @var int */ |
||
| 26 | private $foundRows = 0; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param MySQL $db |
||
| 30 | * @param array $options |
||
| 31 | */ |
||
| 32 | public function __construct(MySQL $db, array $options = []) { |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @param array $values |
||
| 40 | * @return $this |
||
| 41 | */ |
||
| 42 | public function bindValues(array $values) { |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @param string $key |
||
| 49 | * @param string|int|bool|float|null $value |
||
| 50 | * @return $this |
||
| 51 | */ |
||
| 52 | public function bindValue($key, $value) { |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @return $this |
||
| 59 | */ |
||
| 60 | public function clearValues() { |
||
| 64 | |||
| 65 | /** |
||
| 66 | * @param bool $preserveTypes |
||
| 67 | * @return $this |
||
| 68 | */ |
||
| 69 | public function setPreserveTypes($preserveTypes = true) { |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @param Closure $callback |
||
| 76 | * @return array[] |
||
| 77 | */ |
||
| 78 | public function fetchRows(Closure $callback = null) { |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @param Closure $callback |
||
| 84 | * @return array[]|\Generator |
||
| 85 | */ |
||
| 86 | public function fetchRowsLazy(Closure $callback = null) { |
||
| 89 | |||
| 90 | /** |
||
| 91 | * @param Closure|null $callback |
||
| 92 | * @return mixed[] |
||
| 93 | * @throws \Exception |
||
| 94 | */ |
||
| 95 | public function fetchRow(Closure $callback = null) { |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @param string $className |
||
| 103 | * @param Closure $callback |
||
| 104 | * @return object[] |
||
| 105 | * @throws \Exception |
||
| 106 | */ |
||
| 107 | public function fetchObjects($className = null, Closure $callback = null) { |
||
| 110 | |||
| 111 | /** |
||
| 112 | * @param string $className |
||
| 113 | * @param Closure $callback |
||
| 114 | * @return object[]|Generator |
||
| 115 | */ |
||
| 116 | public function fetchObjectsLazy($className = null, Closure $callback = null) { |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @param string $className |
||
| 122 | * @param Closure|null $callback |
||
| 123 | * @return object[] |
||
| 124 | * @throws \Exception |
||
| 125 | */ |
||
| 126 | public function fetchObject($className = null, Closure $callback = null) { |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @param bool $treatValueAsArray |
||
| 134 | * @return mixed[] |
||
| 135 | */ |
||
| 136 | public function fetchKeyValue($treatValueAsArray = false) { |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @param array $fields |
||
| 153 | * @return array |
||
| 154 | */ |
||
| 155 | public function fetchGroups(array $fields) { |
||
| 171 | |||
| 172 | /** |
||
| 173 | * @return string[] |
||
| 174 | */ |
||
| 175 | public function fetchArray() { |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @param mixed $default |
||
| 183 | * @return null|bool|string|int|float |
||
| 184 | */ |
||
| 185 | public function fetchValue($default = null) { |
||
| 194 | |||
| 195 | /** |
||
| 196 | * @return bool |
||
| 197 | */ |
||
| 198 | public function getFoundRows() { |
||
| 201 | |||
| 202 | /** |
||
| 203 | * @param callback $fn |
||
| 204 | * @return mixed |
||
| 205 | * @throws \Exception |
||
| 206 | */ |
||
| 207 | private function createTempStatement($fn) { |
||
| 219 | |||
| 220 | /** |
||
| 221 | * @return QueryStatement |
||
| 222 | */ |
||
| 223 | private function createStatement() { |
||
| 233 | |||
| 234 | /** |
||
| 235 | * @return Traversable|array[]|\Generator |
||
| 236 | */ |
||
| 237 | public function getIterator() { |
||
| 240 | |||
| 241 | /** |
||
| 242 | * @param Closure $callback |
||
| 243 | * @param int $mode |
||
| 244 | * @param mixed $arg0 |
||
| 245 | * @return mixed |
||
| 246 | * @throws \Exception |
||
| 247 | */ |
||
| 248 | private function fetchAll(Closure $callback = null, $mode, $arg0 = null) { |
||
| 274 | |||
| 275 | /** |
||
| 276 | * @param Closure $callback |
||
| 277 | * @param int $mode |
||
| 278 | * @param mixed $arg0 |
||
| 279 | * @return Generator|YieldPolyfillIterator|mixed[] |
||
| 280 | */ |
||
| 281 | private function fetchLazy(Closure $callback = null, $mode, $arg0 = null) { |
||
| 294 | |||
| 295 | /** |
||
| 296 | * @param Closure $callback |
||
| 297 | * @param int $mode |
||
| 298 | * @param mixed $arg0 |
||
| 299 | * @param Closure $resultValidator |
||
| 300 | * @return mixed |
||
| 301 | * @throws \Exception |
||
| 302 | */ |
||
| 303 | private function fetch(Closure $callback = null, $mode, $arg0 = null, Closure $resultValidator = null) { |
||
| 324 | } |
||
| 325 |