rkit\filemanager\models\File

Complexity

Total Complexity

15

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	tableName()	0	4	1
A	attributeLabels()	0	15	1
A	behaviors()	0	11	1
B	beforeSave()	0	14	5
A	fillMetaInfo()	0	12	2
A	detectExtension()	0	19	4
A	generateName()	0	5	1

<?php

/**
 * @link https://github.com/rkit/filemanager-yii2
 * @copyright Copyright (c) 2015 Igor Romanov
 * @license [MIT](http://opensource.org/licenses/MIT)
 */

namespace rkit\filemanager\models;

use Yii;
use yii\behaviors\TimestampBehavior;
use yii\helpers\FileHelper;

/**
 * ActiveRecord for table "file"
 *
 * @property integer $id
 * @property integer $user_id
 * @property string $title
 * @property string $name
 * @property integer $size
 * @property string $extension
 * @property string $mime
 * @property string $date_create
 * @property string $date_update
 * @property integer $ip
 */
class File extends \yii\db\ActiveRecord
{
    /**
     * @var string
     */
    public $path;
    /**
     * @inheritdoc
     * @codeCoverageIgnore
     * @internal
     */
    public static function tableName()
    {
        return 'file';
    }

    /**
     * @inheritdoc
     * @codeCoverageIgnore
     * @internal
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('filemanager-yii2', 'ID'),
            'user_id' => Yii::t('filemanager-yii2', 'User'),
            'title' => Yii::t('filemanager-yii2', 'Title'),
            'name' => Yii::t('filemanager-yii2', 'Name'),
            'size' => Yii::t('filemanager-yii2', 'Size'),
            'extension' => Yii::t('filemanager-yii2', 'Extension'),
            'mime' => Yii::t('filemanager-yii2', 'Mime'),
            'date_create' => Yii::t('filemanager-yii2', 'Date create'),
            'date_update' => Yii::t('filemanager-yii2', 'Date update'),
            'ip' => Yii::t('filemanager-yii2', 'IP'),
        ];
    }

    /**
     * @inheritdoc
     * @internal
     */
    public function behaviors()
    {
        return [
            [
                'class' => TimestampBehavior::className(),
                'createdAtAttribute' => 'date_create',
                'updatedAtAttribute' => 'date_update',
                'value' => new \yii\db\Expression('NOW()'),
            ],
        ];
    }

    /**
     * @internal
     */
    public function beforeSave($insert)
    {
        if (parent::beforeSave($insert)) {
            if ($insert) {
                if (!Yii::$app instanceof \yii\console\Application) {
                    $this->user_id = Yii::$app->user->isGuest ? 0 : Yii::$app->user->id; // @codeCoverageIgnore
                    $this->ip = ip2long(Yii::$app->request->getUserIP()); // @codeCoverageIgnore
                } // @codeCoverageIgnore
                $this->fillMetaInfo();
            }
            return true;
        }
        return false; // @codeCoverageIgnore
    }

    /**
     * Fill meta info
     *
     * @param string $path File path

There is no parameter named $path. Was it maybe removed?

     * @return void
     * @SuppressWarnings(PHPMD.ElseExpression)
     */
    private function fillMetaInfo()
    {
        $pathInfo = pathinfo($this->path);

        if ($this->title === null) {
            $this->title = $pathInfo['filename'];
        }

        $this->size = filesize($this->path);
        $this->mime = FileHelper::getMimeType($this->path);
        $this->name = $this->generateName($this->path, $this->mime);
    }

    /**
     * Get extension By MimeType
     *
     * @return string
     */
    private function detectExtension($path, $mimeType)
    {
        $extensions = FileHelper::getExtensionsByMimeType($mimeType);
        $pathExtension = pathinfo($path, PATHINFO_EXTENSION);
        $titleExtension = pathinfo($this->title, PATHINFO_EXTENSION);

        if (array_search($pathExtension, $extensions) !== false) {
            return $pathExtension;
        } elseif (array_search($titleExtension, $extensions) !== false) {
            return $titleExtension;
        }
        $extension = explode('/', $mimeType);
        $extension = end($extension);
        if (array_search($extension, $extensions) !== false) {
            return $extension;
        }

        return current($extensions); // @codeCoverageIgnore

The expression current($extensions); of type integer|string|false adds false to the return on line 142 which is incompatible with the return type documented by rkit\filemanager\models\File::detectExtension of type string. It seems like you forgot to handle an error condition.

    }

    /**
     * Generate a name
     *
     * @return string
     */
    private function generateName($path, $mimeType)
    {
        $name = date('YmdHis') . substr(md5(microtime() . uniqid()), 0, 10);
        return $name . '.' . $this->detectExtension($path, $mimeType);
    }
}