app\modules\admin\controllers\UsersController

Complexity

Total Complexity

23

Size/Duplication

Total Lines	161
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

30.26%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	0	13	1
A	behaviors()	0	16	1
B	actions()	0	34	1
C	actionEdit()	0	33	8
B	actionProfile()	0	22	6
A	actionAutocomplete()	0	20	3
A	assignRole()	0	12	3

<?php

namespace app\modules\admin\controllers;

use Yii;
use yii\filters\VerbFilter;
use yii\helpers\Url;
use yii\web\Response;
use app\traits\ModelTrait;
use app\models\User;
use app\models\UserProfile;
use app\modules\admin\models\search\UserSearch;

class UsersController extends \yii\web\Controller
{
    use ModelTrait;

    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'set-active' => ['post'],
                    'set-block' => ['post'],
                    'delete' => ['post'],
                    'operations' => ['post'],
                    'photo-upload' => ['post'],
                    'autocomplete' => ['post'],
                ],
            ],
        ];
    }

    public function actions()
    {
        return [
            'operations' => [
                'class' => 'app\modules\admin\controllers\common\OperationsAction',
                'modelClass' => 'app\models\User',
                'operations' => [
                    'delete' => [],
                    'set-active' => ['status' => User::STATUS_ACTIVE],
                    'set-block' => ['status' => User::STATUS_BLOCKED]
                ]
            ],
            'set-active' => [
                'class' => 'app\modules\admin\controllers\common\UpdateAttributesAction',
                'modelClass' => 'app\models\User',
                'attributes' => ['status' => User::STATUS_ACTIVE],
            ],
            'set-block' => [
                'class' => 'app\modules\admin\controllers\common\UpdateAttributesAction',
                'modelClass' => 'app\models\User',
                'attributes' => ['status' => User::STATUS_BLOCKED],
            ],
            'delete' => [
                'class' => 'app\modules\admin\controllers\common\DeleteAction',
                'modelClass' => 'app\models\User',
            ],
            'photo-upload' => [
                'class'     => 'rkit\filemanager\actions\UploadAction',
                'modelClass' => 'app\models\UserProfile',
                'attribute' => 'photo',
                'inputName' => 'file',
            ],
        ];
    }

    public function actionIndex()
    {
        $userSearch = new UserSearch();
        $dataProvider = $userSearch->search(Yii::$app->request->get());
        $statuses = User::getStatuses();

        return $this->render('index', [
            'userSearch' => $userSearch,
            'dataProvider' => $dataProvider,
            'statuses' => $statuses,
            'roles' => Yii::$app->authManager->getRoles()
        ]);
    }

    public function actionEdit($id = null)
    {
        $model = new User();

        if ($id) {
            $model = $this->findModel($model, $id);

$model is of type object<app\models\User>, but the function expects a object<app\traits\ActiveRecord>.

        }

        if (Yii::$app->request->isPost) {
            if ($model->isNewRecord) {
                $model->setConfirmed();
            }

            if ($model->load(Yii::$app->request->post()) && $model->save()) {
                $this->assignRole($model);

                Yii::$app->session->setFlash('success', Yii::t('app.messages', 'Saved successfully'));
                $urlToModel = Url::toRoute(['edit', 'id' => $model->id]);
                if (Yii::$app->request->isAjax) {
                    return $this->asJson(['redirect' => $urlToModel]);
                }
                return $this->redirect($urlToModel);
            }
            if (Yii::$app->request->isAjax) {
                return $this->asJson($this->collectErrors($model));

It seems like $model defined by new \app\models\User() on line 86 can also be of type object<app\models\User>; however, app\traits\ModelTrait::collectErrors() does only seem to accept object<app\traits\Model>, maybe add an additional type check?

            }
        }

        return $this->render('edit', [
            'model' => $model,
            'roles' => Yii::$app->authManager->getRoles()
        ]);
    }

    public function actionProfile($id)
    {
        $model = $this->findModel(new UserProfile(), $id);

new \app\models\UserProfile() is of type object<app\models\UserProfile>, but the function expects a object<app\traits\ActiveRecord>.

        if (Yii::$app->request->isPost) {
            if ($model->load(Yii::$app->request->post()) && $model->save()) {
                Yii::$app->session->setFlash('success', Yii::t('app.messages', 'Saved successfully'));
                $urlToModel = Url::toRoute(['profile', 'id' => $model->user_id]);
                if (Yii::$app->request->isAjax) {
                    return $this->asJson(['redirect' => $urlToModel]);
                }
                return $this->redirect($urlToModel);
            }
            if (Yii::$app->request->isAjax) {
                return $this->asJson($this->collectErrors($model));
            }
        }

        return $this->render('profile', [
            'model' => $model
        ]);
    }

    public function actionAutocomplete()
    {
        $result = [];
        if (($term = Yii::$app->request->post('term')) !== null) {
            $data = User::find()
                ->like('username', $term)
                ->asArray()
                ->limit(10)
                ->all();

            foreach ($data as $item) {
                $result[] = [
                    'text' => $item['username'],
                    'id' => $item['id']
                ];
            }
        }

        return $this->asJson($result);
    }

    private function assignRole($model)
    {
        $auth = Yii::$app->authManager;
        $auth->revokeAll($model->id);

        if (!empty($model->role)) {
            $role = $auth->getRole($model->role);
            if ($role) {
                $auth->assign($role, $model->id);
            }
        }
    }
}