app\services\SocialAuth::execute()

Complexity

Conditions	6
Paths	9

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	SocialAuth::parser()	0	5	1

<?php

namespace app\services;

use yii\authclient\ClientInterface;
use app\models\entity\User;
use app\models\entity\UserProvider;

/**
 * SocialAuth handles successful authentication
 */
class SocialAuth
{
    /**
     * @var int
     */
    private $provider;
    /**
     * @var int
     */
    private $providerId;
    /**
     * @var ClientInterface
     */
    private $client;
    /**
     * @var array
     */
    public $parsers;

    public function __construct(ClientInterface $client)
    {
        $this->client = $client;
        $this->provider = UserProvider::getTypeByName($client->id);

Accessing id on the interface yii\authclient\ClientInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->providerId = $client->getUserAttributes()['id'];
    }

    public function prepareUser(): ?User
    {
        $user = null;
        $parser = $this->parser();

        $profileData = $parser->profileData();
        $tokenData = ['type' => $this->provider] + $parser->tokenData();

        if ($provider = UserProvider::find()->provider($this->provider, $this->providerId)->one()) {
            $user = $provider->user;

            // if exist then update access tokens
            $provider->setAttributes($tokenData);
            $provider->save();
        }

        if (!is_object($user)) {
            $user = new User();

            $user->email = $parser->email();
            $user->setProfile($profileData);
            $user->setProviders($tokenData);
        }

        return $user;
    }

    private function parser()
    {
        $parserClass = $this->parsers[$this->client->id];

Accessing id on the interface yii\authclient\ClientInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        return new $parserClass($this->client);
    }
}