ResetPasswordForm::resetPassword() - Code Metrics - Inspection of "Refactor" - rkit/bootstrap-yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89be15...80fd60 )

by Igor

created 2017-11-07 10:19 UTC

ResetPasswordForm::resetPassword() A

↳ Parent: ResetPasswordForm

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	0

<?php

namespace app\modules\auth\models\forms;

use Yii;
use yii\base\Exception;
use yii\web\BadRequestHttpException;
use app\models\entity\User;
use app\modules\auth\services\Tokenizer;

class ResetPasswordForm extends \yii\base\Model
{
    /**
     * @var string
     */
    public $password;
    /**
     * @var \app\models\entity\User
     */
    private $user;

    /**
     * Creates a form model given a token.
     *
     * @param string $token
     * @param array $config name-value pairs that will be used to initialize the object properties
     * @throws \yii\base\BadRequestHttpException
     */
    public function __construct($token, $config = [])
    {
        $tokenizer = new Tokenizer();
        if (empty($token) || !is_string($token) || !$tokenizer->validate($token)) {
            throw new BadRequestHttpException(Yii::t('app.msg', 'Invalid link for reset password'));
        }

        $this->user = User::find()->passwordResetToken($token)->one();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if (!$this->user) {
            throw new BadRequestHttpException(Yii::t('app.msg', 'Invalid link for reset password'));
        }

        parent::__construct($config);
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['password', 'required'],
            ['password', 'string', 'min' => 6],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'password' => Yii::t('app', 'Password'),
        ];
    }

    /**
     * Resets password
     *
     * @throws Exception
     */
    public function resetPassword(): void
    {
        $this->user->setPassword($this->password);
        $this->user->removePasswordResetToken();
        $this->user->updateDateLogin();

        if (!$this->user->save()) {
            throw new Exception(Yii::t('app.msg', 'An error occurred while saving user'));
        }

        Yii::$app->user->login($this->user, 3600 * 24 * 30);
    }
}


1			<?php
2
3			namespace app\modules\auth\models\forms;
4
5			use Yii;
6			use yii\base\Exception;
7			use yii\web\BadRequestHttpException;
8			use app\models\entity\User;
9			use app\modules\auth\services\Tokenizer;
10
11			class ResetPasswordForm extends \yii\base\Model
12			{
13			/**
14			* @var string
15			*/
16			public $password;
17			/**
18			* @var \app\models\entity\User
19			*/
20			private $user;
21
22			/**
23			* Creates a form model given a token.
24			*
25			* @param string $token
26			* @param array $config name-value pairs that will be used to initialize the object properties
27			* @throws \yii\base\BadRequestHttpException
28			*/
29			public function __construct($token, $config = [])
30			{
31			$tokenizer = new Tokenizer();
32			if (empty($token) \|\| !is_string($token) \|\| !$tokenizer->validate($token)) {
33			throw new BadRequestHttpException(Yii::t('app.msg', 'Invalid link for reset password'));
34			}
35
36			$this->user = User::find()->passwordResetToken($token)->one();
			0 ignored issues – show Documentation Bug introduced 2017-09-12 09:36 UTC by Report Bug Copy Issue Report It seems like `\app\models\entity\User:...setToken($token)->one()` can also be of type `object<yii\db\ActiveRecord>` or `array`. However, the property `$user` is declared as type `object<app\models\entity\User>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
37
38			if (!$this->user) {
39			throw new BadRequestHttpException(Yii::t('app.msg', 'Invalid link for reset password'));
40			}
41
42			parent::__construct($config);
43			}
44
45			/**
46			* @inheritdoc
47			*/
48			public function rules()
49			{
50			return [
51			['password', 'required'],
52			['password', 'string', 'min' => 6],
53			];
54			}
55
56			/**
57			* @inheritdoc
58			*/
59			public function attributeLabels()
60			{
61			return [
62			'password' => Yii::t('app', 'Password'),
63			];
64			}
65
66			/**
67			* Resets password
68			*
69			* @throws Exception
70			*/
71			public function resetPassword(): void
72			{
73			$this->user->setPassword($this->password);
74			$this->user->removePasswordResetToken();
75			$this->user->updateDateLogin();
76
77			if (!$this->user->save()) {
78			throw new Exception(Yii::t('app.msg', 'An error occurred while saving user'));
79			}
80
81			Yii::$app->user->login($this->user, 3600 * 24 * 30);
82			}
83			}
84

rkit / bootstrap-yii2

Push — master ( 89be15...80fd60 )

ResetPasswordForm::resetPassword() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like