AdminFilter::checkAccess() - Code Metrics - Inspection of "Refactor" - rkit/bootstrap-yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89be15...80fd60 )

by Igor

created 2017-11-07 10:19 UTC

AdminFilter::checkAccess() A

↳ Parent: AdminFilter

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	3
nop	1

<?php

namespace app\modules\admin\filters;

use Yii;
use yii\base\ActionFilter;
use yii\web\ForbiddenHttpException;

class AdminFilter extends ActionFilter
{
    public $permissions = [];

    public function beforeAction($action)
    {
        if (Yii::$app->user->isGuest === false) {
            $this->permissions = $this->getUserPermissions();
        }

        if (parent::beforeAction($action)) {
            return $this->checkAccess($action);
        }

        return false;
    }

    public function checkAccess($action)
    {
        if ($action->controller->id === 'index') {
            return true;
        }

        if (!\Yii::$app->user->can('AdminModule') ||
            !\Yii::$app->user->can($this->getCurrentPermissionName($action))
        ) {
            throw new ForbiddenHttpException(Yii::t('app.msg', 'Access Denied'));
        }

        return true;
    }

    private function getCurrentPermissionName($action)
    {
        return 'ACTION_Admin' . ucfirst($action->controller->id);
    }

    private function getUserPermissions()
    {
        $authManager = Yii::$app->authManager;

        if (Yii::$app->user->identity->isSuperUser() === false) {
            return $authManager->getPermissionsByRole(Yii::$app->user->identity->role);
        }

        return Yii::$app->cache->getOrSet(
            'rbac-permissions',
            function () use ($authManager) {
                return $authManager->getPermissions();
            }
        );
    }
}


1			<?php
2
3			namespace app\modules\admin\filters;
4
5			use Yii;
6			use yii\base\ActionFilter;
7			use yii\web\ForbiddenHttpException;
8
9			class AdminFilter extends ActionFilter
10			{
11			public $permissions = [];
12
13			public function beforeAction($action)
14			{
15			if (Yii::$app->user->isGuest === false) {
16			$this->permissions = $this->getUserPermissions();
17			}
18
19			if (parent::beforeAction($action)) {
20			return $this->checkAccess($action);
21			}
22
23			return false;
24			}
25
26			public function checkAccess($action)
27			{
28			if ($action->controller->id === 'index') {
29			return true;
30			}
31
32			if (!\Yii::$app->user->can('AdminModule') \|\|
33			!\Yii::$app->user->can($this->getCurrentPermissionName($action))
34			) {
35			throw new ForbiddenHttpException(Yii::t('app.msg', 'Access Denied'));
36			}
37
38			return true;
39			}
40
41			private function getCurrentPermissionName($action)
42			{
43			return 'ACTION_Admin' . ucfirst($action->controller->id);
44			}
45
46			private function getUserPermissions()
47			{
48			$authManager = Yii::$app->authManager;
49
50			if (Yii::$app->user->identity->isSuperUser() === false) {
51			return $authManager->getPermissionsByRole(Yii::$app->user->identity->role);
52			}
53
54			return Yii::$app->cache->getOrSet(
55			'rbac-permissions',
56			function () use ($authManager) {
57			return $authManager->getPermissions();
58			}
59			);
60			}
61			}
62

rkit / bootstrap-yii2

Push — master ( 89be15...80fd60 )

AdminFilter::checkAccess() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like