SignupProviderForm::signup() - Code Metrics - Inspection of "Refactor social auth" - rkit/bootstrap-yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7e20fc...28c56b )

by Igor

created 2017-04-26 06:54 UTC

SignupProviderForm::signup() A

↳ Parent: SignupProviderForm

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	8
ccs	0
cts	6
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

namespace app\models\forms;

use Yii;
use yii\base\DynamicModel;
use yii\helpers\FileHelper;
use yii\web\UploadedFile;
use app\models\User;

class SignupProviderForm extends \yii\base\Model
{
    /**
     * @var string
     */
    public $email;
    /**
     * @var \app\models\User
     */
    private $user = null;

    /**
     * @param User $user
     */
    public function __construct($user, $email)
    {
        $this->user = $user;
        $this->email = $email;
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['email', 'filter', 'filter' => 'trim'],
            ['email', 'required'],
            ['email', 'string', 'max' => 255],
            ['email', 'email'],
            ['email', 'unique',
                'targetClass' => '\app\models\User',
                'message' => Yii::t('app.validators', 'This email address has already been taken')
            ],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return (new User())->attributeLabels();
    }

    /**
     * Create manually UploadedFile instance by file path
     *
     * @param string $path file path
     * @return UploadedFile
     */
    private function makeUploadedFile($path)
    {
        $tmpFile = tempnam(sys_get_temp_dir(), 'app');
        file_put_contents($tmpFile, file_get_contents($path));

        $uploadedFile = new UploadedFile();
        $uploadedFile->name = pathinfo($path, PATHINFO_BASENAME);
        $uploadedFile->tempName = $tmpFile;
        $uploadedFile->type = FileHelper::getMimeType($tmpFile);
        $uploadedFile->size = filesize($tmpFile);
        $uploadedFile->error = 0;

        return $uploadedFile;
    }

    /**
     * Save photo
     *
     * @param \app\models\UserProfile $profile
     * @param string $photo
     * @return void
     */
    private function savePhoto($profile, $photo)
    {
        $file = $this->makeUploadedFile($photo);
        $model = new DynamicModel(compact('file'));
        $model->addRule('file', 'image', $profile->fileRules('photo', true))->validate();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (!$model->hasErrors()) {
            $profile->createFile('photo', $file->tempName, $model->file->name);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
    }

    /**
     * Save user
     *
     * @return bool
     */
    public function saveUser()
    {
        $this->user->email = $this->email;

        $profile = $this->user->profile;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($profile->isNewRecord && !empty($profile->photo)) {
            $this->savePhoto($profile, $profile->photo);
        }

        if ($this->user->save()) {
            return true;
        }

        $this->addErrors($this->user->getErrors());
        return false;
    }

    /**
     * Login
     *
     * @return bool
     */
    public function login()
    {
        return $this->user->authorize(true);
    }

    /**
     * Signs user up
     *
     * @return bool
     */
    public function signup()
    {
        if ($this->validate()) {
            return $this->saveUser();
        } // @codeCoverageIgnore

        return false;
    }

    /**
     * Sends an email with a link, for confirm the email
     *
     * @return boolean
     */
    public function sendEmail()
    {
        if (!User::isTokenValid($this->user->email_confirm_token)) {
            $this->user->generateEmailConfirmToken();
            $this->user->updateAttributes([
                'email_confirm_token' => $this->user->email_confirm_token,
                'date_confirm' => $this->user->date_confirm,
            ]);
        }

        return Yii::$app->notify->sendMessage(
            $this->email,
            Yii::t('app', 'Activate Your Account'),
            'emailConfirmToken',
            ['user' => $this->user]
        );
    }
}


1			<?php
2
3			namespace app\models\forms;
4
5			use Yii;
6			use yii\base\DynamicModel;
7			use yii\helpers\FileHelper;
8			use yii\web\UploadedFile;
9			use app\models\User;
10
11			class SignupProviderForm extends \yii\base\Model
12			{
13			/**
14			* @var string
15			*/
16			public $email;
17			/**
18			* @var \app\models\User
19			*/
20			private $user = null;
21
22			/**
23			* @param User $user
24			*/
25			public function __construct($user, $email)
26			{
27			$this->user = $user;
28			$this->email = $email;
29			}
30
31			/**
32			* @inheritdoc
33			*/
34			public function rules()
35			{
36			return [
37			['email', 'filter', 'filter' => 'trim'],
38			['email', 'required'],
39			['email', 'string', 'max' => 255],
40			['email', 'email'],
41			['email', 'unique',
42			'targetClass' => '\app\models\User',
43			'message' => Yii::t('app.validators', 'This email address has already been taken')
44			],
45			];
46			}
47
48			/**
49			* @inheritdoc
50			*/
51			public function attributeLabels()
52			{
53			return (new User())->attributeLabels();
54			}
55
56			/**
57			* Create manually UploadedFile instance by file path
58			*
59			* @param string $path file path
60			* @return UploadedFile
61			*/
62			private function makeUploadedFile($path)
63			{
64			$tmpFile = tempnam(sys_get_temp_dir(), 'app');
65			file_put_contents($tmpFile, file_get_contents($path));
66
67			$uploadedFile = new UploadedFile();
68			$uploadedFile->name = pathinfo($path, PATHINFO_BASENAME);
69			$uploadedFile->tempName = $tmpFile;
70			$uploadedFile->type = FileHelper::getMimeType($tmpFile);
71			$uploadedFile->size = filesize($tmpFile);
72			$uploadedFile->error = 0;
73
74			return $uploadedFile;
75			}
76
77			/**
78			* Save photo
79			*
80			* @param \app\models\UserProfile $profile
81			* @param string $photo
82			* @return void
83			*/
84			private function savePhoto($profile, $photo)
85			{
86			$file = $this->makeUploadedFile($photo);
87			$model = new DynamicModel(compact('file'));
88			$model->addRule('file', 'image', $profile->fileRules('photo', true))->validate();
			0 ignored issues – show Documentation Bug introduced 2016-11-03 10:47 UTC by Report Bug Copy Issue Report The method `fileRules` does not exist on `object<app\models\UserProfile>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
89			if (!$model->hasErrors()) {
90			$profile->createFile('photo', $file->tempName, $model->file->name);
			0 ignored issues – show Documentation Bug introduced 2016-08-24 04:12 UTC by Report Bug Copy Issue Report The method `createFile` does not exist on `object<app\models\UserProfile>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
91			}
92			}
93
94			/**
95			* Save user
96			*
97			* @return bool
98			*/
99			public function saveUser()
100			{
101			$this->user->email = $this->email;
102
103			$profile = $this->user->profile;
			0 ignored issues – show Documentation introduced 2016-09-19 17:06 UTC by Report Bug Copy Issue Report The property `profile` does not exist on `object<app\models\User>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
104			if ($profile->isNewRecord && !empty($profile->photo)) {
105			$this->savePhoto($profile, $profile->photo);
106			}
107
108			if ($this->user->save()) {
109			return true;
110			}
111
112			$this->addErrors($this->user->getErrors());
113			return false;
114			}
115
116			/**
117			* Login
118			*
119			* @return bool
120			*/
121			public function login()
122			{
123			return $this->user->authorize(true);
124			}
125
126			/**
127			* Signs user up
128			*
129			* @return bool
130			*/
131			public function signup()
132			{
133			if ($this->validate()) {
134			return $this->saveUser();
135			} // @codeCoverageIgnore
136
137			return false;
138			}
139
140			/**
141			* Sends an email with a link, for confirm the email
142			*
143			* @return boolean
144			*/
145			public function sendEmail()
146			{
147			if (!User::isTokenValid($this->user->email_confirm_token)) {
148			$this->user->generateEmailConfirmToken();
149			$this->user->updateAttributes([
150			'email_confirm_token' => $this->user->email_confirm_token,
151			'date_confirm' => $this->user->date_confirm,
152			]);
153			}
154
155			return Yii::$app->notify->sendMessage(
156			$this->email,
157			Yii::t('app', 'Activate Your Account'),
158			'emailConfirmToken',
159			['user' => $this->user]
160			);
161			}
162			}
163

rkit / bootstrap-yii2

Push — master ( 7e20fc...28c56b )

SignupProviderForm::signup() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like