SettingsController::actionIndex() - Code Metrics - Inspection of "Upd .travis" - rkit/bootstrap-yii2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7544d...5e7707 )

by Igor

created 2017-04-27 17:03 UTC

SettingsController::actionIndex() B

↳ Parent: SettingsController

Complexity

Conditions	5
Paths	4

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	19
ccs	11
cts	11
cp	1
rs	8.8571
cc	5
eloc	11
nc	4
nop	0
crap	5

<?php

namespace app\modules\admin\controllers;

use Yii;
use yii\web\Response;
use app\traits\ModelTrait;
use app\modules\admin\models\forms\SettingsForm;

class SettingsController extends \yii\web\Controller
{
    use ModelTrait;

    public function actionIndex()
    {
        $model = new SettingsForm();

        if (Yii::$app->request->isPost) {
            if ($model->load(Yii::$app->request->post()) && $model->validate()) {
                Yii::$app->settings->load($model->getAttributes());
                Yii::$app->session->setFlash('success', Yii::t('app.messages', 'Saved successfully'));
                return $this->refresh();
            }
            if (Yii::$app->request->isAjax) {
                return $this->asJson($this->collectErrors($model));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        $model->setAttributes(Yii::$app->settings->all());

        return $this->render('index', ['model' => $model]);
    }
}


1		<?php
2
3		namespace app\modules\admin\controllers;
4
5		use Yii;
6		use yii\web\Response;
7		use app\traits\ModelTrait;
8		use app\modules\admin\models\forms\SettingsForm;
9
10		class SettingsController extends \yii\web\Controller
11		{
12		use ModelTrait;
13
14	7	public function actionIndex()
15		{
16	7	$model = new SettingsForm();
17
18	7	if (Yii::$app->request->isPost) {
19	5	if ($model->load(Yii::$app->request->post()) && $model->validate()) {
20	3	Yii::$app->settings->load($model->getAttributes());
21	3	Yii::$app->session->setFlash('success', Yii::t('app.messages', 'Saved successfully'));
22	3	return $this->refresh();
23		}
24	2	if (Yii::$app->request->isAjax) {
25	1	return $this->asJson($this->collectErrors($model));
		0 ignored issues – show Documentation introduced 2017-04-25 07:22 UTC by Report Bug Copy Issue Report `$model` is of type `object<app\modules\admin...els\forms\SettingsForm>`, but the function expects a `object<app\traits\Model>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26		}
27		}
28
29	7	$model->setAttributes(Yii::$app->settings->all());
30
31	7	return $this->render('index', ['model' => $model]);
32		}
33		}
34

rkit / bootstrap-yii2

Push — master ( c7544d...5e7707 )

SettingsController::actionIndex() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like