Risan\OAuth1\Credentials\CredentialsFactory

Complexity

Total Complexity

9

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createTemporaryCredentialsFromResponse()	0	20	3
A	createTokenCredentialsFromResponse()	0	15	2
A	getParametersFromResponse()	0	8	1
A	getMissingParameterKey()	0	8	3

<?php

namespace Risan\OAuth1\Credentials;

use Psr\Http\Message\ResponseInterface;
use Risan\OAuth1\Credentials\CredentialsFactoryInterface;

class CredentialsFactory implements CredentialsFactoryInterface
{
    /**
     * {@inheritDoc}
     */
    public function createTemporaryCredentialsFromResponse(ResponseInterface $response)
    {
        $parameters = $this->getParametersFromResponse($response);

        $missingParameterKey = $this->getMissingParameterKey($parameters, [

It seems like $parameters defined by $this->getParametersFromResponse($response) on line 15 can also be of type null; however, Risan\OAuth1\Credentials\CredentialsFactory::getMissingParameterKey() does only seem to accept array, maybe add an additional type check?

            'oauth_token',
            'oauth_token_secret',
            'oauth_callback_confirmed',
        ]);

        if (null !== $missingParameterKey) {
            throw new CredentialsException("Unable to parse temporary credentials response. Missing parameter: {$missingParameterKey}.");
        }

        if ($parameters['oauth_callback_confirmed'] !== 'true') {
            throw new CredentialsException('Unable to parse temporary credentials response. Callback URI is not valid.');
        }

        return new TemporaryCredentials($parameters['oauth_token'], $parameters['oauth_token_secret']);
    }

    /**
     * {@inheritDoc}
     */
    public function createTokenCredentialsFromResponse(ResponseInterface $response)
    {
        $parameters = $this->getParametersFromResponse($response);

        $missingParameterKey = $this->getMissingParameterKey($parameters, [

It seems like $parameters defined by $this->getParametersFromResponse($response) on line 39 can also be of type null; however, Risan\OAuth1\Credentials\CredentialsFactory::getMissingParameterKey() does only seem to accept array, maybe add an additional type check?

            'oauth_token',
            'oauth_token_secret',
        ]);

        if (null !== $missingParameterKey) {
            throw new CredentialsException("Unable to parse token credentials response. Missing parameter: {$missingParameterKey}.");
        }

        return new TokenCredentials($parameters['oauth_token'], $parameters['oauth_token_secret']);
    }

    /**
     * Get parameters from response.
     *
     * @param  \Psr\Http\Message\ResponseInterface $response
     * @return array
     */
    public function getParametersFromResponse(ResponseInterface $response)
    {
        $contents = $response->getBody()->getContents();

        parse_str($contents, $parameters);

        return $parameters;
    }

    /**
     * Get missing parameter's key.
     *
     * @param  array  $parameters
     * @param  array  $requiredKeys
     * @return string|null
     */
    public function getMissingParameterKey(array $parameters, array $requiredKeys = [])
    {
        foreach ($requiredKeys as $key) {
            if (! isset($parameters[$key])) {
                return $key;
            }
        }
    }
}