RequestFactory::buildAuthorizationUri() - Code Metrics - Inspection of ":fire: Remove OAuth1Factory class." - risan/oauth1 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( de0fb5...78995e )

by Risan Bagja

created 2017-10-21 22:16 UTC

RequestFactory::buildAuthorizationUri() A

↳ Parent: RequestFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	1

<?php

namespace Risan\OAuth1\Request;

use Risan\OAuth1\Credentials\TemporaryCredentials;

class RequestFactory implements RequestFactoryInterface
{
    /**
     * The AuthorizationHeaderInterface instance.
     *
     * @var \Risan\OAuth1\Request\AuthorizationHeaderInterface
     */
    protected $authorizationHeader;

    /**
     * The UriParserInterface instance.
     *
     * @var \Risan\OAuth1\Request\UriParserInterface
     */
    protected $uriParser;

    /**
     * Create the new instance of RequestFactory class.
     *
     * @param \Risan\OAuth1\Request\AuthorizationHeaderInterface $authorizationHeader
     * @param \Risan\OAuth1\Request\UriParserInterface $uriParser
     */
    public function __construct(AuthorizationHeaderInterface $authorizationHeader, UriParserInterface $uriParser)
    {
        $this->authorizationHeader = $authorizationHeader;
        $this->uriParser = $uriParser;
    }

    /**
     * {@inheritDoc}
     */
    public function getAuthorizationHeader()
    {
        return $this->authorizationHeader;
    }

    /**
     * {@inheritDoc}
     */
    public function getConfig()
    {
        return $this->authorizationHeader->getConfig();
    }

    /**
     * {@inheritDoc}
     */
    public function getUriParser()
    {
        return $this->uriParser;
    }

    /**
     * {@inheritDoc}
     */
    public function createForTemporaryCredentials()
    {
        return $this->create('POST', $this->getConfig()->getTemporaryCredentialsUri(), [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'headers' => [
                'Authorization' => $this->authorizationHeader->forTemporaryCredentials(),
            ],
        ]);
    }

    /**
     * {@inheritDoc}
     */
    public function buildAuthorizationUri(TemporaryCredentials $temporaryCredentials)
    {
        return $this->uriParser->appendQueryParameters(
            $this->getConfig()->getAuthorizationUri(),
            ['oauth_token' => $temporaryCredentials->getIdentifier()]
        );
    }

    /**
     * {@inheritDoc}
     */
    public function createForTokenCredentials(TemporaryCredentials $temporaryCredentials, $verificationCode)
    {
        return $this->create('POST', $this->getConfig()->getTokenCredentialsUri(), [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'headers' => [
                'Authorization' => $this->authorizationHeader->forTokenCredentials($temporaryCredentials, $verificationCode),
            ],
            'form_params' => [
                'oauth_verifier' => $verificationCode,
            ],
        ]);
    }

    /**
     * Create a new instance of Request class.
     *
     * @param  string $method
     * @param  strin $uri
     * @param  array  $options [description]
     * @return \Risan\OAuth1\Request\RequestInterface
     */
    public function create($method, $uri, array $options = [])
    {
        return new Request($method, $uri, $options);
    }
}


1		<?php
2
3		namespace Risan\OAuth1\Request;
4
5		use Risan\OAuth1\Credentials\TemporaryCredentials;
6
7		class RequestFactory implements RequestFactoryInterface
8		{
9		/**
10		* The AuthorizationHeaderInterface instance.
11		*
12		* @var \Risan\OAuth1\Request\AuthorizationHeaderInterface
13		*/
14		protected $authorizationHeader;
15
16		/**
17		* The UriParserInterface instance.
18		*
19		* @var \Risan\OAuth1\Request\UriParserInterface
20		*/
21		protected $uriParser;
22
23		/**
24		* Create the new instance of RequestFactory class.
25		*
26		* @param \Risan\OAuth1\Request\AuthorizationHeaderInterface $authorizationHeader
27		* @param \Risan\OAuth1\Request\UriParserInterface $uriParser
28		*/
29	7	public function __construct(AuthorizationHeaderInterface $authorizationHeader, UriParserInterface $uriParser)
30		{
31	7	$this->authorizationHeader = $authorizationHeader;
32	7	$this->uriParser = $uriParser;
33	7	}
34
35		/**
36		* {@inheritDoc}
37		*/
38	1	public function getAuthorizationHeader()
39		{
40	1	return $this->authorizationHeader;
41		}
42
43		/**
44		* {@inheritDoc}
45		*/
46	1	public function getConfig()
47		{
48	1	return $this->authorizationHeader->getConfig();
49		}
50
51		/**
52		* {@inheritDoc}
53		*/
54	1	public function getUriParser()
55		{
56	1	return $this->uriParser;
57		}
58
59		/**
60		* {@inheritDoc}
61		*/
62	1	public function createForTemporaryCredentials()
63		{
64	1	return $this->create('POST', $this->getConfig()->getTemporaryCredentialsUri(), [
		0 ignored issues – show Documentation introduced 2017-10-21 22:17 UTC by Report Bug Copy Issue Report `$this->getConfig()->getTemporaryCredentialsUri()` is of type `object<Psr\Http\Message\UriInterface>`, but the function expects a `object<Risan\OAuth1\Request\strin>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65		'headers' => [
66	1	'Authorization' => $this->authorizationHeader->forTemporaryCredentials(),
67		],
68		]);
69		}
70
71		/**
72		* {@inheritDoc}
73		*/
74	1	public function buildAuthorizationUri(TemporaryCredentials $temporaryCredentials)
75		{
76	1	return $this->uriParser->appendQueryParameters(
77	1	$this->getConfig()->getAuthorizationUri(),
78	1	['oauth_token' => $temporaryCredentials->getIdentifier()]
79		);
80		}
81
82		/**
83		* {@inheritDoc}
84		*/
85	1	public function createForTokenCredentials(TemporaryCredentials $temporaryCredentials, $verificationCode)
86		{
87	1	return $this->create('POST', $this->getConfig()->getTokenCredentialsUri(), [
		0 ignored issues – show Documentation introduced 2017-10-21 22:17 UTC by Report Bug Copy Issue Report `$this->getConfig()->getTokenCredentialsUri()` is of type `object<Psr\Http\Message\UriInterface>`, but the function expects a `object<Risan\OAuth1\Request\strin>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
88		'headers' => [
89	1	'Authorization' => $this->authorizationHeader->forTokenCredentials($temporaryCredentials, $verificationCode),
90		],
91		'form_params' => [
92	1	'oauth_verifier' => $verificationCode,
93		],
94		]);
95		}
96
97		/**
98		* Create a new instance of Request class.
99		*
100		* @param string $method
101		* @param strin $uri
102		* @param array $options [description]
103		* @return \Risan\OAuth1\Request\RequestInterface
104		*/
105		public function create($method, $uri, array $options = [])
106		{
107		return new Request($method, $uri, $options);
108		}
109		}
110

risan / oauth1

Push — develop ( de0fb5...78995e )

RequestFactory::buildAuthorizationUri() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like