NonceGenerator::generate() - Code Metrics - Inspection of "Merge develop branch" - risan/oauth1 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Risan Bagja

created 2017-10-14 20:06 UTC

NonceGenerator::generate() A

↳ Parent: NonceGenerator

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php

namespace Risan\OAuth1\Request;

class NonceGenerator implements NonceGeneratorInterface
{
    /**
     * {@inheritDoc}
     */
    public function generate($length = 32)
    {
        $nonce = '';

        while (($currentNonceLength = strlen($nonce)) < $length) {
            $size = $length - $currentNonceLength;
            $randomString = $this->base64EncodedRandomBytes($size);
            $nonce .= substr($this->extractAlphaNumericFromBase64EncodedString($randomString), 0, $size);
        }

        return $nonce;
    }

    /**
     * Get cryptographically secure base64 encoded random bytes.
     *
     * @param  int $length
     * @return string
     */
    public function base64EncodedRandomBytes($length)
    {
        return base64_encode(random_bytes($length));
    }

    /**
     * Extract the alphanumeric characters from base64 encoded string.
     *
     * @param  string $string
     * @return string
     */
    public function extractAlphaNumericFromBase64EncodedString($string)
    {
        return str_replace(['/', '+', '='], '', $string);
    }
}


1		<?php
2
3		namespace Risan\OAuth1\Request;
4
5		class NonceGenerator implements NonceGeneratorInterface
6		{
7		/**
8		* {@inheritDoc}
9		*/
10	1	public function generate($length = 32)
11		{
12	1	$nonce = '';
13
14	1	while (($currentNonceLength = strlen($nonce)) < $length) {
15	1	$size = $length - $currentNonceLength;
16	1	$randomString = $this->base64EncodedRandomBytes($size);
17	1	$nonce .= substr($this->extractAlphaNumericFromBase64EncodedString($randomString), 0, $size);
18		}
19
20	1	return $nonce;
21		}
22
23		/**
24		* Get cryptographically secure base64 encoded random bytes.
25		*
26		* @param int $length
27		* @return string
28		*/
29	2	public function base64EncodedRandomBytes($length)
30		{
31	2	return base64_encode(random_bytes($length));
32		}
33
34		/**
35		* Extract the alphanumeric characters from base64 encoded string.
36		*
37		* @param string $string
38		* @return string
39		*/
40	2	public function extractAlphaNumericFromBase64EncodedString($string)
41		{
42	2	return str_replace(['/', '+', '='], '', $string);
43		}
44		}
45

risan / oauth1

Pull Request — master (#3)

NonceGenerator::generate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like