Issues in ConsoleTools.php (master) - Issues in master - rinvex/laravel-support - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/ConsoleTools.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Rinvex\Support\Traits;

use Illuminate\Support\Str;

trait ConsoleTools
{
    /**
     * Publish package migrations.
     *
     * @return void
     */
    protected function publishesMigrations(string $package, bool $isModule = false): void
    {
        if (! $this->publishesResources()) {
            return;
        }

        $namespace = str_replace('laravel-', '', $package);
        $basePath = $isModule ? $this->app->path($package)
class MyClass { }

$x = new MyClass();
$x->foo = true;
            : $this->app->basePath('vendor/'.$package);

        if (file_exists($path = $basePath.'/database/migrations')) {
            $stubs = $this->app['files']->glob($path.'/*.php');
            $existing = $this->app['files']->glob($this->app->databasePath('migrations/'.$package.'/*.php'));

            $migrations = collect($stubs)->flatMap(function ($migration) use ($existing, $package) {
                $sequence = mb_substr(basename($migration), 0, 17);
                $match = collect($existing)->first(function ($item, $key) use ($migration, $sequence) {

                    return mb_strpos($item, str_replace($sequence, '', basename($migration))) !== false;
                });

                return [$migration => $this->app->databasePath('migrations/'.$package.'/'.($match ? basename($match) : date('Y_m_d_His', time() + mb_substr($sequence, -6)).str_replace($sequence, '', basename($migration))))];
            })->toArray();

            $this->publishes($migrations, $namespace.'::migrations');

        }
    }

    /**
     * Publish package config.
     *
     * @return void
     */
    protected function publishesConfig(string $package, bool $isModule = false): void
    {
        if (! $this->publishesResources()) {
            return;
        }

        $namespace = str_replace('laravel-', '', $package);
        $basePath = $isModule ? $this->app->path($package)
            : $this->app->basePath('vendor/'.$package);

        if (file_exists($path = $basePath.'/config/config.php')) {
            $this->publishes([$path => $this->app->configPath(str_replace('/', '.', $namespace).'.php')], $namespace.'::config');

        }
    }

    /**
     * Publish package views.
     *
     * @return void
     */
    protected function publishesViews(string $package, bool $isModule = false): void
    {
        if (! $this->publishesResources()) {
            return;
        }

        $namespace = str_replace('laravel-', '', $package);
        $basePath = $isModule ? $this->app->path($package)
            : $this->app->basePath('vendor/'.$package);

        if (file_exists($path = $basePath.'/resources/views')) {
            $this->publishes([$path => $this->app->resourcePath('views/vendor/'.$package)], $namespace.'::views');

        }
    }

    /**
     * Publish package lang.
     *
     * @return void
     */
    protected function publishesLang(string $package, bool $isModule = false): void
    {
        if (! $this->publishesResources()) {
            return;
        }

        $namespace = str_replace('laravel-', '', $package);
        $basePath = $isModule ? $this->app->path($package)
            : $this->app->basePath('vendor/'.$package);

        if (file_exists($path = $basePath.'/resources/lang')) {
            $this->publishes([$path => $this->app->resourcePath('lang/vendor/'.$package)], $namespace.'::lang');

        }
    }

    /**
     * Determine if the application is running in the console.
     *
     * @TODO: Implement this method to detect if we're in active dev zone or not!
     *        Ex: running inside cortex/console action
     *
     * @return bool
     */
    public function runningInDevzone()
    {
        return true;
    }

    /**
     * Register console commands.
     *
     * @param array $commands
     *
     * @return void
     */
    protected function registerCommands(array $commands): void
    {
        if (! $this->app->runningInConsole() && ! $this->runningInDevzone()) {
            return;
        }

        foreach ($commands as $key => $value) {
            $this->app->singleton($value, $key);
        }

        $this->commands(array_values($commands));

    }

    /**
     * Register models into IoC.
     *
     * @param array $models
     *
     * @return void
     */
    protected function registerModels(array $models): void
    {
        foreach ($models as $service => $class) {
            $this->app->singleton($service, $model = $this->app['config'][Str::replaceLast('.', '.models.', $service)]);
            $model === $class || $this->app->alias($service, $class);
        }
    }

    /**
     * Can publish resources.
     *
     * @return bool
     */
    protected function publishesResources(): bool
    {
        return ! $this->app->environment('production') || $this->app->runningInConsole() || $this->runningInDevzone();
    }

    /**
     * Can autoload migrations.
     *
     * @param string $module
     *
     * @return bool
     */
    protected function autoloadMigrations(string $module): bool
    {
        return $this->publishesResources() && $this->app['config'][str_replace(['laravel-', '/'], ['', '.'], $module).'.autoload_migrations'];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Support\Traits;
6
7			use Illuminate\Support\Str;
8
9			trait ConsoleTools
10			{
11			/**
12			* Publish package migrations.
13			*
14			* @return void
15			*/
16			protected function publishesMigrations(string $package, bool $isModule = false): void
17			{
18			if (! $this->publishesResources()) {
19			return;
20			}
21
22			$namespace = str_replace('laravel-', '', $package);
23			$basePath = $isModule ? $this->app->path($package)
			0 ignored issues – show Bug introduced 2019-06-03 15:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			: $this->app->basePath('vendor/'.$package);
25
26			if (file_exists($path = $basePath.'/database/migrations')) {
27			$stubs = $this->app['files']->glob($path.'/*.php');
28			$existing = $this->app['files']->glob($this->app->databasePath('migrations/'.$package.'/*.php'));
29
30			$migrations = collect($stubs)->flatMap(function ($migration) use ($existing, $package) {
31			$sequence = mb_substr(basename($migration), 0, 17);
32			$match = collect($existing)->first(function ($item, $key) use ($migration, $sequence) {
			0 ignored issues – show Unused Code introduced 2019-06-02 02:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
33			return mb_strpos($item, str_replace($sequence, '', basename($migration))) !== false;
34			});
35
36			return [$migration => $this->app->databasePath('migrations/'.$package.'/'.($match ? basename($match) : date('Y_m_d_His', time() + mb_substr($sequence, -6)).str_replace($sequence, '', basename($migration))))];
37			})->toArray();
38
39			$this->publishes($migrations, $namespace.'::migrations');
			0 ignored issues – show Bug introduced 2019-06-02 02:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `publishes()` does not exist on `Rinvex\Support\Traits\ConsoleTools`. Did you maybe mean `publishesMigrations()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
40			}
41			}
42
43			/**
44			* Publish package config.
45			*
46			* @return void
47			*/
48			protected function publishesConfig(string $package, bool $isModule = false): void
49			{
50			if (! $this->publishesResources()) {
51			return;
52			}
53
54			$namespace = str_replace('laravel-', '', $package);
55			$basePath = $isModule ? $this->app->path($package)
56			: $this->app->basePath('vendor/'.$package);
57
58			if (file_exists($path = $basePath.'/config/config.php')) {
59			$this->publishes([$path => $this->app->configPath(str_replace('/', '.', $namespace).'.php')], $namespace.'::config');
			0 ignored issues – show Bug introduced 2019-06-02 02:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `publishes()` does not exist on `Rinvex\Support\Traits\ConsoleTools`. Did you maybe mean `publishesMigrations()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
60			}
61			}
62
63			/**
64			* Publish package views.
65			*
66			* @return void
67			*/
68			protected function publishesViews(string $package, bool $isModule = false): void
69			{
70			if (! $this->publishesResources()) {
71			return;
72			}
73
74			$namespace = str_replace('laravel-', '', $package);
75			$basePath = $isModule ? $this->app->path($package)
76			: $this->app->basePath('vendor/'.$package);
77
78			if (file_exists($path = $basePath.'/resources/views')) {
79			$this->publishes([$path => $this->app->resourcePath('views/vendor/'.$package)], $namespace.'::views');
			0 ignored issues – show Bug introduced 2019-06-02 02:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `publishes()` does not exist on `Rinvex\Support\Traits\ConsoleTools`. Did you maybe mean `publishesMigrations()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
80			}
81			}
82
83			/**
84			* Publish package lang.
85			*
86			* @return void
87			*/
88			protected function publishesLang(string $package, bool $isModule = false): void
89			{
90			if (! $this->publishesResources()) {
91			return;
92			}
93
94			$namespace = str_replace('laravel-', '', $package);
95			$basePath = $isModule ? $this->app->path($package)
96			: $this->app->basePath('vendor/'.$package);
97
98			if (file_exists($path = $basePath.'/resources/lang')) {
99			$this->publishes([$path => $this->app->resourcePath('lang/vendor/'.$package)], $namespace.'::lang');
			0 ignored issues – show Bug introduced 2019-06-02 02:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `publishes()` does not exist on `Rinvex\Support\Traits\ConsoleTools`. Did you maybe mean `publishesMigrations()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
100			}
101			}
102
103			/**
104			* Determine if the application is running in the console.
105			*
106			* @TODO: Implement this method to detect if we're in active dev zone or not!
107			* Ex: running inside cortex/console action
108			*
109			* @return bool
110			*/
111			public function runningInDevzone()
112			{
113			return true;
114			}
115
116			/**
117			* Register console commands.
118			*
119			* @param array $commands
120			*
121			* @return void
122			*/
123			protected function registerCommands(array $commands): void
124			{
125			if (! $this->app->runningInConsole() && ! $this->runningInDevzone()) {
126			return;
127			}
128
129			foreach ($commands as $key => $value) {
130			$this->app->singleton($value, $key);
131			}
132
133			$this->commands(array_values($commands));
			0 ignored issues – show Bug introduced 2019-06-02 02:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `commands()` does not exist on `Rinvex\Support\Traits\ConsoleTools`. Did you maybe mean `registerCommands()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
134			}
135
136			/**
137			* Register models into IoC.
138			*
139			* @param array $models
140			*
141			* @return void
142			*/
143			protected function registerModels(array $models): void
144			{
145			foreach ($models as $service => $class) {
146			$this->app->singleton($service, $model = $this->app['config'][Str::replaceLast('.', '.models.', $service)]);
147			$model === $class \|\| $this->app->alias($service, $class);
148			}
149			}
150
151			/**
152			* Can publish resources.
153			*
154			* @return bool
155			*/
156			protected function publishesResources(): bool
157			{
158			return ! $this->app->environment('production') \|\| $this->app->runningInConsole() \|\| $this->runningInDevzone();
159			}
160
161			/**
162			* Can autoload migrations.
163			*
164			* @param string $module
165			*
166			* @return bool
167			*/
168			protected function autoloadMigrations(string $module): bool
169			{
170			return $this->publishesResources() && $this->app['config'][str_replace(['laravel-', '/'], ['', '.'], $module).'.autoload_migrations'];
171			}
172			}
173

rinvex / laravel-support

Issues (32)

Security Analysis no request data

src/Traits/ConsoleTools.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like