HashidsTrait::resolveRouteBinding() - Code Metrics - Inspection of "Add HashidsTrait" - rinvex/laravel-support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d7c603...3b0dc5 )

by Abdelrahman

created 2018-03-31 11:54 UTC

HashidsTrait::resolveRouteBinding() A

↳ Parent: HashidsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	6
rs	9.4285

<?php

declare(strict_types=1);

namespace Rinvex\Support\Traits;

use Vinkla\Hashids\Facades\Hashids;

trait HashidsTrait
{
    /**
     * Get the value of the model's route key.
     *
     * @return mixed
     */
    public function getRouteKey()
    {
        return Hashids::encode($this->getAttribute($this->getRouteKeyName()), random_int(1, 999));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Retrieve the model for a bound value.
     *
     * @param mixed $value
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    public function resolveRouteBinding($value)
    {
        $value = Hashids::decode($value)[0];

        return $this->where($this->getRouteKeyName(), $value)->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Support\Traits;
6
7			use Vinkla\Hashids\Facades\Hashids;
8
9			trait HashidsTrait
10			{
11			/**
12			* Get the value of the model's route key.
13			*
14			* @return mixed
15			*/
16			public function getRouteKey()
17			{
18			return Hashids::encode($this->getAttribute($this->getRouteKeyName()), random_int(1, 999));
			0 ignored issues – show Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report It seems like `getAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			}
20
21			/**
22			* Retrieve the model for a bound value.
23			*
24			* @param mixed $value
25			*
26			* @return \Illuminate\Database\Eloquent\Model\|null
27			*/
28			public function resolveRouteBinding($value)
29			{
30			$value = Hashids::decode($value)[0];
31
32			return $this->where($this->getRouteKeyName(), $value)->first();
			0 ignored issues – show Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			}
34			}
35

rinvex / laravel-support

Push — develop ( d7c603...3b0dc5 )

HashidsTrait::resolveRouteBinding() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like