UniqueInjector - Code Metrics - Inspection of "Override unique validation rule" - rinvex/laravel-support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 3f915e...016805 )

by Abdelrahman

created 2017-08-06 23:44 UTC

UniqueInjector A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	51
rs	10
wmc	11
lcom	1
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	prepareUniqueRule()	0	39	11

<?php

declare(strict_types=1);

namespace Rinvex\Support\Traits;

trait UniqueInjector
{
    /**
     * Prepare a unique rule, adding the table name, column and model indetifier
     * if required.
     *
     * @param array  $parameters
     * @param string $field
     *
     * @return string
     */
    protected function prepareUniqueRule($parameters, $field)
    {
        // If the table name isn't set, infer it.
        if (empty($parameters[0])) {
            $parameters[0] = $this->getModel()->getTable();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        // If the connection name isn't set but exists, infer it.
        if ((mb_strpos($parameters[0], '.') === false) && (($connectionName = $this->getModel()->getConnectionName()) !== null)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $parameters[0] = $connectionName.'.'.$parameters[0];
        }

        // If the field name isn't get, infer it.
        if (! isset($parameters[1])) {
            $parameters[1] = $field;
        }

        if ($this->exists) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            // If the identifier isn't set, infer it.
            if (! isset($parameters[2]) || mb_strtolower($parameters[2]) === 'null') {
                $parameters[2] = $this->getModel()->getKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }

            // If the primary key isn't set, infer it.
            if (! isset($parameters[3])) {
                $parameters[3] = $this->getModel()->getKeyName();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }

            // If the additional where clause isn't set, infer it.
            // Example: unique:abilities,resource,123,id,action,NULL

            foreach ($parameters as $key => $parameter) {
                if (mb_strtolower((string) $parameter) === 'null') {
                    $parameters[$key] = $this->getModel()->{$parameters[$key - 1]};
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                }
            }
        }

        return 'unique:'.implode(',', $parameters);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Support\Traits;
6
7			trait UniqueInjector
8			{
9			/**
10			* Prepare a unique rule, adding the table name, column and model indetifier
11			* if required.
12			*
13			* @param array $parameters
14			* @param string $field
15			*
16			* @return string
17			*/
18			protected function prepareUniqueRule($parameters, $field)
19			{
20			// If the table name isn't set, infer it.
21			if (empty($parameters[0])) {
22			$parameters[0] = $this->getModel()->getTable();
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report It seems like `getModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			// If the connection name isn't set but exists, infer it.
26			if ((mb_strpos($parameters[0], '.') === false) && (($connectionName = $this->getModel()->getConnectionName()) !== null)) {
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report It seems like `getModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Coding Style introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 130 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
27			$parameters[0] = $connectionName.'.'.$parameters[0];
28			}
29
30			// If the field name isn't get, infer it.
31			if (! isset($parameters[1])) {
32			$parameters[1] = $field;
33			}
34
35			if ($this->exists) {
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report The property `exists` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			// If the identifier isn't set, infer it.
37			if (! isset($parameters[2]) \|\| mb_strtolower($parameters[2]) === 'null') {
38			$parameters[2] = $this->getModel()->getKey();
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report It seems like `getModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39			}
40
41			// If the primary key isn't set, infer it.
42			if (! isset($parameters[3])) {
43			$parameters[3] = $this->getModel()->getKeyName();
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report It seems like `getModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			}
45
46			// If the additional where clause isn't set, infer it.
47			// Example: unique:abilities,resource,123,id,action,NULL
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report `47%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			foreach ($parameters as $key => $parameter) {
49			if (mb_strtolower((string) $parameter) === 'null') {
50			$parameters[$key] = $this->getModel()->{$parameters[$key - 1]};
			0 ignored issues – show Bug introduced 2017-08-06 23:45 UTC by Report Bug Copy Issue Report It seems like `getModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51			}
52			}
53			}
54
55			return 'unique:'.implode(',', $parameters);
56			}
57			}
58

rinvex / laravel-support

Push — develop ( 3f915e...016805 )

UniqueInjector A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like