HashidsTrait::getRouteKey() - Code Metrics - Inspection of "Merge branch 'release/v5.0.7'" - rinvex/laravel-support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 29a107...006b0a )

by Abdelrahman

created 2021-02-23 22:50 UTC

HashidsTrait::getRouteKey() A

↳ Parent: HashidsTrait

Complexity

Conditions	5
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	8
nop	0
dl	0
loc	8
rs	9.6111
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Rinvex\Support\Traits;

use Vinkla\Hashids\Facades\Hashids;

trait HashidsTrait
{
    /**
     * Get the value of the model's route key.
     *
     * @throws \Exception
     *
     * @return mixed
     */
    public function getRouteKey()
    {
        $obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return in_array(request()->accessarea(), $obscure['areas'])
            ? Hashids::encode($this->getAttribute($this->getKeyName()), $obscure['rotate'] ? random_int(1, 999) : 1)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            : $this->getAttribute($this->getRouteKeyName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Retrieve the model for a bound value.
     *
     * @param mixed       $value
     * @param string|null $field
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    public function resolveRouteBinding($value, $field = null)
    {
        $obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');

        return in_array(request()->accessarea(), $obscure['areas'])
            ? $this->where($field ?? $this->getKeyName(), optional(Hashids::decode($value))[0])->first()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            : $this->where($field ?? $this->getRouteKeyName(), $value)->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Unhash given value of the model.
     *
     * @param mixed $value
     *
     * @return mixed
     */
    public function unhashId($value)
    {
        $obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');

        return in_array(request()->accessarea(), $obscure['areas']) ? optional(Hashids::decode($value))[0] : $value;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Support\Traits;
6
7			use Vinkla\Hashids\Facades\Hashids;
8
9			trait HashidsTrait
10			{
11			/**
12			* Get the value of the model's route key.
13			*
14			* @throws \Exception
15			*
16			* @return mixed
17			*/
18			public function getRouteKey()
19			{
20			$obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');
			0 ignored issues – show Bug introduced 2019-12-16 14:44 UTC by Report Bug Copy Issue Report The property `obscure` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21
22			return in_array(request()->accessarea(), $obscure['areas'])
23			? Hashids::encode($this->getAttribute($this->getKeyName()), $obscure['rotate'] ? random_int(1, 999) : 1)
			0 ignored issues – show Bug introduced 2020-03-03 06:27 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2020-03-03 06:27 UTC by Report Bug Copy Issue Report It seems like `getAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			: $this->getAttribute($this->getRouteKeyName());
			0 ignored issues – show Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			}
26
27			/**
28			* Retrieve the model for a bound value.
29			*
30			* @param mixed $value
31			* @param string\|null $field
32			*
33			* @return \Illuminate\Database\Eloquent\Model\|null
34			*/
35			public function resolveRouteBinding($value, $field = null)
36			{
37			$obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');
38
39			return in_array(request()->accessarea(), $obscure['areas'])
40			? $this->where($field ?? $this->getKeyName(), optional(Hashids::decode($value))[0])->first()
			0 ignored issues – show Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			: $this->where($field ?? $this->getRouteKeyName(), $value)->first();
			0 ignored issues – show Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42			}
43
44			/**
45			* Unhash given value of the model.
46			*
47			* @param mixed $value
48			*
49			* @return mixed
50			*/
51			public function unhashId($value)
52			{
53			$obscure = property_exists($this, 'obscure') && is_array($this->obscure) ? $this->obscure : config('cortex.foundation.obscure');
54
55			return in_array(request()->accessarea(), $obscure['areas']) ? optional(Hashids::decode($value))[0] : $value;
56			}
57			}
58

rinvex / laravel-support

Push — master ( 29a107...006b0a )

HashidsTrait::getRouteKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like