HashidsTrait - Code Metrics - Inspection of "Merge branch 'release/v0.0.5'" - rinvex/laravel-support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb040e...52ef18 )

by Abdelrahman

created 2018-09-21 12:53 UTC

HashidsTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	28
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRouteKey()	0	6	2
A	resolveRouteBinding()	0	6	2

<?php

declare(strict_types=1);

namespace Rinvex\Support\Traits;

use Vinkla\Hashids\Facades\Hashids;

trait HashidsTrait
{
    /**
     * Get the value of the model's route key.
     *
     * @return mixed
     */
    public function getRouteKey()
    {
        return in_array(request()->route('accessarea'), config('cortex.foundation.obscure'))
            ? Hashids::encode($this->getAttribute($this->getKeyName()), random_int(1, 999))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            : $this->getAttribute($this->getRouteKeyName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Retrieve the model for a bound value.
     *
     * @param mixed $value
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    public function resolveRouteBinding($value)
    {
        return in_array(request()->route('accessarea'), config('cortex.foundation.obscure'))
            ? $this->where($this->getKeyName(), optional(Hashids::decode($value))[0])->first()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            : $this->where($this->getRouteKeyName(), $value)->first();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Support\Traits;
6
7			use Vinkla\Hashids\Facades\Hashids;
8
9			trait HashidsTrait
10			{
11			/**
12			* Get the value of the model's route key.
13			*
14			* @return mixed
15			*/
16			public function getRouteKey()
17			{
18			return in_array(request()->route('accessarea'), config('cortex.foundation.obscure'))
19			? Hashids::encode($this->getAttribute($this->getKeyName()), random_int(1, 999))
			0 ignored issues – show Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			: $this->getAttribute($this->getRouteKeyName());
			0 ignored issues – show Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			}
22
23			/**
24			* Retrieve the model for a bound value.
25			*
26			* @param mixed $value
27			*
28			* @return \Illuminate\Database\Eloquent\Model\|null
29			*/
30			public function resolveRouteBinding($value)
31			{
32			return in_array(request()->route('accessarea'), config('cortex.foundation.obscure'))
33			? $this->where($this->getKeyName(), optional(Hashids::decode($value))[0])->first()
			0 ignored issues – show Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-05-23 11:13 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34			: $this->where($this->getRouteKeyName(), $value)->first();
			0 ignored issues – show Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report The method `getRouteKeyName()` does not exist on `Rinvex\Support\Traits\HashidsTrait`. Did you maybe mean `getRouteKey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Bug introduced 2018-03-31 11:55 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35			}
36			}
37

rinvex / laravel-support

Push — master ( fb040e...52ef18 )

HashidsTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like