Transactionable - Code Metrics - Inspection of "Adding transactions." - rinvex/laravel-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#70)

by Ionut

created 2016-08-27 20:35 UTC

Transactionable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	78
wmc	6
lcom	0
cbo	0
rs	10

3 Methods

Rating	Name	Size	Complexity
A	create()	16	2
A	update()	16	2
A	delete()	16	2

<?php

/*
*
* NOTICE OF LICENSE
*
 * Part of the Rinvex Repository Package.
 *
 * This source file is subject to The MIT License (MIT)
* that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Repository Package
* License: The MIT License (MIT)
* Link:    https://rinvex.com
 */

namespace Rinvex\Repository\Traits;

trait Transactionable
{
    /**
     * Create a new entity with the given attributes.
     *
     * @param array $attributes
     *
     * @return array
     * @throws \Exception
     */
    public function create(array $attributes = [])
    {
        // Start transaction!
        $this->getContainer('db')->beginTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        try {
            $result = parent::create($attributes);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->getContainer('db')->rollback();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw $e;
        }
        // Commit the queries!
        $this->getContainer('db')->commit();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $result;
    }

    /**
     * Update an entity with the given attributes.
     *
     * @param mixed $id
     * @param array $attributes
     *
     * @return array
     * @throws \Exception
     */
    public function update($id, array $attributes = [])
    {
        // Start transaction!
        $this->getContainer('db')->beginTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        try {
            $result = parent::update($id, $attributes);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->getContainer('db')->rollback();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw $e;
        }
        // Commit the queries!
        $this->getContainer('db')->commit();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $result;
    }

    /**
     * Delete an entity with the given id.
     *
     * @param mixed $id
     *
     * @return array
     * @throws \Exception
     */
    public function delete($id)
    {
        // Start transaction!
        $this->getContainer('db')->beginTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        try {
            $result = parent::delete($id);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->getContainer('db')->rollback();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw $e;
        }
        // Commit the queries!
        $this->getContainer('db')->commit();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $result;
    }
}


1			<?php
2
3			/*
4			*
5			* NOTICE OF LICENSE
6			*
7			* Part of the Rinvex Repository Package.
8			*
9			* This source file is subject to The MIT License (MIT)
10			* that is bundled with this package in the LICENSE file.
11			*
12			* Package: Rinvex Repository Package
13			* License: The MIT License (MIT)
14			* Link: https://rinvex.com
15			*/
16
17			namespace Rinvex\Repository\Traits;
18
19			trait Transactionable
20			{
21			/**
22			* Create a new entity with the given attributes.
23			*
24			* @param array $attributes
25			*
26			* @return array
27			* @throws \Exception
28			*/
29			public function create(array $attributes = [])
30			{
31			// Start transaction!
32			$this->getContainer('db')->beginTransaction();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			try {
34			$result = parent::create($attributes);
35			} catch (\Exception $e) {
36			// Rollback if something went wrong
37			$this->getContainer('db')->rollback();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38			throw $e;
39			}
40			// Commit the queries!
41			$this->getContainer('db')->commit();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42
43			return $result;
44			}
45
46			/**
47			* Update an entity with the given attributes.
48			*
49			* @param mixed $id
50			* @param array $attributes
51			*
52			* @return array
53			* @throws \Exception
54			*/
55			public function update($id, array $attributes = [])
56			{
57			// Start transaction!
58			$this->getContainer('db')->beginTransaction();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
59			try {
60			$result = parent::update($id, $attributes);
61			} catch (\Exception $e) {
62			// Rollback if something went wrong
63			$this->getContainer('db')->rollback();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64			throw $e;
65			}
66			// Commit the queries!
67			$this->getContainer('db')->commit();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
68
69			return $result;
70			}
71
72			/**
73			* Delete an entity with the given id.
74			*
75			* @param mixed $id
76			*
77			* @return array
78			* @throws \Exception
79			*/
80			public function delete($id)
81			{
82			// Start transaction!
83			$this->getContainer('db')->beginTransaction();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
84			try {
85			$result = parent::delete($id);
86			} catch (\Exception $e) {
87			// Rollback if something went wrong
88			$this->getContainer('db')->rollback();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
89			throw $e;
90			}
91			// Commit the queries!
92			$this->getContainer('db')->commit();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
93
94			return $result;
95			}
96			}
97

rinvex / laravel-repositories

Pull Request — develop (#70)

Transactionable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like