Transactionable::update() - Code Metrics - Inspection of "Adding transactions." - rinvex/laravel-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#70)

by Ionut

created 2016-08-30 21:14 UTC

Transactionable::update() A

↳ Parent: Transactionable

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	9
nc	2
nop	2

<?php

/*
*
* NOTICE OF LICENSE
*
 * Part of the Rinvex Repository Package.
 *
 * This source file is subject to The MIT License (MIT)
* that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Repository Package
* License: The MIT License (MIT)
* Link:    https://rinvex.com
 */

namespace Rinvex\Repository\Traits;

trait Transactionable
{
    /**
     * Create a new entity with the given attributes.
     *
     * @param array $attributes
     *
     * @throws \Exception
     *
     * @return array
     */
    public function create(array $attributes = [])
    {
        // Start transaction!
        $this->beginTransaction();
        try {
            $result = parent::create($attributes);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->rollback();
            throw $e;
        }
        // Commit the queries!
        $this->commit();

        return $result;
    }

    /**
     * Update an entity with the given attributes.
     *
     * @param mixed $id
     * @param array $attributes
     *
     * @throws \Exception
     *
     * @return array
     */
    public function update($id, array $attributes = [])
    {
        // Start transaction!
        $this->beginTransaction();
        try {
            $result = parent::update($id, $attributes);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->rollback();
            throw $e;
        }
        // Commit the queries!
        $this->commit();

        return $result;
    }

    /**
     * Delete an entity with the given id.
     *
     * @param mixed $id
     *
     * @throws \Exception
     *
     * @return array
     */
    public function delete($id)
    {
        // Start transaction!
        $this->beginTransaction();
        try {
            $result = parent::delete($id);
        } catch (\Exception $e) {
            // Rollback if something went wrong
            $this->rollback();
            throw $e;
        }
        // Commit the queries!

        return $result;
    }

    /**
     * Start a new database transaction.
     *
     * @return void
     * @throws Exception
     */
    public function beginTransaction()
    {
        $this->getContainer('db')->beginTransaction();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Commit the active database transaction.
     *
     * @return void
     */
    public function commit()
    {
        $this->getContainer('db')->commit();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * Rollback the active database transaction.
     *
     * @return void
     */
    public function rollBack()
    {
        $this->getContainer('db')->rollback();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/*
4			*
5			* NOTICE OF LICENSE
6			*
7			* Part of the Rinvex Repository Package.
8			*
9			* This source file is subject to The MIT License (MIT)
10			* that is bundled with this package in the LICENSE file.
11			*
12			* Package: Rinvex Repository Package
13			* License: The MIT License (MIT)
14			* Link: https://rinvex.com
15			*/
16
17			namespace Rinvex\Repository\Traits;
18
19			trait Transactionable
20			{
21			/**
22			* Create a new entity with the given attributes.
23			*
24			* @param array $attributes
25			*
26			* @throws \Exception
27			*
28			* @return array
29			*/
30			public function create(array $attributes = [])
31			{
32			// Start transaction!
33			$this->beginTransaction();
34			try {
35			$result = parent::create($attributes);
36			} catch (\Exception $e) {
37			// Rollback if something went wrong
38			$this->rollback();
39			throw $e;
40			}
41			// Commit the queries!
42			$this->commit();
43
44			return $result;
45			}
46
47			/**
48			* Update an entity with the given attributes.
49			*
50			* @param mixed $id
51			* @param array $attributes
52			*
53			* @throws \Exception
54			*
55			* @return array
56			*/
57			public function update($id, array $attributes = [])
58			{
59			// Start transaction!
60			$this->beginTransaction();
61			try {
62			$result = parent::update($id, $attributes);
63			} catch (\Exception $e) {
64			// Rollback if something went wrong
65			$this->rollback();
66			throw $e;
67			}
68			// Commit the queries!
69			$this->commit();
70
71			return $result;
72			}
73
74			/**
75			* Delete an entity with the given id.
76			*
77			* @param mixed $id
78			*
79			* @throws \Exception
80			*
81			* @return array
82			*/
83			public function delete($id)
84			{
85			// Start transaction!
86			$this->beginTransaction();
87			try {
88			$result = parent::delete($id);
89			} catch (\Exception $e) {
90			// Rollback if something went wrong
91			$this->rollback();
92			throw $e;
93			}
94			// Commit the queries!
95
96			return $result;
97			}
98
99			/**
100			* Start a new database transaction.
101			*
102			* @return void
103			* @throws Exception
104			*/
105			public function beginTransaction()
106			{
107			$this->getContainer('db')->beginTransaction();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
108			}
109
110			/**
111			* Commit the active database transaction.
112			*
113			* @return void
114			*/
115			public function commit()
116			{
117			$this->getContainer('db')->commit();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
118			}
119
120
121			/**
122			* Rollback the active database transaction.
123			*
124			* @return void
125			*/
126			public function rollBack()
127			{
128			$this->getContainer('db')->rollback();
			0 ignored issues – show Bug introduced 2016-08-27 20:36 UTC by Report Bug Copy Issue Report It seems like `getContainer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
129			}
130			}
131

rinvex / laravel-repositories

Pull Request — develop (#70)

Transactionable::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like