EntityNotFoundException::__construct() - Code Metrics - Inspection of "Add new methods `findOrFail` and `findOrNew`" - rinvex/laravel-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 6c1fc8...1958ec )

by Abdelrahman

created 2016-10-09 17:13 UTC

EntityNotFoundException::__construct() A

↳ Parent: EntityNotFoundException

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	4
nc	1
nop	2

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Repository Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Repository Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Repository\Exceptions;

use RuntimeException;

class EntityNotFoundException extends RuntimeException
{
    /**
     * Id of the affected model.
     *
     * @var string
     */
    protected $id;

    /**
     * Name of the affected model.
     *
     * @var string
     */
    protected $model;

    /**
     * Set the affected model.
     *
     * @param  string $model
     * @param  int    $id
     *
     * @return void

     */
    public function __construct($model, $id)
    {
        $this->id      = $id;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->model   = $model;
        $this->message = "No results for model [{$model}] #{$id}.";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }

    /**
     * Get the affected model.
     *
     * @return string
     */
    public function getModel()
    {
        return $this->model;
    }

    /**
     * Get the affected model Id.
     *
     * @return string
     */
    public function getId()
    {
        return $this->id;
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Repository Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Repository Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Repository\Exceptions;
17
18			use RuntimeException;
19
20			class EntityNotFoundException extends RuntimeException
21			{
22			/**
23			* Id of the affected model.
24			*
25			* @var string
26			*/
27			protected $id;
28
29			/**
30			* Name of the affected model.
31			*
32			* @var string
33			*/
34			protected $model;
35
36			/**
37			* Set the affected model.
38			*
39			* @param string $model
40			* @param int $id
41			*
42			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-10-09 17:15 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
43			*/
44			public function __construct($model, $id)
45			{
46			$this->id = $id;
			0 ignored issues – show Documentation Bug introduced 2016-10-09 17:15 UTC by Report Bug Copy Issue Report The property `$id` was declared of type `string`, but `$id` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
47			$this->model = $model;
48			$this->message = "No results for model [{$model}] #{$id}.";
			2 ignored issues – show Coding Style Best Practice introduced 2016-10-09 17:15 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$model` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history... Coding Style Best Practice introduced 2016-10-09 17:15 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$id` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
49			}
50
51			/**
52			* Get the affected model.
53			*
54			* @return string
55			*/
56			public function getModel()
57			{
58			return $this->model;
59			}
60
61			/**
62			* Get the affected model Id.
63			*
64			* @return string
65			*/
66			public function getId()
67			{
68			return $this->id;
69			}
70			}
71

rinvex / laravel-repositories

Push — develop ( 6c1fc8...1958ec )

EntityNotFoundException::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like