Bindable - Code Metrics - Inspection of "Move service provider binding functionality to tra..." - rinvex/laravel-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( c05732...6c11b8 )

by Abdelrahman

created 2016-12-19 13:12 UTC

Bindable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	0
dl	0
loc	47
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	bindRepository()	0	8	4
A	prepareRepositoryAlias()	0	9	3

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Repository Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Repository Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Repository\Traits;

trait Bindable
{
    /**
     * The repository alias pattern.
     *
     * @var string
     */
    protected $repositoryAliasPattern = '{{class}}Contract';

    /**
     * Register an IoC binding whether it's already been registered or not.
     *
     * @param string               $abstract
     * @param \Closure|string|null $concrete
     * @param bool                 $shared
     * @param string|null          $alias
     * @param bool                 $force
     *
     * @return void
     */
    protected function bindRepository($abstract, $concrete = null, $shared = true, $alias = null, $force = false)
    {
        if (! $this->app->bound($abstract) || $force) {
            $concrete = $concrete ?: $abstract;
            $this->app->bind($abstract, $concrete, $shared);
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->app->alias($abstract, $this->prepareRepositoryAlias($alias, $concrete));
        }
    }

    /**
     * Prepare the repository alias.
     *
     * @param string|null $alias
     * @param mixed       $concrete
     *
     * @return string
     */
    protected function prepareRepositoryAlias($alias, $concrete)
    {
        if (! $alias && ! $concrete instanceof \Closure) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $concrete = str_replace('Repositories', 'Contracts', $concrete);
            $alias = str_replace('{{class}}', $concrete, $this->repositoryAliasPattern);
        }

        return $alias;
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Repository Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Repository Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Repository\Traits;
17
18			trait Bindable
19			{
20			/**
21			* The repository alias pattern.
22			*
23			* @var string
24			*/
25			protected $repositoryAliasPattern = '{{class}}Contract';
26
27			/**
28			* Register an IoC binding whether it's already been registered or not.
29			*
30			* @param string $abstract
31			* @param \Closure\|string\|null $concrete
32			* @param bool $shared
33			* @param string\|null $alias
34			* @param bool $force
35			*
36			* @return void
37			*/
38			protected function bindRepository($abstract, $concrete = null, $shared = true, $alias = null, $force = false)
39			{
40			if (! $this->app->bound($abstract) \|\| $force) {
41			$concrete = $concrete ?: $abstract;
42			$this->app->bind($abstract, $concrete, $shared);
			0 ignored issues – show Bug introduced 2016-12-19 13:14 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43			$this->app->alias($abstract, $this->prepareRepositoryAlias($alias, $concrete));
44			}
45			}
46
47			/**
48			* Prepare the repository alias.
49			*
50			* @param string\|null $alias
51			* @param mixed $concrete
52			*
53			* @return string
54			*/
55			protected function prepareRepositoryAlias($alias, $concrete)
56			{
57			if (! $alias && ! $concrete instanceof \Closure) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-17 16:29 UTC by Report Bug Copy Issue Report The expression `$alias` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
58			$concrete = str_replace('Repositories', 'Contracts', $concrete);
59			$alias = str_replace('{{class}}', $concrete, $this->repositoryAliasPattern);
60			}
61
62			return $alias;
63			}
64			}
65

rinvex / laravel-repositories

Push — develop ( c05732...6c11b8 )

Bindable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like