rinvex / laravel-pages

src/Providers/PagesServiceProvider.php

<?php

declare(strict_types=1);

namespace Rinvex\Pages\Providers;

use Exception;
use Rinvex\Pages\Models\Page;
use Illuminate\Routing\Router;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\Schema;
use Illuminate\Support\ServiceProvider;
use Rinvex\Support\Traits\ConsoleTools;
use Rinvex\Pages\Console\Commands\MigrateCommand;
use Rinvex\Pages\Console\Commands\PublishCommand;
use Rinvex\Pages\Console\Commands\RollbackCommand;
use Rinvex\Pages\Http\Controllers\PagesController;

class PagesServiceProvider extends ServiceProvider
{
    use ConsoleTools;

    /**
     * The commands to be registered.
     *
     * @var array
     */
    protected $commands = [
        MigrateCommand::class => 'command.rinvex.pages.migrate',
        PublishCommand::class => 'command.rinvex.pages.publish',
        RollbackCommand::class => 'command.rinvex.pages.rollback',
    ];

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register(): void
    {
        // Merge config
        $this->mergeConfigFrom(realpath(__DIR__.'/../../config/config.php'), 'rinvex.pages');

        // Bind eloquent models to IoC container
        $this->registerModels([
            'rinvex.pages.page' => Page::class,
        ]);

        // Register pageables
        $this->app->singleton('rinvex.pages.pageables', function ($app) {

The parameter $app is not used and could be removed.

            return collect();
        });

        // Register console commands
        $this->registerCommands($this->commands);
    }

    /**
     * Bootstrap the application events.
     *
     * @return void
     */
    public function boot(Router $router): void
    {
        // Load resources
        $this->loadRoutes($router);

        // Publish Resources
        $this->publishesConfig('rinvex/laravel-pages');
        $this->publishesMigrations('rinvex/laravel-pages');
        ! $this->autoloadMigrations('rinvex/laravel-pages') || $this->loadMigrationsFrom(__DIR__.'/../../database/migrations');
    }

    /**
     * Load the routes.
     *
     * @param \Illuminate\Routing\Router $router
     *
     * @return void
     */
    protected function loadRoutes(Router $router): void

The parameter $router is not used and could be removed.

    {
        try {
            // Just check if we have DB connection! This is to avoid
            // exceptions on new projects before configuring database options
            DB::connection()->getPdo();

            if (config('rinvex.pages.register_routes') && ! $this->app->routesAreCached() && Schema::hasTable(config('rinvex.pages.tables.pages'))) {

The method routesAreCached() does not seem to exist on object<Illuminate\Contracts\Foundation\Application>.

                app('rinvex.pages.page')->where('is_active', true)->get()->groupBy('domain')->each(function ($pages, $domain) {
                    Route::domain($domain ?? domain())->group(function () use ($pages) {
                        $pages->each(function ($page) {
                            Route::get($page->uri)
                                 ->name($page->route)
                                 ->uses(PagesController::class)
                                 ->middleware($page->middleware ?? ['web'])
                                 ->where('locale', '[a-z]{2}');
                        });
                    });
                });
            }
        } catch (Exception $e) {
            // Be quite! Do not do or say anything!!
        }
    }
}