ApiTokenCookieFactory::__construct() - Code Metrics - Inspection of "Merge branch 'release/v2.0.7'" - rinvex/laravel-oauth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 592d95...c00565 )

by Abdelrahman

created 2021-06-19 19:58 UTC

ApiTokenCookieFactory::__construct() A

↳ Parent: ApiTokenCookieFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Rinvex\Oauth\Factories;

use Carbon\Carbon;
use Firebase\JWT\JWT;
use Symfony\Component\HttpFoundation\Cookie;
use Illuminate\Contracts\Encryption\Encrypter;
use Illuminate\Contracts\Config\Repository as Config;

class ApiTokenCookieFactory
{
    /**
     * The configuration repository implementation.
     *
     * @var \Illuminate\Contracts\Config\Repository
     */
    protected $config;

    /**
     * The encrypter implementation.
     *
     * @var \Illuminate\Contracts\Encryption\Encrypter
     */
    protected $encrypter;

    /**
     * Create an API token cookie factory instance.
     *
     * @param \Illuminate\Contracts\Config\Repository    $config
     * @param \Illuminate\Contracts\Encryption\Encrypter $encrypter
     *
     * @return void

     */
    public function __construct(Config $config, Encrypter $encrypter)
    {
        $this->config = $config;
        $this->encrypter = $encrypter;
    }

    /**
     * Create a new API token cookie.
     *
     * @param mixed  $userId
     * @param string $csrfToken
     *
     * @return \Symfony\Component\HttpFoundation\Cookie
     */
    public function make($userId, $csrfToken)
    {
        $config = $this->config->get('session');

        $expiration = Carbon::now()->addMinutes($config['lifetime']);

        return new Cookie(
            config('rinvex.oauth.cookie'),
            $this->createToken($userId, $csrfToken, $expiration),
            $expiration,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $config['path'],
            $config['domain'],
            $config['secure'],
            true,
            false,
            $config['same_site'] ?? null
        );
    }

    /**
     * Create a new JWT token for the given user ID and CSRF token.
     *
     * @param mixed          $userId
     * @param string         $csrfToken
     * @param \Carbon\Carbon $expiration
     *
     * @return string
     */
    protected function createToken($userId, $csrfToken, Carbon $expiration)
    {
        return JWT::encode([
            'sub' => $userId,
            'csrf' => $csrfToken,
            'expiry' => $expiration->getTimestamp(),
        ], $this->encrypter->getKey());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Oauth\Factories;
6
7			use Carbon\Carbon;
8			use Firebase\JWT\JWT;
9			use Symfony\Component\HttpFoundation\Cookie;
10			use Illuminate\Contracts\Encryption\Encrypter;
11			use Illuminate\Contracts\Config\Repository as Config;
12
13			class ApiTokenCookieFactory
14			{
15			/**
16			* The configuration repository implementation.
17			*
18			* @var \Illuminate\Contracts\Config\Repository
19			*/
20			protected $config;
21
22			/**
23			* The encrypter implementation.
24			*
25			* @var \Illuminate\Contracts\Encryption\Encrypter
26			*/
27			protected $encrypter;
28
29			/**
30			* Create an API token cookie factory instance.
31			*
32			* @param \Illuminate\Contracts\Config\Repository $config
33			* @param \Illuminate\Contracts\Encryption\Encrypter $encrypter
34			*
35			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-01-18 07:09 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
36			*/
37			public function __construct(Config $config, Encrypter $encrypter)
38			{
39			$this->config = $config;
40			$this->encrypter = $encrypter;
41			}
42
43			/**
44			* Create a new API token cookie.
45			*
46			* @param mixed $userId
47			* @param string $csrfToken
48			*
49			* @return \Symfony\Component\HttpFoundation\Cookie
50			*/
51			public function make($userId, $csrfToken)
52			{
53			$config = $this->config->get('session');
54
55			$expiration = Carbon::now()->addMinutes($config['lifetime']);
56
57			return new Cookie(
58			config('rinvex.oauth.cookie'),
59			$this->createToken($userId, $csrfToken, $expiration),
60			$expiration,
			0 ignored issues – show Documentation introduced 2021-01-18 07:09 UTC by Report Bug Copy Issue Report `$expiration` is of type `object<Carbon\Carbon>`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			$config['path'],
62			$config['domain'],
63			$config['secure'],
64			true,
65			false,
66			$config['same_site'] ?? null
67			);
68			}
69
70			/**
71			* Create a new JWT token for the given user ID and CSRF token.
72			*
73			* @param mixed $userId
74			* @param string $csrfToken
75			* @param \Carbon\Carbon $expiration
76			*
77			* @return string
78			*/
79			protected function createToken($userId, $csrfToken, Carbon $expiration)
80			{
81			return JWT::encode([
82			'sub' => $userId,
83			'csrf' => $csrfToken,
84			'expiry' => $expiration->getTimestamp(),
85			], $this->encrypter->getKey());
86			}
87			}
88

rinvex / laravel-oauth

Push — master ( 592d95...c00565 )

ApiTokenCookieFactory::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like