ScopeRepository::finalizeScopes() - Code Metrics - Inspection of "Merge tag 'v2.0.7' into develop" - rinvex/laravel-oauth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 5503b1...6a0d81 )

by Abdelrahman

created 2021-06-19 19:58 UTC

ScopeRepository::finalizeScopes() A

↳ Parent: ScopeRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	4

<?php

declare(strict_types=1);

namespace Rinvex\Oauth\Repositories;

use Rinvex\Oauth\Bridge\Scope;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\ScopeRepositoryInterface;

class ScopeRepository implements ScopeRepositoryInterface
{
    /**
     * Return information about a scope.
     *
     * @param string $identifier The scope identifier
     *
     * @return \League\OAuth2\Server\Entities\ScopeEntityInterface|null

     */
    public function getScopeEntityByIdentifier($identifier)
    {
        if (app('cortex.auth.ability')->resolveRouteBinding($identifier)) {
            return new Scope($identifier);
        }
    }

    /**
     * Given a client, grant type and optional user identifier validate the set of scopes requested are valid and optionally
     * append additional scopes or remove requested scopes.
     *
     * @param \League\OAuth2\Server\Entities\ScopeEntityInterface[] $scopes
     * @param string                                                $grantType
     * @param ClientEntityInterface                                 $clientEntity
     * @param null|string                                           $userIdentifier
     *
     * @return \League\OAuth2\Server\Entities\ScopeEntityInterface[]
     */
    public function finalizeScopes(array $scopes, $grantType, ClientEntityInterface $clientEntity, $userIdentifier = null)
    {
        $abilityIds = app('cortex.auth.ability')->all()->pluck('id');

        return collect($scopes)->filter(function ($scope) use ($abilityIds) {
            return $abilityIds->contains(app('cortex.auth.ability')->unhashId($scope->getIdentifier()));
        })->all();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Oauth\Repositories;
6
7			use Rinvex\Oauth\Bridge\Scope;
8			use League\OAuth2\Server\Entities\ClientEntityInterface;
9			use League\OAuth2\Server\Repositories\ScopeRepositoryInterface;
10
11			class ScopeRepository implements ScopeRepositoryInterface
12			{
13			/**
14			* Return information about a scope.
15			*
16			* @param string $identifier The scope identifier
17			*
18			* @return \League\OAuth2\Server\Entities\ScopeEntityInterface\|null
			0 ignored issues – show Documentation introduced 2021-02-28 06:03 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `Scope\|null`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
19			*/
20			public function getScopeEntityByIdentifier($identifier)
21			{
22			if (app('cortex.auth.ability')->resolveRouteBinding($identifier)) {
23			return new Scope($identifier);
24			}
25			}
26
27			/**
28			* Given a client, grant type and optional user identifier validate the set of scopes requested are valid and optionally
29			* append additional scopes or remove requested scopes.
30			*
31			* @param \League\OAuth2\Server\Entities\ScopeEntityInterface[] $scopes
32			* @param string $grantType
33			* @param ClientEntityInterface $clientEntity
34			* @param null\|string $userIdentifier
35			*
36			* @return \League\OAuth2\Server\Entities\ScopeEntityInterface[]
37			*/
38			public function finalizeScopes(array $scopes, $grantType, ClientEntityInterface $clientEntity, $userIdentifier = null)
39			{
40			$abilityIds = app('cortex.auth.ability')->all()->pluck('id');
41
42			return collect($scopes)->filter(function ($scope) use ($abilityIds) {
43			return $abilityIds->contains(app('cortex.auth.ability')->unhashId($scope->getIdentifier()));
44			})->all();
45			}
46			}
47

rinvex / laravel-oauth

Push — develop ( 5503b1...6a0d81 )

ScopeRepository::finalizeScopes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like