CreateFormResponsesTable::jsonable() - Code Metrics - Inspection of "Merge branch 'v3.0.2'" - rinvex/laravel-forms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b08809...5efe48 )

by Abdelrahman

created 2020-03-13 18:06 UTC

CreateFormResponsesTable::jsonable() A

↳ Parent: CreateFormResponsesTable

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	3
nc	4
nop	0

<?php

declare(strict_types=1);

use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

class CreateFormResponsesTable extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create(config('rinvex.forms.tables.form_responses'), function (Blueprint $table) {
            // Columns
            $table->increments('id');
            $table->string('unique_identifier')->nullable();
            $table->{$this->jsonable()}('content');
            $table->integer('form_id')->unsigned();
            $table->nullableMorphs('user');
            $table->timestamps();
            $table->softDeletes();

            // Indexes
            $table->foreign('form_id')->references('id')->on(config('rinvex.forms.tables.forms'))
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                  ->onDelete('cascade')->onUpdate('cascade');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists(config('rinvex.forms.tables.form_responses'));
    }

    /**
     * Get jsonable column data type.
     *
     * @return string
     */
    protected function jsonable(): string
    {
        $driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);
        $dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
        $isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');

        return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			use Illuminate\Support\Facades\Schema;
6			use Illuminate\Database\Schema\Blueprint;
7			use Illuminate\Database\Migrations\Migration;
8
9			class CreateFormResponsesTable extends Migration
10			{
11			/**
12			* Run the migrations.
13			*
14			* @return void
15			*/
16			public function up()
17			{
18			Schema::create(config('rinvex.forms.tables.form_responses'), function (Blueprint $table) {
19			// Columns
20			$table->increments('id');
21			$table->string('unique_identifier')->nullable();
22			$table->{$this->jsonable()}('content');
23			$table->integer('form_id')->unsigned();
24			$table->nullableMorphs('user');
25			$table->timestamps();
26			$table->softDeletes();
27
28			// Indexes
29			$table->foreign('form_id')->references('id')->on(config('rinvex.forms.tables.forms'))
			0 ignored issues – show Bug introduced 2019-05-28 20:33 UTC by Report Bug Copy Issue Report The method `references` does only exist in `Illuminate\Database\Schema\ForeignKeyDefinition`, but not in `Illuminate\Support\Fluent`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30			->onDelete('cascade')->onUpdate('cascade');
31			});
32			}
33
34			/**
35			* Reverse the migrations.
36			*
37			* @return void
38			*/
39			public function down()
40			{
41			Schema::dropIfExists(config('rinvex.forms.tables.form_responses'));
42			}
43
44			/**
45			* Get jsonable column data type.
46			*
47			* @return string
48			*/
49			protected function jsonable(): string
50			{
51			$driverName = DB::connection()->getPdo()->getAttribute(PDO::ATTR_DRIVER_NAME);
52			$dbVersion = DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
53			$isOldVersion = version_compare($dbVersion, '5.7.8', 'lt');
54
55			return $driverName === 'mysql' && $isOldVersion ? 'text' : 'json';
56			}
57			}
58

rinvex / laravel-forms

Push — master ( b08809...5efe48 )

CreateFormResponsesTable::jsonable() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like