BookingCustomer::bookingsOfResource() - Code Metrics - Inspection of "Rewrite price calculation, relationships, booking..." - rinvex/laravel-bookings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 714b37...8cdca7 )

by Abdelrahman

created 2017-10-29 02:16 UTC

BookingCustomer::bookingsOfResource() A

↳ Parent: BookingCustomer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Rinvex\Bookings\Traits;

use Rinvex\Bookings\Models\Booking;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\MorphMany;

trait BookingCustomer
{
    use BookingScopes;

    /**
     * The customer may have many bookings.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function bookings(): MorphMany
    {
        return $this->morphMany(config('rinvex.bookings.models.booking'), 'customer');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get bookings of the given resource.
     *
     * @param \Illuminate\Database\Eloquent\Model $resource
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function bookingsOfResource(Model $resource): MorphMany
    {
        return $this->bookings()->where('resource_type', $resource->getMorphClass())->where('resource_id', $resource->getKey());

    }

    /**
     * Check if the person booked the given model.
     *
     * @param \Illuminate\Database\Eloquent\Model $resource
     *
     * @return bool
     */
    public function isBooked(Model $resource): bool
    {
        return $this->bookings()->where('resource_id', $resource->getKey())->exists();
    }

    /**
     * Book the given model at the given dates with the given price.
     *
     * @param \Illuminate\Database\Eloquent\Model $resource
     * @param string                              $startsAt
     * @param string                              $endsAt
     *
     * @return \Rinvex\Bookings\Models\Booking
     */
    public function newBooking(Model $resource, string $startsAt, string $endsAt): Booking
    {
        return $this->bookings()->create([
            'resource_id' => $resource->getKey(),
            'resource_type' => $resource->getMorphClass(),
            'customer_id' => $this->getKey(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'customer_type' => $this->getMorphClass(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'starts_at' => $startsAt,
            'ends_at' => $endsAt,
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Bookings\Traits;
6
7			use Rinvex\Bookings\Models\Booking;
8			use Illuminate\Database\Eloquent\Model;
9			use Illuminate\Database\Eloquent\Relations\MorphMany;
10
11			trait BookingCustomer
12			{
13			use BookingScopes;
14
15			/**
16			* The customer may have many bookings.
17			*
18			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
19			*/
20			public function bookings(): MorphMany
21			{
22			return $this->morphMany(config('rinvex.bookings.models.booking'), 'customer');
			0 ignored issues – show Bug introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			/**
26			* Get bookings of the given resource.
27			*
28			* @param \Illuminate\Database\Eloquent\Model $resource
29			*
30			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
31			*/
32			public function bookingsOfResource(Model $resource): MorphMany
33			{
34			return $this->bookings()->where('resource_type', $resource->getMorphClass())->where('resource_id', $resource->getKey());
			0 ignored issues – show Coding Style introduced 2017-10-29 02:20 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 128 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
35			}
36
37			/**
38			* Check if the person booked the given model.
39			*
40			* @param \Illuminate\Database\Eloquent\Model $resource
41			*
42			* @return bool
43			*/
44			public function isBooked(Model $resource): bool
45			{
46			return $this->bookings()->where('resource_id', $resource->getKey())->exists();
47			}
48
49			/**
50			* Book the given model at the given dates with the given price.
51			*
52			* @param \Illuminate\Database\Eloquent\Model $resource
53			* @param string $startsAt
54			* @param string $endsAt
55			*
56			* @return \Rinvex\Bookings\Models\Booking
57			*/
58			public function newBooking(Model $resource, string $startsAt, string $endsAt): Booking
59			{
60			return $this->bookings()->create([
61			'resource_id' => $resource->getKey(),
62			'resource_type' => $resource->getMorphClass(),
63			'customer_id' => $this->getKey(),
			0 ignored issues – show Bug introduced 2017-09-08 19:11 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64			'customer_type' => $this->getMorphClass(),
			0 ignored issues – show Bug introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report It seems like `getMorphClass()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65			'starts_at' => $startsAt,
66			'ends_at' => $endsAt,
67			]);
68			}
69			}
70

rinvex / laravel-bookings

Push — develop ( 714b37...8cdca7 )

BookingCustomer::bookingsOfResource() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like