BookingCustomer::bookingsOfBookable() - Code Metrics - Inspection of "Radical refactor for better pricing features & enf..." - rinvex/laravel-bookings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( bb8d62...714b37 )

by Abdelrahman

created 2017-10-17 15:14 UTC

BookingCustomer::bookingsOfBookable() A

↳ Parent: BookingCustomer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Rinvex\Bookings\Traits;

use Rinvex\Bookings\Models\Booking;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\MorphMany;

trait BookingCustomer
{
    use BookingScopes;

    /**
     * The customer may have many bookings.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function bookings(): MorphMany
    {
        return $this->morphMany(config('rinvex.bookings.models.booking'), 'customer');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get bookings of the given bookable.
     *
     * @param \Illuminate\Database\Eloquent\Model $bookable

     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function bookingsOfBookable(string $bookable): MorphMany
    {
        return $this->bookings()->where('bookable_type', $bookable->getMorphClass())->where('bookable_id', $bookable->getKey());
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
    }

    /**
     * Check if the person booked the given model.
     *
     * @param \Illuminate\Database\Eloquent\Model $model
     *
     * @return bool
     */
    public function isBooked(Model $model): bool
    {
        return $this->bookings()->where('bookable_id', $model->getKey())->where('bookable_type', get_class($model))->exists();

    }

    /**
     * Book the given model at the given dates with the given price.
     *
     * @param \Illuminate\Database\Eloquent\Model $bookable
     * @param string                              $starts
     * @param string                              $ends
     * @param float                               $price
     *
     * @return \Rinvex\Bookings\Models\Booking
     */
    public function newBooking(Model $bookable, string $starts, string $ends, float $price): Booking
    {
        return $this->bookings()->create([
            'bookable_id' => $bookable->getKey(),
            'bookable_type' => $bookable->getMorphClass(),
            'customer_id' => $this->getKey(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'customer_type' => $this->getMorphClass(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'starts_at' => $starts,
            'ends_at' => $ends,
            'price' => $price,
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Bookings\Traits;
6
7			use Rinvex\Bookings\Models\Booking;
8			use Illuminate\Database\Eloquent\Model;
9			use Illuminate\Database\Eloquent\Relations\MorphMany;
10
11			trait BookingCustomer
12			{
13			use BookingScopes;
14
15			/**
16			* The customer may have many bookings.
17			*
18			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
19			*/
20			public function bookings(): MorphMany
21			{
22			return $this->morphMany(config('rinvex.bookings.models.booking'), 'customer');
			0 ignored issues – show Bug introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			/**
26			* Get bookings of the given bookable.
27			*
28			* @param \Illuminate\Database\Eloquent\Model $bookable
			0 ignored issues – show Documentation introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report Should the type for parameter `$bookable` not be `string\|Model`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
29			*
30			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
31			*/
32			public function bookingsOfBookable(string $bookable): MorphMany
33			{
34			return $this->bookings()->where('bookable_type', $bookable->getMorphClass())->where('bookable_id', $bookable->getKey());
			0 ignored issues – show Bug introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report It seems like `$bookable` is not always an object, but can also be of type `string`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history... Coding Style introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 128 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
35			}
36
37			/**
38			* Check if the person booked the given model.
39			*
40			* @param \Illuminate\Database\Eloquent\Model $model
41			*
42			* @return bool
43			*/
44			public function isBooked(Model $model): bool
45			{
46			return $this->bookings()->where('bookable_id', $model->getKey())->where('bookable_type', get_class($model))->exists();
			0 ignored issues – show Coding Style introduced 2017-10-12 00:18 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
47			}
48
49			/**
50			* Book the given model at the given dates with the given price.
51			*
52			* @param \Illuminate\Database\Eloquent\Model $bookable
53			* @param string $starts
54			* @param string $ends
55			* @param float $price
56			*
57			* @return \Rinvex\Bookings\Models\Booking
58			*/
59			public function newBooking(Model $bookable, string $starts, string $ends, float $price): Booking
60			{
61			return $this->bookings()->create([
62			'bookable_id' => $bookable->getKey(),
63			'bookable_type' => $bookable->getMorphClass(),
64			'customer_id' => $this->getKey(),
			0 ignored issues – show Bug introduced 2017-09-08 19:11 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65			'customer_type' => $this->getMorphClass(),
			0 ignored issues – show Bug introduced 2017-10-17 15:23 UTC by Report Bug Copy Issue Report It seems like `getMorphClass()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66			'starts_at' => $starts,
67			'ends_at' => $ends,
68			'price' => $price,
69			]);
70			}
71			}
72

rinvex / laravel-bookings

Push — develop ( bb8d62...714b37 )

BookingCustomer::bookingsOfBookable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like