CanResetPassword::sendPasswordResetNotification() - Code Metrics - Inspection of "Use Laravel 5.3 Notifications system" - rinvex/laravel-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 453b67...10e484 )

by Abdelrahman

created 2016-08-28 11:27 UTC

CanResetPassword::sendPasswordResetNotification() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
rs	10
c	1
b	0
f	0

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Traits;

use Rinvex\Fort\Notifications\PasswordResetRequestNotification;

trait CanResetPassword
{
    /**
     * Get the email address where password reset links are sent.
     *
     * @return string
     */
    public function getEmailForPasswordReset()
    {
        return $this->email;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Send the password reset notification.
     *
     * @param array  $token
     * @param string $expiration
     *
     * @return void
     */
    public function sendPasswordResetNotification(array $token, $expiration)
    {
        $this->notify(new PasswordResetRequestNotification($token, $expiration));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Fort Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Fort Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Fort\Traits;
17
18			use Rinvex\Fort\Notifications\PasswordResetRequestNotification;
19
20			trait CanResetPassword
21			{
22			/**
23			* Get the email address where password reset links are sent.
24			*
25			* @return string
26			*/
27			public function getEmailForPasswordReset()
28			{
29			return $this->email;
			0 ignored issues – show Bug introduced 2016-08-25 14:01 UTC by Report Bug Copy Issue Report The property `email` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			}
31
32			/**
33			* Send the password reset notification.
34			*
35			* @param array $token
36			* @param string $expiration
37			*
38			* @return void
39			*/
40			public function sendPasswordResetNotification(array $token, $expiration)
41			{
42			$this->notify(new PasswordResetRequestNotification($token, $expiration));
			0 ignored issues – show Bug introduced 2016-08-28 11:39 UTC by Report Bug Copy Issue Report It seems like `notify()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44			}
45

rinvex / laravel-auth

Push — master ( 453b67...10e484 )

CanResetPassword::sendPasswordResetNotification() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like