Rinvex\Fort\Http\Controllers\Backend\RolesController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	193
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	index()	0	6	1
A	show()	0	15	2
A	bulk()	0	4	1
A	create()	0	4	1
A	copy()	0	4	1
A	edit()	0	4	1
A	form()	0	13	2
A	store()	0	5	1
A	update()	0	4	1
A	delete()	0	4	1
A	import()	0	4	1
A	export()	0	4	1

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Http\Controllers\Backend;

use Illuminate\Http\Request;
use Rinvex\Fort\Models\Role;
use Rinvex\Fort\Contracts\RoleRepositoryContract;
use Rinvex\Fort\Http\Controllers\AuthorizedController;

class RolesController extends AuthorizedController
{
    /**
     * {@inheritdoc}
     */
    protected $resourceAbilityMap = [
        'assign' => 'assign',
        'remove' => 'remove',
    ];

    /**
     * The role repository instance.
     *
     * @var \Rinvex\Fort\Contracts\RoleRepositoryContract
     */
    protected $roleRepository;

    /**
     * Create a new users controller instance.
     *
     * @param \Rinvex\Fort\Contracts\RoleRepositoryContract $roleRepository
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(RoleRepositoryContract $roleRepository)
    {
        parent::__construct();

        $this->authorizeResource(Role::class);

        $this->roleRepository = $roleRepository;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function index()
    {
        $roles = $this->roleRepository->paginate(config('rinvex.fort.backend.items_per_page'));

        return view('rinvex.fort::backend.roles.index', compact('roles'));
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function show($id)
    {
        if (! $role = $this->roleRepository->find($id)) {
            return intend([
                'intended'   => route('rinvex.fort.backend.roles.index'),
                'withErrors' => ['rinvex.fort.role.not_found' => trans('rinvex.fort::backend/messages.role.not_found', ['role' => $id])],

This line exceeds maximum limit of 120 characters; contains 137 characters

            ]);
        }

        $actions   = ['view', 'create', 'edit', 'delete', 'import', 'export'];
        $resources = app('rinvex.fort.ability')->findAll()->groupBy('resource');
        $columns   = ['resource', 'view', 'create', 'edit', 'delete', 'import', 'export', 'other'];

        return view('rinvex.fort::backend.roles.show', compact('role', 'resources', 'actions', 'columns'));
    }

    /**
     * Bulk control the given resources.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function bulk()
    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function create()
    {
        return $this->form('create', 'store');
    }

    /**
     * Show the form for copying the given resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function copy($id)
    {
        return $this->form('copy', 'store', $id);
    }

    /**
     * Show the form for editing the given resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function edit($id)
    {
        return $this->form('edit', 'update', $id);
    }

    /**
     * Show the form for create/edit/copy of the given resource.
     *
     * @param string   $mode
     * @param string   $action
     * @param int|null $id
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    protected function form($mode, $action, $id = null)
    {
        if (! $role = $this->roleRepository->getModelInstance($id)) {

The method getModelInstance does not exist on object<Rinvex\Fort\Contracts\RoleRepositoryContract>? Since you implemented __call, maybe consider adding a @method annotation.

            return intend([
                'intended'   => route('rinvex.fort.backend.roles.index'),
                'withErrors' => ['rinvex.fort.role.not_found' => trans('rinvex.fort::backend/messages.role.not_found', ['role' => $id])],

This line exceeds maximum limit of 120 characters; contains 137 characters

            ]);
        }

        $resources = app('rinvex.fort.ability')->findAll()->groupBy('resource');

        return view('rinvex.fort::backend.roles.form', compact('role', 'resources', 'mode', 'action'));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function store(Request $request)
    {
        dd($request->all());
        //
    }

    /**
     * Update the given resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Delete the given resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function delete($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Import the given resources into storage.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function import()
    {
        //
    }

    /**
     * Export the given resources from storage.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function export()
    {
        //
    }
}