AbilitiesController::update() - Code Metrics - Inspection of "Revert back HTTP & Console layers to core package!" - rinvex/laravel-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8927df...f70445 )

by Abdelrahman

created 2016-12-18 02:01 UTC

AbilitiesController::update() A

↳ Parent: AbilitiesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Http\Controllers\Backend;

use Illuminate\Http\Request;
use Rinvex\Fort\Models\Ability;
use Rinvex\Fort\Contracts\AbilityRepositoryContract;
use Rinvex\Fort\Http\Controllers\AuthorizedController;
use Rinvex\Fort\Http\Requests\Backend\AbilityStoreRequest;
use Rinvex\Fort\Http\Requests\Backend\AbilityUpdateRequest;

class AbilitiesController extends AuthorizedController
{
    /**
     * {@inheritdoc}
     */
    protected $resource = 'abilities';

    /**
     * {@inheritdoc}
     */
    protected $resourceActionWhitelist = ['grant'];


    /**
     * The ability repository instance.
     *
     * @var \Rinvex\Fort\Contracts\AbilityRepositoryContract
     */
    protected $abilityRepository;

    /**
     * Create a new abilities controller instance.
     */
    public function __construct(AbilityRepositoryContract $abilityRepository)
    {
        parent::__construct();

        $this->abilityRepository = $abilityRepository;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response

     */
    public function index()
    {
        $abilities = $this->abilityRepository->paginate(config('rinvex.fort.backend.items_per_page'));

        return view('rinvex/fort::backend/abilities.index', compact('abilities'));
    }

    /**
     * Display the specified resource.
     *
     * @param \Rinvex\Fort\Models\Ability $ability
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

     */
    public function show(Ability $ability)
    {
        return view('rinvex/fort::backend/abilities.show', compact('ability'));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

     */
    public function create()
    {
        return $this->form('create', 'store', $this->abilityRepository->createModel());
    }

    /**
     * Show the form for copying the given resource.
     *
     * @param \Rinvex\Fort\Models\Ability $ability
     *
     * @return \Illuminate\Http\Response

     */
    public function copy(Ability $ability)
    {
        return $this->form('copy', 'store', $ability);
    }

    /**
     * Show the form for editing the given resource.
     *
     * @param \Rinvex\Fort\Models\Ability $ability
     *
     * @return \Illuminate\Http\Response

     */
    public function edit(Ability $ability)
    {
        return $this->form('edit', 'update', $ability);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Rinvex\Fort\Http\Requests\Backend\AbilityStoreRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(AbilityStoreRequest $request)
    {
        return $this->process($request);
    }

    /**
     * Update the given resource in storage.
     *
     * @param \Rinvex\Fort\Http\Requests\Backend\AbilityUpdateRequest $request
     * @param \Rinvex\Fort\Models\Ability                             $ability
     *
     * @return \Illuminate\Http\Response
     */
    public function update(AbilityUpdateRequest $request, Ability $ability)
    {
        return $this->process($request, $ability);
    }

    /**
     * Delete the given resource from storage.
     *
     * @param \Rinvex\Fort\Models\Ability $ability
     *
     * @return \Illuminate\Http\Response
     */
    public function delete(Ability $ability)
    {
        $result = $this->abilityRepository->delete($ability);

        return intend([
            'route' => 'rinvex.fort.backend.abilities.index',
            'with'  => ['rinvex.fort.alert.warning' => trans('rinvex/fort::backend/messages.ability.deleted', ['abilityId' => $result->id])],

        ]);
    }

    /**
     * Import the given resources into storage.
     *
     * @return \Illuminate\Http\Response

     */
    public function import()
    {
        //
    }

    /**
     * Export the given resources from storage.
     *
     * @return \Illuminate\Http\Response

     */
    public function export()
    {
        //
    }

    /**
     * Bulk control the given resources.
     *
     * @return \Illuminate\Http\Response

     */
    public function bulk()
    {
        //
    }

    /**
     * Show the form for create/edit/copy of the given resource.
     *
     * @param string                      $mode
     * @param string                      $action
     * @param \Rinvex\Fort\Models\Ability $ability
     *
     * @return \Illuminate\Http\Response

     */
    protected function form($mode, $action, Ability $ability)
    {
        return view('rinvex/fort::backend/abilities.form', compact('ability', 'resources', 'mode', 'action'));
    }

    /**
     * Process the form for store/update of the given resource.
     *
     * @param \Illuminate\Http\Request    $request
     * @param \Rinvex\Fort\Models\Ability $ability

     *
     * @return \Illuminate\Http\Response
     */
    protected function process(Request $request, Ability $ability = null)
    {
        // Store data into the entity
        $result = $this->abilityRepository->store($ability, $request->except(['_method', '_token', 'id']));

        // Repository `store` method returns false if no attributes
        // updated, happens save button clicked without chaning anything
        $with   = ! is_null($ability)
            ?e ($result === false
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ? ['rinvex.fort.alert.warning' => trans('rinvex/fort::backend/messages.ability.nothing_updated', ['abilityId' => $ability->id])]

                : ['rinvex.fort.alert.success' => trans('rinvex/fort::backend/messages.ability.updated', ['abilityId' => $result->id])])

            : ['rinvex.fort.alert.success' => trans('rinvex/fort::backend/messages.ability.created', ['abilityId' => $result->id])];


        return intend([
            'route' => 'rinvex.fort.backend.abilities.index',
            'with'  => $with,
        ]);
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Fort Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Fort Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Fort\Http\Controllers\Backend;
17
18			use Illuminate\Http\Request;
19			use Rinvex\Fort\Models\Ability;
20			use Rinvex\Fort\Contracts\AbilityRepositoryContract;
21			use Rinvex\Fort\Http\Controllers\AuthorizedController;
22			use Rinvex\Fort\Http\Requests\Backend\AbilityStoreRequest;
23			use Rinvex\Fort\Http\Requests\Backend\AbilityUpdateRequest;
24
25			class AbilitiesController extends AuthorizedController
26			{
27			/**
28			* {@inheritdoc}
29			*/
30			protected $resource = 'abilities';
31
32			/**
33			* {@inheritdoc}
34			*/
35			protected $resourceActionWhitelist = ['grant'];
			0 ignored issues – show Comprehensibility Naming introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report The variable name `$resourceActionWhitelist` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
36
37			/**
38			* The ability repository instance.
39			*
40			* @var \Rinvex\Fort\Contracts\AbilityRepositoryContract
41			*/
42			protected $abilityRepository;
43
44			/**
45			* Create a new abilities controller instance.
46			*/
47			public function __construct(AbilityRepositoryContract $abilityRepository)
48			{
49			parent::__construct();
50
51			$this->abilityRepository = $abilityRepository;
52			}
53
54			/**
55			* Display a listing of the resource.
56			*
57			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-09-24 07:22 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
58			*/
59			public function index()
60			{
61			$abilities = $this->abilityRepository->paginate(config('rinvex.fort.backend.items_per_page'));
62
63			return view('rinvex/fort::backend/abilities.index', compact('abilities'));
64			}
65
66			/**
67			* Display the specified resource.
68			*
69			* @param \Rinvex\Fort\Models\Ability $ability
70			*
71			* @return \Illuminate\Http\Response\|\Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
			0 ignored issues – show Documentation introduced 2016-10-09 19:45 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
72			*/
73			public function show(Ability $ability)
74			{
75			return view('rinvex/fort::backend/abilities.show', compact('ability'));
76			}
77
78			/**
79			* Show the form for creating a new resource.
80			*
81			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-10-09 19:45 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
82			*/
83			public function create()
84			{
85			return $this->form('create', 'store', $this->abilityRepository->createModel());
86			}
87
88			/**
89			* Show the form for copying the given resource.
90			*
91			* @param \Rinvex\Fort\Models\Ability $ability
92			*
93			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-10-09 19:45 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
94			*/
95			public function copy(Ability $ability)
96			{
97			return $this->form('copy', 'store', $ability);
98			}
99
100			/**
101			* Show the form for editing the given resource.
102			*
103			* @param \Rinvex\Fort\Models\Ability $ability
104			*
105			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-10-09 19:45 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
106			*/
107			public function edit(Ability $ability)
108			{
109			return $this->form('edit', 'update', $ability);
110			}
111
112			/**
113			* Store a newly created resource in storage.
114			*
115			* @param \Rinvex\Fort\Http\Requests\Backend\AbilityStoreRequest $request
116			*
117			* @return \Illuminate\Http\Response
118			*/
119			public function store(AbilityStoreRequest $request)
120			{
121			return $this->process($request);
122			}
123
124			/**
125			* Update the given resource in storage.
126			*
127			* @param \Rinvex\Fort\Http\Requests\Backend\AbilityUpdateRequest $request
128			* @param \Rinvex\Fort\Models\Ability $ability
129			*
130			* @return \Illuminate\Http\Response
131			*/
132			public function update(AbilityUpdateRequest $request, Ability $ability)
133			{
134			return $this->process($request, $ability);
135			}
136
137			/**
138			* Delete the given resource from storage.
139			*
140			* @param \Rinvex\Fort\Models\Ability $ability
141			*
142			* @return \Illuminate\Http\Response
143			*/
144			public function delete(Ability $ability)
145			{
146			$result = $this->abilityRepository->delete($ability);
147
148			return intend([
149			'route' => 'rinvex.fort.backend.abilities.index',
150			'with' => ['rinvex.fort.alert.warning' => trans('rinvex/fort::backend/messages.ability.deleted', ['abilityId' => $result->id])],
			0 ignored issues – show Coding Style introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 141 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
151			]);
152			}
153
154			/**
155			* Import the given resources into storage.
156			*
157			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-09-22 16:08 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
158			*/
159			public function import()
160			{
161			//
162			}
163
164			/**
165			* Export the given resources from storage.
166			*
167			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-09-22 16:08 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
168			*/
169			public function export()
170			{
171			//
172			}
173
174			/**
175			* Bulk control the given resources.
176			*
177			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-09-22 16:08 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
178			*/
179			public function bulk()
180			{
181			//
182			}
183
184			/**
185			* Show the form for create/edit/copy of the given resource.
186			*
187			* @param string $mode
188			* @param string $action
189			* @param \Rinvex\Fort\Models\Ability $ability
190			*
191			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-10-24 15:36 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
192			*/
193			protected function form($mode, $action, Ability $ability)
194			{
195			return view('rinvex/fort::backend/abilities.form', compact('ability', 'resources', 'mode', 'action'));
196			}
197
198			/**
199			* Process the form for store/update of the given resource.
200			*
201			* @param \Illuminate\Http\Request $request
202			* @param \Rinvex\Fort\Models\Ability $ability
			0 ignored issues – show Documentation introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report Should the type for parameter `$ability` not be `null\|Ability`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
203			*
204			* @return \Illuminate\Http\Response
205			*/
206			protected function process(Request $request, Ability $ability = null)
207			{
208			// Store data into the entity
209			$result = $this->abilityRepository->store($ability, $request->except(['_method', '_token', 'id']));
210
211			// Repository `store` method returns false if no attributes
212			// updated, happens save button clicked without chaning anything
213			$with = ! is_null($ability)
214			?e ($result === false
			0 ignored issues – show Documentation introduced 2016-12-18 02:03 UTC by Report Bug Copy Issue Report `$result === false ? arra...tyId' => $result->id)))` is of type `array<string,object<Illu...ion\Translator>\|string>`, but the function expects a `object<Illuminate\Contra...upport\Htmlable>\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
215			? ['rinvex.fort.alert.warning' => trans('rinvex/fort::backend/messages.ability.nothing_updated', ['abilityId' => $ability->id])]
			0 ignored issues – show Coding Style introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 144 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
216			: ['rinvex.fort.alert.success' => trans('rinvex/fort::backend/messages.ability.updated', ['abilityId' => $result->id])])
			0 ignored issues – show Coding Style introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 136 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
217			: ['rinvex.fort.alert.success' => trans('rinvex/fort::backend/messages.ability.created', ['abilityId' => $result->id])];
			0 ignored issues – show Coding Style introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 132 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
218
219			return intend([
220			'route' => 'rinvex.fort.backend.abilities.index',
221			'with' => $with,
222			]);
223			}
224			}
225

rinvex / laravel-auth

Push — master ( 8927df...f70445 )

AbilitiesController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like