UserCreateCommand::handle() - Code Metrics - Inspection of "Revert back HTTP & Console layers to core package!" - rinvex/laravel-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8927df...f70445 )

by Abdelrahman

created 2016-12-18 02:01 UTC

UserCreateCommand::handle() B

↳ Parent: UserCreateCommand

Complexity

Conditions	6
Paths	3

Size

Total Lines	40
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	23
nc	3
nop	0
dl	0
loc	40
rs	8.439
c	0
b	0
f	0

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Lang;
use Illuminate\Contracts\Validation\Factory;

class UserCreateCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'fort:user:create
                            {email? : The email address of the user}
                            {username? : The username of the user}
                            {password? : The password of the user}
                            {firstName? : The first name of the user}
                            {middleName? : The middle name of the user}
                            {lastName? : The last name of the user}
                            {--I|inactive : Set the user as inactive}
                            {--U|unverified : Set the user as unverified}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new user.';

    /**
     * Execute the console command.
     *
     * @return void
     */
    public function handle()
    {
        $data = array_filter([

            // Required user attributes
            'email'          => $this->argument('email') ?: $this->ask(Lang::get('rinvex.fort::artisan.user.email')),
            'username'       => $this->argument('username') ?: $this->ask(Lang::get('rinvex.fort::artisan.user.username')),

            'password'       => bcrypt($this->argument('password') ?: $this->secret(Lang::get('rinvex.fort::artisan.user.password'))),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            // Optional user attributes
            'first_name'     => $this->argument('firstName'),
            'middle_name'    => $this->argument('middleName'),
            'last_name'      => $this->argument('lastName'),
            'active'         => ! $this->option('inactive'),
            'email_verified' => ! $this->option('unverified'),

        ], [
            $this,
            'filter'
        ]);

        $rules = [
            'email'    => 'required|email|max:255|unique:'.config('rinvex.fort.tables.users').',email',
            'username' => 'required|max:255|unique:'.config('rinvex.fort.tables.users').',username',
        ];

        $validator = app(Factory::class)->make($data, $rules);

        if ($validator->fails()) {
            $this->error('Errors:');

            foreach ($validator->errors()->getMessages() as $key => $messages) {
                $this->error('- '.$key.': '.$messages[0]);
            }
        } else {
            $user = $this->laravel['rinvex.fort.user']->create($data);

            $this->info(Lang::get('rinvex.fort::artisan.user.created').' ['.Lang::get('rinvex.fort::artisan.user.id').': '.$user->id.', '.Lang::get('rinvex.fort::artisan.user.email').': '.$user->email.', '.Lang::get('rinvex.fort::artisan.user.username').': '.$user->username.']');

        }
    }

    /**
     * Filter null and empty values.
     *
     * @param $value
     *
     * @return bool
     */
    protected function filter($value)
    {
        return ($value !== null && $value !== '');
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Fort Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Fort Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Fort\Console\Commands;
17
18			use Illuminate\Console\Command;
19			use Illuminate\Support\Facades\Lang;
20			use Illuminate\Contracts\Validation\Factory;
21
22			class UserCreateCommand extends Command
23			{
24			/**
25			* The name and signature of the console command.
26			*
27			* @var string
28			*/
29			protected $signature = 'fort:user:create
30			{email? : The email address of the user}
31			{username? : The username of the user}
32			{password? : The password of the user}
33			{firstName? : The first name of the user}
34			{middleName? : The middle name of the user}
35			{lastName? : The last name of the user}
36			{--I\|inactive : Set the user as inactive}
37			{--U\|unverified : Set the user as unverified}';
38
39			/**
40			* The console command description.
41			*
42			* @var string
43			*/
44			protected $description = 'Create a new user.';
45
46			/**
47			* Execute the console command.
48			*
49			* @return void
50			*/
51			public function handle()
52			{
53			$data = array_filter([
54
55			// Required user attributes
56			'email' => $this->argument('email') ?: $this->ask(Lang::get('rinvex.fort::artisan.user.email')),
57			'username' => $this->argument('username') ?: $this->ask(Lang::get('rinvex.fort::artisan.user.username')),
			0 ignored issues – show Coding Style introduced 2016-12-10 09:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
58			'password' => bcrypt($this->argument('password') ?: $this->secret(Lang::get('rinvex.fort::artisan.user.password'))),
			0 ignored issues – show Bug introduced 2016-12-10 09:53 UTC by Report Bug Copy Issue Report It seems like `$this->argument('passwor...rtisan.user.password'))` can also be of type `array`; however, `bcrypt()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Coding Style introduced 2016-12-10 09:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 134 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
59
60			// Optional user attributes
61			'first_name' => $this->argument('firstName'),
62			'middle_name' => $this->argument('middleName'),
63			'last_name' => $this->argument('lastName'),
64			'active' => ! $this->option('inactive'),
65			'email_verified' => ! $this->option('unverified'),
66
67			], [
68			$this,
69			'filter'
70			]);
71
72			$rules = [
73			'email' => 'required\|email\|max:255\|unique:'.config('rinvex.fort.tables.users').',email',
74			'username' => 'required\|max:255\|unique:'.config('rinvex.fort.tables.users').',username',
75			];
76
77			$validator = app(Factory::class)->make($data, $rules);
78
79			if ($validator->fails()) {
80			$this->error('Errors:');
81
82			foreach ($validator->errors()->getMessages() as $key => $messages) {
83			$this->error('- '.$key.': '.$messages[0]);
84			}
85			} else {
86			$user = $this->laravel['rinvex.fort.user']->create($data);
87
88			$this->info(Lang::get('rinvex.fort::artisan.user.created').' ['.Lang::get('rinvex.fort::artisan.user.id').': '.$user->id.', '.Lang::get('rinvex.fort::artisan.user.email').': '.$user->email.', '.Lang::get('rinvex.fort::artisan.user.username').': '.$user->username.']');
			0 ignored issues – show Coding Style introduced 2016-12-10 09:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 280 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
89			}
90			}
91
92			/**
93			* Filter null and empty values.
94			*
95			* @param $value
96			*
97			* @return bool
98			*/
99			protected function filter($value)
100			{
101			return ($value !== null && $value !== '');
102			}
103			}
104

rinvex / laravel-auth

Push — master ( 8927df...f70445 )

UserCreateCommand::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like