UserSessionsController::flush() - Code Metrics - Inspection of "Enforce naming conventions consistency all over th..." - rinvex/laravel-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cdb114...273f6a )

by Abdelrahman

created 2016-10-03 01:29 UTC

UserSessionsController::flush() A

↳ Parent: UserSessionsController

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	11
nc	3
nop	1
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Http\Controllers\Frontend;

use Illuminate\Support\Facades\Auth;
use Rinvex\Fort\Http\Controllers\AuthorizedController;

class UserSessionsController extends AuthorizedController
{
    /**
     * Show the account sessions.
     *
     * @return \Illuminate\Http\Response

     */
    public function index()
    {
        return view('rinvex.fort::frontend.user.sessions');
    }

    /**
     * Flush the given session.
     *
     * @param string $token

     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function flush($token = null)
    {
        $status = '';

        if ($token) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            app('rinvex.fort.persistence')->delete($token);
            $status = trans('rinvex.fort::frontend/messages.auth.session.flushed');
        } elseif (request()->get('confirm')) {
            app('rinvex.fort.persistence')->deleteByUser(Auth::guard($this->getGuard())->user()->id);
            $status = trans('rinvex.fort::frontend/messages.auth.session.flushedall');
        }

        return intend([
            'back' => true,
            'with' => ['rinvex.fort.alert.warning' => $status],
        ]);
    }
}


1			<?php
2
3			/*
4			* NOTICE OF LICENSE
5			*
6			* Part of the Rinvex Fort Package.
7			*
8			* This source file is subject to The MIT License (MIT)
9			* that is bundled with this package in the LICENSE file.
10			*
11			* Package: Rinvex Fort Package
12			* License: The MIT License (MIT)
13			* Link: https://rinvex.com
14			*/
15
16			namespace Rinvex\Fort\Http\Controllers\Frontend;
17
18			use Illuminate\Support\Facades\Auth;
19			use Rinvex\Fort\Http\Controllers\AuthorizedController;
20
21			class UserSessionsController extends AuthorizedController
22			{
23			/**
24			* Show the account sessions.
25			*
26			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-09-04 23:31 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
27			*/
28			public function index()
29			{
30			return view('rinvex.fort::frontend.user.sessions');
31			}
32
33			/**
34			* Flush the given session.
35			*
36			* @param string $token
			0 ignored issues – show Documentation introduced 2016-09-04 23:31 UTC by Report Bug Copy Issue Report Should the type for parameter `$token` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
37			*
38			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
39			*/
40			public function flush($token = null)
41			{
42			$status = '';
43
44			if ($token) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-04 23:31 UTC by Report Bug Copy Issue Report The expression `$token` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
45			app('rinvex.fort.persistence')->delete($token);
46			$status = trans('rinvex.fort::frontend/messages.auth.session.flushed');
47			} elseif (request()->get('confirm')) {
48			app('rinvex.fort.persistence')->deleteByUser(Auth::guard($this->getGuard())->user()->id);
49			$status = trans('rinvex.fort::frontend/messages.auth.session.flushedall');
50			}
51
52			return intend([
53			'back' => true,
54			'with' => ['rinvex.fort.alert.warning' => $status],
55			]);
56			}
57			}
58

rinvex / laravel-auth

Push — master ( cdb114...273f6a )

UserSessionsController::flush() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like