Rinvex\Fort\Http\Controllers\Frontend\PhoneVerificationController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	request()	0	7	1
A	send()	0	11	2
A	verify()	0	9	1
B	process()	0	34	4

<?php

/*
 * NOTICE OF LICENSE
 *
 * Part of the Rinvex Fort Package.
 *
 * This source file is subject to The MIT License (MIT)
 * that is bundled with this package in the LICENSE file.
 *
 * Package: Rinvex Fort Package
 * License: The MIT License (MIT)
 * Link:    https://rinvex.com
 */

namespace Rinvex\Fort\Http\Controllers\Frontend;

use Illuminate\Support\Facades\Auth;
use Rinvex\Fort\Guards\SessionGuard;
use Rinvex\Fort\Http\Controllers\AbstractController;
use Rinvex\Fort\Http\Requests\Frontend\PhoneVerification;
use Rinvex\Fort\Http\Requests\Frontend\PhoneVerificationRequest;

class PhoneVerificationController extends AbstractController
{
    /**
     * Show the phone verification form.
     *
     * @param \Rinvex\Fort\Http\Requests\Frontend\PhoneVerificationRequest $request
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function request(PhoneVerificationRequest $request)

The parameter $request is not used and could be removed.

    {
        // If Two-Factor authentication failed, remember Two-Factor persistence
        Auth::guard($this->getGuard())->rememberTwoFactor();

        return view('rinvex.fort::frontend.verification.phone.request');
    }

    /**
     * Process the phone verification request form.
     *
     * @param \Rinvex\Fort\Http\Requests\Frontend\PhoneVerificationRequest $request
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function send(PhoneVerificationRequest $request)
    {
        $status = app('rinvex.fort.verifier')
            ->broker($this->getBroker())
            ->sendPhoneVerification(Auth::guard($this->getGuard())->user(), $request->get('method')) ? 'sent' : 'failed';

This line exceeds maximum limit of 120 characters; contains 121 characters

        return intend([
            'intended' => route('rinvex.fort.frontend.verification.phone.verify'),
            'with'     => ['rinvex.fort.alert.success' => trans('rinvex.fort::frontend/messages.verification.phone.'.$status)],

This line exceeds maximum limit of 120 characters; contains 127 characters

        ]);
    }

    /**
     * Show the phone verification form.
     *
     * @param \Rinvex\Fort\Http\Requests\Frontend\PhoneVerification $request
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function verify(PhoneVerification $request)

The parameter $request is not used and could be removed.

    {
        // If Two-Factor authentication failed, remember Two-Factor persistence
        Auth::guard($this->getGuard())->rememberTwoFactor();

        $methods = session('rinvex.fort.twofactor.methods');

        return view('rinvex.fort::frontend.verification.phone.token', compact('methods'));
    }

    /**
     * Process the phone verification form.
     *
     * @param \Rinvex\Fort\Http\Requests\Frontend\PhoneVerification $request
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

Consider making the return type a bit more specific; maybe use \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse.

     */
    public function process(PhoneVerification $request)
    {
        $guard  = $this->getGuard();
        $token  = $request->get('token');
        $user   = Auth::guard($guard)->user();
        $result = Auth::guard($guard)->attemptTwoFactor($user, $token);

        switch ($result) {
            case SessionGuard::AUTH_PHONE_VERIFIED:
                return intend([
                    'intended' => route('rinvex.fort.frontend.user.settings'),
                    'with'     => ['rinvex.fort.alert.success' => trans($result)],
                ]);

            case SessionGuard::AUTH_LOGIN:
                Auth::guard($guard)->login($user, session('rinvex.fort.twofactor.remember'), session('rinvex.fort.twofactor.persistence'));

This line exceeds maximum limit of 120 characters; contains 139 characters

                return intend([
                    'intended' => url('/'),
                    'with'     => ['rinvex.fort.alert.success' => trans($result)],
                ]);

            case SessionGuard::AUTH_TWOFACTOR_FAILED:
            default:
                // If Two-Factor authentication failed, remember Two-Factor persistence
                Auth::guard($guard)->rememberTwoFactor();

                return intend([
                    'back'       => true,
                    'withInput'  => $request->only(['token']),
                    'withErrors' => ['token' => trans($result)],
                ]);
        }
    }
}