CanVerifyPhone::hasVerifiedPhone() - Code Metrics - Inspection of "Merge branch 'release/v1.0.2'" - rinvex/laravel-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 919615...872a11 )

by Abdelrahman

created 2018-12-22 16:48 UTC

CanVerifyPhone::hasVerifiedPhone() A

↳ Parent: CanVerifyPhone

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
cc	1
nc	1
nop	0
rs	10

<?php

declare(strict_types=1);

namespace Rinvex\Auth\Traits;

trait CanVerifyPhone
{
    /**
     * {@inheritdoc}
     */
    public function getPhoneForVerification(): ?string

    {
        return $this->phone;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * {@inheritdoc}
     */
    public function getCountryForVerification(): ?string

    {
        return $this->country_code ? country($this->country_code)->getCallingCode() : null;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * {@inheritdoc}
     */
    public function hasVerifiedPhone(): bool
    {
        return ! is_null($this->phone_verified_at);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * {@inheritdoc}
     */
    public function sendPhoneVerificationNotification(string $method, bool $force): void
    {
        ! $this->phoneVerificationNotificationClass
class MyClass { }

$x = new MyClass();
$x->foo = true;
        || $this->notify(new $this->phoneVerificationNotificationClass($method, $force));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Rinvex\Auth\Traits;
6
7			trait CanVerifyPhone
8			{
9			/**
10			* {@inheritdoc}
11			*/
12			public function getPhoneForVerification(): ?string
			0 ignored issues – show Documentation introduced 2018-01-31 14:20 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
13			{
14			return $this->phone;
			0 ignored issues – show Bug introduced 2016-10-24 15:12 UTC by Report Bug Copy Issue Report The property `phone` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			}
16
17			/**
18			* {@inheritdoc}
19			*/
20			public function getCountryForVerification(): ?string
			0 ignored issues – show Documentation introduced 2018-01-31 14:20 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
21			{
22			return $this->country_code ? country($this->country_code)->getCallingCode() : null;
			0 ignored issues – show Bug introduced 2017-06-29 03:27 UTC by Report Bug Copy Issue Report The property `country_code` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			}
24
25			/**
26			* {@inheritdoc}
27			*/
28			public function hasVerifiedPhone(): bool
29			{
30			return ! is_null($this->phone_verified_at);
			0 ignored issues – show Bug introduced 2018-12-20 21:09 UTC by Report Bug Copy Issue Report The property `phone_verified_at` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function sendPhoneVerificationNotification(string $method, bool $force): void
37			{
38			! $this->phoneVerificationNotificationClass
			0 ignored issues – show Bug introduced 2018-01-31 14:20 UTC by Report Bug Copy Issue Report The property `phoneVerificationNotificationClass` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			\|\| $this->notify(new $this->phoneVerificationNotificationClass($method, $force));
			0 ignored issues – show Bug introduced 2018-01-31 14:20 UTC by Report Bug Copy Issue Report It seems like `notify()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40			}
41			}
42

rinvex / laravel-auth

Push — master ( 919615...872a11 )

CanVerifyPhone::hasVerifiedPhone() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like