TenantsDataTable::ajax() - Code Metrics - Inspection of "Add transformers again to datatables for flexibili..." - rinvex/cortex-tenants - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 0fa276...8cee88 )

by Abdelrahman

created 2018-03-30 07:57 UTC

TenantsDataTable::ajax() A

↳ Parent: TenantsDataTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Cortex\Tenants\DataTables\Adminarea;

use Cortex\Tenants\Models\Tenant;
use Cortex\Foundation\DataTables\AbstractDataTable;
use Cortex\Tenants\Transformers\Adminarea\TenantTransformer;

class TenantsDataTable extends AbstractDataTable
{
    /**
     * {@inheritdoc}
     */
    protected $model = Tenant::class;

    /**
     * {@inheritdoc}
     */
    protected $transformer = TenantTransformer::class;

    /**
     * Get the query object to be processed by dataTables.
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|\Illuminate\Support\Collection

     */
    public function query()
    {
        $query = app($this->model)->query();

        return $this->applyScopes($query);
    }

    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return datatables($this->query())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->setTransformer($this->transformer)
            ->orderColumn('name', 'name->"$.'.app()->getLocale().'" $1')
            ->make(true);
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns(): array
    {
        $link = config('cortex.foundation.route.locale_prefix')
            ? '"<a href=\""+routes.route(\'adminarea.tenants.edit\', {tenant: full.id, locale: \''.$this->request->segment(1).'\'})+"\">"+data+"</a>"'

            : '"<a href=\""+routes.route(\'adminarea.tenants.edit\', {tenant: full.id})+"\">"+data+"</a>"';

        return [
            'name' => ['title' => trans('cortex/tenants::common.name'), 'render' => $link.'+(full.is_active ? " <i class=\"text-success fa fa-check\"></i>" : " <i class=\"text-danger fa fa-close\"></i>")', 'responsivePriority' => 0],

            'email' => ['title' => trans('cortex/tenants::common.email')],
            'phone' => ['title' => trans('cortex/tenants::common.phone')],
            'owner' => ['title' => trans('cortex/tenants::common.owner'), 'searchable' => false, 'orderable' => false],
            'country_code' => ['title' => trans('cortex/tenants::common.country')],
            'language_code' => ['title' => trans('cortex/tenants::common.language')],
            'created_at' => ['title' => trans('cortex/tenants::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

            'updated_at' => ['title' => trans('cortex/tenants::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Tenants\DataTables\Adminarea;
6
7			use Cortex\Tenants\Models\Tenant;
8			use Cortex\Foundation\DataTables\AbstractDataTable;
9			use Cortex\Tenants\Transformers\Adminarea\TenantTransformer;
10
11			class TenantsDataTable extends AbstractDataTable
12			{
13			/**
14			* {@inheritdoc}
15			*/
16			protected $model = Tenant::class;
17
18			/**
19			* {@inheritdoc}
20			*/
21			protected $transformer = TenantTransformer::class;
22
23			/**
24			* Get the query object to be processed by dataTables.
25			*
26			* @return \Illuminate\Database\Eloquent\Builder\|\Illuminate\Database\Query\Builder\|\Illuminate\Support\Collection
			0 ignored issues – show Documentation introduced 2017-09-09 19:03 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `\Illuminate\Database\Que...tabase\Eloquent\Builder`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
27			*/
28			public function query()
29			{
30			$query = app($this->model)->query();
31
32			return $this->applyScopes($query);
33			}
34
35			/**
36			* Display ajax response.
37			*
38			* @return \Illuminate\Http\JsonResponse
39			*/
40			public function ajax()
41			{
42			return datatables($this->query())
			0 ignored issues – show Bug introduced 2018-03-30 08:00 UTC by Report Bug Copy Issue Report The method `setTransformer` does only exist in `Yajra\DataTables\DataTableAbstract`, but not in `Yajra\DataTables\DataTables`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43			->setTransformer($this->transformer)
44			->orderColumn('name', 'name->"$.'.app()->getLocale().'" $1')
45			->make(true);
46			}
47
48			/**
49			* Get columns.
50			*
51			* @return array
52			*/
53			protected function getColumns(): array
54			{
55			$link = config('cortex.foundation.route.locale_prefix')
56			? '"<a href=\""+routes.route(\'adminarea.tenants.edit\', {tenant: full.id, locale: \''.$this->request->segment(1).'\'})+"\">"+data+"</a>"'
			0 ignored issues – show Coding Style introduced 2017-10-02 18:39 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 150 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
57			: '"<a href=\""+routes.route(\'adminarea.tenants.edit\', {tenant: full.id})+"\">"+data+"</a>"';
58
59			return [
60			'name' => ['title' => trans('cortex/tenants::common.name'), 'render' => $link.'+(full.is_active ? " <i class=\"text-success fa fa-check\"></i>" : " <i class=\"text-danger fa fa-close\"></i>")', 'responsivePriority' => 0],
			0 ignored issues – show Coding Style introduced 2017-10-15 18:00 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 233 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
61			'email' => ['title' => trans('cortex/tenants::common.email')],
62			'phone' => ['title' => trans('cortex/tenants::common.phone')],
63			'owner' => ['title' => trans('cortex/tenants::common.owner'), 'searchable' => false, 'orderable' => false],
64			'country_code' => ['title' => trans('cortex/tenants::common.country')],
65			'language_code' => ['title' => trans('cortex/tenants::common.language')],
66			'created_at' => ['title' => trans('cortex/tenants::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2017-09-09 19:03 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 135 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
67			'updated_at' => ['title' => trans('cortex/tenants::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2017-09-09 19:03 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 135 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
68			];
69			}
70			}
71

rinvex / cortex-tenants

Push — develop ( 0fa276...8cee88 )

TenantsDataTable::ajax() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like