PagesMediaController::delete() - Code Metrics - Inspection of "Fix FormRequest typehints" - rinvex/cortex-pages - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 5f1ffc...dd6bed )

by Abdelrahman

created 2018-01-03 15:04 UTC

PagesMediaController::delete() A

↳ Parent: PagesMediaController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	1
eloc	5
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Cortex\Pages\Http\Controllers\Adminarea;

use Spatie\MediaLibrary\Models\Media;
use Rinvex\Pages\Contracts\PageContract;
use Cortex\Foundation\DataTables\MediaDataTable;
use Cortex\Foundation\Http\Requests\ImageFormRequest;
use Cortex\Foundation\Http\Controllers\AuthorizedController;

class PagesMediaController extends AuthorizedController
{
    /**
     * {@inheritdoc}
     */
    protected $resource = 'pages';

    /**
     * {@inheritdoc}
     */
    protected $resourceAbilityMap = [
        'index' => 'list-media',
        'store' => 'create-media',
        'delete' => 'delete-media',
    ];

    /**
     * Get a listing of the resource media.
     *
     * @param \Rinvex\Pages\Contracts\PageContract $page
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function index(PageContract $page)
    {
        return request()->ajax() && request()->wantsJson()
            ? app(MediaDataTable::class)->with(['resource' => $page])->ajax()
            : intend(['url' => route('adminarea.pages.edit', ['page' => $page]).'#media-tab']);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Cortex\Foundation\Http\Requests\ImageFormRequest $request
     * @param \Rinvex\Pages\Contracts\PageContract              $page
     *
     * @return void
     */
    public function store(ImageFormRequest $request, PageContract $page)

    {
        $page->addMediaFromRequest('file')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
             ->sanitizingFileName(function($fileName) { return md5($fileName).'.'.pathinfo($fileName, PATHINFO_EXTENSION); })

             ->toMediaCollection('default', config('cortex.pages.media.disk'));
    }

    /**
     * Delete the given resource from storage.
     *
     * @param \Rinvex\Pages\Contracts\PageContract $page
     * @param \Spatie\MediaLibrary\Models\Media    $media
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function delete(PageContract $page, Media $media)
    {
        $page->media()->where('id' , $media->id)->first()->delete();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return intend([
            'url' => route('adminarea.pages.media.index', ['page' => $page]),
            'with' => ['warning' => trans('cortex/pages::messages.page.media_deleted')],
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Pages\Http\Controllers\Adminarea;
6
7			use Spatie\MediaLibrary\Models\Media;
8			use Rinvex\Pages\Contracts\PageContract;
9			use Cortex\Foundation\DataTables\MediaDataTable;
10			use Cortex\Foundation\Http\Requests\ImageFormRequest;
11			use Cortex\Foundation\Http\Controllers\AuthorizedController;
12
13			class PagesMediaController extends AuthorizedController
14			{
15			/**
16			* {@inheritdoc}
17			*/
18			protected $resource = 'pages';
19
20			/**
21			* {@inheritdoc}
22			*/
23			protected $resourceAbilityMap = [
24			'index' => 'list-media',
25			'store' => 'create-media',
26			'delete' => 'delete-media',
27			];
28
29			/**
30			* Get a listing of the resource media.
31			*
32			* @param \Rinvex\Pages\Contracts\PageContract $page
33			*
34			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
35			*/
36			public function index(PageContract $page)
37			{
38			return request()->ajax() && request()->wantsJson()
39			? app(MediaDataTable::class)->with(['resource' => $page])->ajax()
40			: intend(['url' => route('adminarea.pages.edit', ['page' => $page]).'#media-tab']);
41			}
42
43			/**
44			* Store a newly created resource in storage.
45			*
46			* @param \Cortex\Foundation\Http\Requests\ImageFormRequest $request
47			* @param \Rinvex\Pages\Contracts\PageContract $page
48			*
49			* @return void
50			*/
51			public function store(ImageFormRequest $request, PageContract $page)
			0 ignored issues – show Unused Code introduced 2018-01-03 15:23 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			{
53			$page->addMediaFromRequest('file')
			0 ignored issues – show Bug introduced 2018-01-03 15:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Rinvex\Pages\Contracts\PageContract` as the method `addMediaFromRequest()` does only exist in the following implementations of said interface: `Cortex\Pages\Models\Page`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54			->sanitizingFileName(function($fileName) { return md5($fileName).'.'.pathinfo($fileName, PATHINFO_EXTENSION); })
			0 ignored issues – show Coding Style introduced 2018-01-03 15:23 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 125 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
55			->toMediaCollection('default', config('cortex.pages.media.disk'));
56			}
57
58			/**
59			* Delete the given resource from storage.
60			*
61			* @param \Rinvex\Pages\Contracts\PageContract $page
62			* @param \Spatie\MediaLibrary\Models\Media $media
63			*
64			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
65			*/
66			public function delete(PageContract $page, Media $media)
67			{
68			$page->media()->where('id' , $media->id)->first()->delete();
			0 ignored issues – show Bug introduced 2018-01-03 15:23 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Rinvex\Pages\Contracts\PageContract` as the method `media()` does only exist in the following implementations of said interface: `Cortex\Pages\Models\Page`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69
70			return intend([
71			'url' => route('adminarea.pages.media.index', ['page' => $page]),
72			'with' => ['warning' => trans('cortex/pages::messages.page.media_deleted')],
73			]);
74			}
75			}
76

rinvex / cortex-pages

Push — develop ( 5f1ffc...dd6bed )

PagesMediaController::delete() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like