MigrateMakeCommand::makeDirectory() - Code Metrics - Inspection of "Clean make:module command and add optional command..." - rinvex/cortex-foundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 500347...42c100 )

by Abdelrahman

created 2017-09-12 13:42 UTC

MigrateMakeCommand::makeDirectory() A

↳ Parent: MigrateMakeCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Cortex\Foundation\Console\Commands;

use Illuminate\Database\Console\Migrations\MigrateMakeCommand as BaseMigrateMakeCommand;

class MigrateMakeCommand extends BaseMigrateMakeCommand
{
    /**
     * The console command signature.
     *
     * @var string
     */
    protected $signature = 'make:migration {name : The name of the migration.}
        {--module= : The name of the module.}
        {--create= : The table to be created.}
        {--table= : The table to migrate.}
        {--path= : The location where the migration file should be created.}';

    /**
     * Write the migration file to disk.
     *
     * @param  string  $name
     * @param  string  $table
     * @param  bool    $create
     * @return string

     */
    protected function writeMigration($name, $table, $create)
    {
        $this->makeDirectory($this->getMigrationPath());

        parent::writeMigration($name, $table, $create);
    }

    /**
     * Build the directory for the class if necessary.
     *
     * @param  string  $path
     * @return string
     */
    protected function makeDirectory($path)
    {
        if (! $this->laravel['files']->isDirectory($path)) {
            $this->laravel['files']->makeDirectory($path, 0777, true, true);
        }

        return $path;
    }

    /**
     * Get migration path (either specified by '--path' or '--module' options).
     *
     * @return string
     */
    protected function getMigrationPath()
    {
        if (! is_null($targetPath = $this->input->getOption('path'))) {
            return $this->laravel->basePath().'/'.$targetPath;
        }

        if (! is_null($module = $this->input->getOption('module')) && $this->laravel->files->exists($modulePath = $this->laravel->path().DIRECTORY_SEPARATOR.$module)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return $modulePath.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'migrations';
        }

        return $this->laravel->databasePath().DIRECTORY_SEPARATOR.'migrations';

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Foundation\Console\Commands;
6
7			use Illuminate\Database\Console\Migrations\MigrateMakeCommand as BaseMigrateMakeCommand;
8
9			class MigrateMakeCommand extends BaseMigrateMakeCommand
10			{
11			/**
12			* The console command signature.
13			*
14			* @var string
15			*/
16			protected $signature = 'make:migration {name : The name of the migration.}
17			{--module= : The name of the module.}
18			{--create= : The table to be created.}
19			{--table= : The table to migrate.}
20			{--path= : The location where the migration file should be created.}';
21
22			/**
23			* Write the migration file to disk.
24			*
25			* @param string $name
26			* @param string $table
27			* @param bool $create
28			* @return string
			0 ignored issues – show Documentation introduced 2017-09-12 13:44 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
29			*/
30			protected function writeMigration($name, $table, $create)
31			{
32			$this->makeDirectory($this->getMigrationPath());
33
34			parent::writeMigration($name, $table, $create);
35			}
36
37			/**
38			* Build the directory for the class if necessary.
39			*
40			* @param string $path
41			* @return string
42			*/
43			protected function makeDirectory($path)
44			{
45			if (! $this->laravel['files']->isDirectory($path)) {
46			$this->laravel['files']->makeDirectory($path, 0777, true, true);
47			}
48
49			return $path;
50			}
51
52			/**
53			* Get migration path (either specified by '--path' or '--module' options).
54			*
55			* @return string
56			*/
57			protected function getMigrationPath()
58			{
59			if (! is_null($targetPath = $this->input->getOption('path'))) {
60			return $this->laravel->basePath().'/'.$targetPath;
61			}
62
63			if (! is_null($module = $this->input->getOption('module')) && $this->laravel->files->exists($modulePath = $this->laravel->path().DIRECTORY_SEPARATOR.$module)) {
			0 ignored issues – show Bug introduced 2017-09-07 11:02 UTC by Report Bug Copy Issue Report Accessing `files` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Coding Style introduced 2017-09-07 11:02 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 168 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
64			return $modulePath.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'migrations';
65			}
66
67			return $this->laravel->databasePath().DIRECTORY_SEPARATOR.'migrations';
			0 ignored issues – show Bug introduced 2017-09-07 11:02 UTC by Report Bug Copy Issue Report The method `databasePath()` does not exist on `Illuminate\Contracts\Foundation\Application`. Did you maybe mean `basePath()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
68			}
69			}
70

rinvex / cortex-foundation

Push — develop ( 500347...42c100 )

MigrateMakeCommand::makeDirectory() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like