MediaDataTable::ajax() - Code Metrics - Inspection of "Add auditability functionality to models" - rinvex/cortex-foundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( cbad9d...de1065 )

by Abdelrahman

created 2018-01-31 14:13 UTC

MediaDataTable::ajax() A

↳ Parent: MediaDataTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Cortex\Foundation\DataTables;

use Spatie\MediaLibrary\Models\Media;
use Cortex\Foundation\Transformers\MediaTransformer;

class MediaDataTable extends AbstractDataTable
{
    /**
     * {@inheritdoc}
     */
    protected $model = Media::class;

    /**
     * {@inheritdoc}
     */
    protected $createButton = false;

    /**
     * {@inheritdoc}
     */
    protected $builderParameters = [
        'initComplete' => 'function (settings) {
            implicitForms.initialize();
        }',
    ];

    /**
     * {@inheritdoc}
     */
    protected $transformer = MediaTransformer::class;

    /**
     * Get the query object to be processed by dataTables.
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|\Illuminate\Support\Collection

     */
    public function query()
    {
        $query = $this->resource->media()->orderBy('order_column', 'ASC');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this->applyScopes($query);
    }

    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return datatables($this->query())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->setTransformer($this->transformer)
            ->make(true);
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns(): array
    {
        return [
            'name' => ['title' => trans('cortex/foundation::common.name'), 'responsivePriority' => 0],
            'file_name' => ['title' => trans('cortex/foundation::common.file_name')],
            'mime_type' => ['title' => trans('cortex/foundation::common.mime_type')],
            'size' => ['title' => trans('cortex/foundation::common.size')],
            'created_at' => ['title' => trans('cortex/foundation::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

            'updated_at' => ['title' => trans('cortex/foundation::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

            'delete' => ['title' => trans('cortex/foundation::common.delete'), 'orderable' => false, 'searchable' => false, 'render' => '"<a href=\"#\" data-toggle=\"modal\" data-target=\"#delete-confirmation\" data-modal-action=\""+data+"\" data-modal-title=\"'.trans('cortex/foundation::messages.delete_confirmation_title').'\" data-modal-body=\"" + Lang.trans(\'cortex/foundation::messages.delete_confirmation_body\', {type: \'media\', name: full.name}) + "\" title=\"'.trans('cortex/foundation::common.delete').'\"><i class=\"fa fa-trash text-danger\"></i></a>"'],

        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Foundation\DataTables;
6
7			use Spatie\MediaLibrary\Models\Media;
8			use Cortex\Foundation\Transformers\MediaTransformer;
9
10			class MediaDataTable extends AbstractDataTable
11			{
12			/**
13			* {@inheritdoc}
14			*/
15			protected $model = Media::class;
16
17			/**
18			* {@inheritdoc}
19			*/
20			protected $createButton = false;
21
22			/**
23			* {@inheritdoc}
24			*/
25			protected $builderParameters = [
26			'initComplete' => 'function (settings) {
27			implicitForms.initialize();
28			}',
29			];
30
31			/**
32			* {@inheritdoc}
33			*/
34			protected $transformer = MediaTransformer::class;
35
36			/**
37			* Get the query object to be processed by dataTables.
38			*
39			* @return \Illuminate\Database\Eloquent\Builder\|\Illuminate\Database\Query\Builder\|\Illuminate\Support\Collection
			0 ignored issues – show Documentation introduced 2018-01-03 15:33 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `\Illuminate\Database\Que...tabase\Eloquent\Builder`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
40			*/
41			public function query()
42			{
43			$query = $this->resource->media()->orderBy('order_column', 'ASC');
			0 ignored issues – show Documentation introduced 2018-01-03 15:33 UTC by Report Bug Copy Issue Report The property `resource` does not exist on `object<Cortex\Foundation...aTables\MediaDataTable>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44
45			return $this->applyScopes($query);
46			}
47
48			/**
49			* Display ajax response.
50			*
51			* @return \Illuminate\Http\JsonResponse
52			*/
53			public function ajax()
54			{
55			return datatables($this->query())
			0 ignored issues – show Bug introduced 2018-01-31 14:26 UTC by Report Bug Copy Issue Report The method `setTransformer` does only exist in `Yajra\DataTables\DataTableAbstract`, but not in `Yajra\DataTables\DataTables`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
56			->setTransformer($this->transformer)
57			->make(true);
58			}
59
60			/**
61			* Get columns.
62			*
63			* @return array
64			*/
65			protected function getColumns(): array
66			{
67			return [
68			'name' => ['title' => trans('cortex/foundation::common.name'), 'responsivePriority' => 0],
69			'file_name' => ['title' => trans('cortex/foundation::common.file_name')],
70			'mime_type' => ['title' => trans('cortex/foundation::common.mime_type')],
71			'size' => ['title' => trans('cortex/foundation::common.size')],
72			'created_at' => ['title' => trans('cortex/foundation::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2018-01-03 15:33 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 138 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
73			'updated_at' => ['title' => trans('cortex/foundation::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2018-01-03 15:33 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 138 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
74			'delete' => ['title' => trans('cortex/foundation::common.delete'), 'orderable' => false, 'searchable' => false, 'render' => '"<a href=\"#\" data-toggle=\"modal\" data-target=\"#delete-confirmation\" data-modal-action=\""+data+"\" data-modal-title=\"'.trans('cortex/foundation::messages.delete_confirmation_title').'\" data-modal-body=\"" + Lang.trans(\'cortex/foundation::messages.delete_confirmation_body\', {type: \'media\', name: full.name}) + "\" title=\"'.trans('cortex/foundation::common.delete').'\"><i class=\"fa fa-trash text-danger\"></i></a>"'],
			0 ignored issues – show Coding Style introduced 2018-01-15 18:00 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 568 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
75			];
76			}
77			}
78

rinvex / cortex-foundation

Push — develop ( cbad9d...de1065 )

MediaDataTable::ajax() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like