ContactsDataTable::ajax() - Code Metrics - Inspection of "Add country column searchability" - rinvex/cortex-contacts - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( de5894...783f37 )

by Abdelrahman

created 2018-03-31 12:01 UTC

ContactsDataTable::ajax() A

↳ Parent: ContactsDataTable

Complexity

Conditions	3
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	3
eloc	8
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Cortex\Contacts\DataTables\Adminarea;

use Cortex\Contacts\Models\Contact;
use Illuminate\Database\Eloquent\Builder;
use Cortex\Foundation\DataTables\AbstractDataTable;
use Cortex\Contacts\Transformers\Adminarea\ContactTransformer;

class ContactsDataTable extends AbstractDataTable
{
    /**
     * {@inheritdoc}
     */
    protected $model = Contact::class;

    /**
     * {@inheritdoc}
     */
    protected $transformer = ContactTransformer::class;

    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return datatables($this->query())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->setTransformer($this->transformer)
            ->filterColumn('country_code', function (Builder $builder, $keyword) {
                $countryCode = collect(countries())->search(function($country) use ($keyword) {
                    return mb_strpos($country['name'], $keyword) !== false || mb_strpos($country['emoji'], $keyword) !== false;

                });

                ! $countryCode || $builder->where('country_code', $countryCode);
            })
            ->make(true);
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns(): array
    {
        $link = config('cortex.foundation.route.locale_prefix')
            ? '"<a href=\""+routes.route(\'adminarea.contacts.edit\', {contact: full.id, locale: \''.$this->request->segment(1).'\'})+"\">"+data+"</a>"'

            : '"<a href=\""+routes.route(\'adminarea.contacts.edit\', {contact: full.id})+"\">"+data+"</a>"';

        return [
            'full_name' => ['title' => trans('cortex/contacts::common.full_name'), 'render' => $link, 'responsivePriority' => 0],

            'email' => ['title' => trans('cortex/contacts::common.email')],
            'phone' => ['title' => trans('cortex/contacts::common.phone')],
            'country_code' => ['title' => trans('cortex/contacts::common.country')],
            'language_code' => ['title' => trans('cortex/contacts::common.language'), 'visible' => false],
            'source' => ['title' => trans('cortex/contacts::common.source'), 'visible' => false],
            'method' => ['title' => trans('cortex/contacts::common.method'), 'visible' => false],
            'created_at' => ['title' => trans('cortex/contacts::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

            'updated_at' => ['title' => trans('cortex/contacts::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],

        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Contacts\DataTables\Adminarea;
6
7			use Cortex\Contacts\Models\Contact;
8			use Illuminate\Database\Eloquent\Builder;
9			use Cortex\Foundation\DataTables\AbstractDataTable;
10			use Cortex\Contacts\Transformers\Adminarea\ContactTransformer;
11
12			class ContactsDataTable extends AbstractDataTable
13			{
14			/**
15			* {@inheritdoc}
16			*/
17			protected $model = Contact::class;
18
19			/**
20			* {@inheritdoc}
21			*/
22			protected $transformer = ContactTransformer::class;
23
24			/**
25			* Display ajax response.
26			*
27			* @return \Illuminate\Http\JsonResponse
28			*/
29			public function ajax()
30			{
31			return datatables($this->query())
			0 ignored issues – show Bug introduced 2018-03-31 12:02 UTC by Report Bug Copy Issue Report The method `setTransformer` does only exist in `Yajra\DataTables\DataTableAbstract`, but not in `Yajra\DataTables\DataTables`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			->setTransformer($this->transformer)
33			->filterColumn('country_code', function (Builder $builder, $keyword) {
34			$countryCode = collect(countries())->search(function($country) use ($keyword) {
35			return mb_strpos($country['name'], $keyword) !== false \|\| mb_strpos($country['emoji'], $keyword) !== false;
			0 ignored issues – show Coding Style introduced 2018-03-31 12:02 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
36			});
37
38			! $countryCode \|\| $builder->where('country_code', $countryCode);
39			})
40			->make(true);
41			}
42
43			/**
44			* Get columns.
45			*
46			* @return array
47			*/
48			protected function getColumns(): array
49			{
50			$link = config('cortex.foundation.route.locale_prefix')
51			? '"<a href=\""+routes.route(\'adminarea.contacts.edit\', {contact: full.id, locale: \''.$this->request->segment(1).'\'})+"\">"+data+"</a>"'
			0 ignored issues – show Coding Style introduced 2017-10-02 18:35 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 152 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
52			: '"<a href=\""+routes.route(\'adminarea.contacts.edit\', {contact: full.id})+"\">"+data+"</a>"';
53
54			return [
55			'full_name' => ['title' => trans('cortex/contacts::common.full_name'), 'render' => $link, 'responsivePriority' => 0],
			0 ignored issues – show Coding Style introduced 2017-10-02 18:35 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 129 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
56			'email' => ['title' => trans('cortex/contacts::common.email')],
57			'phone' => ['title' => trans('cortex/contacts::common.phone')],
58			'country_code' => ['title' => trans('cortex/contacts::common.country')],
59			'language_code' => ['title' => trans('cortex/contacts::common.language'), 'visible' => false],
60			'source' => ['title' => trans('cortex/contacts::common.source'), 'visible' => false],
61			'method' => ['title' => trans('cortex/contacts::common.method'), 'visible' => false],
62			'created_at' => ['title' => trans('cortex/contacts::common.created_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2017-09-07 09:57 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 136 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
63			'updated_at' => ['title' => trans('cortex/contacts::common.updated_at'), 'render' => "moment(data).format('MMM Do, YYYY')"],
			0 ignored issues – show Coding Style introduced 2017-09-07 09:57 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 136 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
64			];
65			}
66			}
67

rinvex / cortex-contacts

Push — develop ( de5894...783f37 )

ContactsDataTable::ajax() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like