ContactsController::create() - Code Metrics - Inspection of "Tweak and simplify FormRequest validations" - rinvex/cortex-contacts - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a9345e...8ee936 )

by Abdelrahman

created 2019-01-03 05:57 UTC

ContactsController::create() A

↳ Parent: ContactsController::form()

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
cc	1
nc	1
nop	1
rs	10

<?php

declare(strict_types=1);

namespace Cortex\Contacts\Http\Controllers\Adminarea;

use Exception;
use Cortex\Contacts\Models\Contact;
use Illuminate\Foundation\Http\FormRequest;
use Cortex\Foundation\DataTables\LogsDataTable;
use Cortex\Foundation\Importers\DefaultImporter;
use Cortex\Foundation\DataTables\ImportLogsDataTable;
use Cortex\Foundation\Http\Requests\ImportFormRequest;
use Cortex\Foundation\DataTables\ImportRecordsDataTable;
use Cortex\Contacts\DataTables\Adminarea\ContactsDataTable;
use Cortex\Foundation\Http\Controllers\AuthorizedController;
use Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest;

class ContactsController extends AuthorizedController
{
    /**
     * {@inheritdoc}
     */
    protected $resource = Contact::class;

    /**
     * List all contacts.
     *
     * @param \Cortex\Contacts\DataTables\Adminarea\ContactsDataTable $contactsDataTable
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(ContactsDataTable $contactsDataTable)
    {
        return $contactsDataTable->with([
            'id' => 'adminarea-contacts-index-table',
        ])->render('cortex/foundation::adminarea.pages.datatable-index');
    }

    /**
     * List contact logs.
     *
     * @param \Cortex\Contacts\Models\Contact             $contact
     * @param \Cortex\Foundation\DataTables\LogsDataTable $logsDataTable
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

     */
    public function logs(Contact $contact, LogsDataTable $logsDataTable)
    {
        return $logsDataTable->with([
            'resource' => $contact,
            'tabs' => 'adminarea.contacts.tabs',
            'id' => "adminarea-contacts-{$contact->getRouteKey()}-logs-table",
        ])->render('cortex/foundation::adminarea.pages.datatable-tab');
    }

    /**
     * Import contacts.
     *
     * @param \Cortex\Contacts\Models\Contact                      $contact
     * @param \Cortex\Foundation\DataTables\ImportRecordsDataTable $importRecordsDataTable
     *
     * @return \Illuminate\View\View
     */
    public function import(Contact $contact, ImportRecordsDataTable $importRecordsDataTable)

    {
        return $importRecordsDataTable->with([
            'resource' => $contact,
            'tabs' => 'adminarea.contacts.tabs',
            'url' => route('adminarea.contacts.stash'),
            'id' => "adminarea-contacts-{$contact->getRouteKey()}-import-table",
        ])->render('cortex/foundation::adminarea.pages.datatable-dropzone');
    }

    /**
     * Stash contacts.
     *
     * @param \Cortex\Foundation\Http\Requests\ImportFormRequest $request
     * @param \Cortex\Foundation\Importers\DefaultImporter       $importer
     *
     * @return void
     */
    public function stash(ImportFormRequest $request, Contact $contact, DefaultImporter $importer)

    {
        // Handle the import
        $importer->config['resource'] = $contact;
        $importer->handleImport();
    }

    /**
     * Hoard contacts.
     *
     * @param \Cortex\Foundation\Http\Requests\ImportFormRequest $request
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function hoard(ImportFormRequest $request)
    {
        foreach ((array) $request->get('selected_ids') as $recordId) {
            $record = app('cortex.foundation.import_record')->find($recordId);

            try {
                $fillable = collect($record['data'])->intersectByKeys(array_flip(app('rinvex.contacts.contact')->getFillable()))->toArray();


                tap(app('rinvex.contacts.contact')->firstOrNew($fillable), function ($instance) use ($record) {
                    $instance->save() && $record->delete();
                });
            } catch (Exception $exception) {
                $record->notes = $exception->getMessage().(method_exists($exception, 'getMessageBag') ? "\n".json_encode($exception->getMessageBag())."\n\n" : '');

                $record->status = 'fail';
                $record->save();
            }
        }

        return intend([
            'back' => true,
            'with' => ['success' => trans('cortex/foundation::messages.import_complete')],
        ]);
    }

    /**
     * List contact import logs.
     *
     * @param \Cortex\Foundation\DataTables\ImportLogsDataTable $importLogsDatatable
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse

     */
    public function importLogs(ImportLogsDataTable $importLogsDatatable)
    {
        return $importLogsDatatable->with([
            'resource' => trans('cortex/contacts::common.contact'),
            'tabs' => 'adminarea.contacts.tabs',
            'id' => 'adminarea-contacts-import-logs-table',
        ])->render('cortex/foundation::adminarea.pages.datatable-tab');
    }

    /**
     * Show contact create/edit form.
     *
     * @param \Cortex\Contacts\Models\Contact $contact
     *
     * @return \Illuminate\View\View
     */
    protected function form(Contact $contact)
    {
        $countries = collect(countries())->map(function ($country, $code) {
            return [
                'id' => $code,
                'text' => $country['name'],
                'emoji' => $country['emoji'],
            ];
        })->values();

        $tags = app('rinvex.tags.tag')->pluck('name', 'id');
        $languages = collect(languages())->pluck('name', 'iso_639_1');
        $sources = app('rinvex.contacts.contact')->distinct()->get(['source'])->pluck('source', 'source')->toArray();
        $methods = app('rinvex.contacts.contact')->distinct()->get(['method'])->pluck('method', 'method')->toArray();
        $genders = ['male' => trans('cortex/contacts::common.male'), 'female' => trans('cortex/contacts::common.female')];


        return view('cortex/contacts::adminarea.pages.contact', compact('contact', 'genders', 'countries', 'languages', 'sources', 'methods', 'tags'));

    }

    /**
     * Store new contact.
     *
     * @param \Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest $request
     * @param \Cortex\Contacts\Models\Contact                             $contact
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function store(ContactFormRequest $request, Contact $contact)
    {
        return $this->process($request, $contact);
    }

    /**
     * Update given contact.
     *
     * @param \Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest $request
     * @param \Cortex\Contacts\Models\Contact                             $contact
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function update(ContactFormRequest $request, Contact $contact)
    {
        return $this->process($request, $contact);
    }

    /**
     * Process stored/updated contact.
     *
     * @param \Illuminate\Foundation\Http\FormRequest $request
     * @param \Cortex\Contacts\Models\Contact         $contact
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    protected function process(FormRequest $request, Contact $contact)
    {
        // Prepare required input fields
        $data = $request->validated();

        // Save contact
        $contact->fill($data)->save();

        return intend([
            'url' => route('adminarea.contacts.index'),
            'with' => ['success' => trans('cortex/foundation::messages.resource_saved', ['resource' => trans('cortex/contacts::common.contact'), 'identifier' => $contact->full_name])],

        ]);
    }

    /**
     * Destroy given contact.
     *
     * @param \Cortex\Contacts\Models\Contact $contact
     *
     * @throws \Exception
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function destroy(Contact $contact)
    {
        $contact->delete();

        return intend([
            'url' => route('adminarea.contacts.index'),
            'with' => ['warning' => trans('cortex/foundation::messages.resource_deleted', ['resource' => trans('cortex/contacts::common.contact'), 'identifier' => $contact->full_name])],

        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Contacts\Http\Controllers\Adminarea;
6
7			use Exception;
8			use Cortex\Contacts\Models\Contact;
9			use Illuminate\Foundation\Http\FormRequest;
10			use Cortex\Foundation\DataTables\LogsDataTable;
11			use Cortex\Foundation\Importers\DefaultImporter;
12			use Cortex\Foundation\DataTables\ImportLogsDataTable;
13			use Cortex\Foundation\Http\Requests\ImportFormRequest;
14			use Cortex\Foundation\DataTables\ImportRecordsDataTable;
15			use Cortex\Contacts\DataTables\Adminarea\ContactsDataTable;
16			use Cortex\Foundation\Http\Controllers\AuthorizedController;
17			use Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest;
18
19			class ContactsController extends AuthorizedController
20			{
21			/**
22			* {@inheritdoc}
23			*/
24			protected $resource = Contact::class;
25
26			/**
27			* List all contacts.
28			*
29			* @param \Cortex\Contacts\DataTables\Adminarea\ContactsDataTable $contactsDataTable
30			*
31			* @return \Illuminate\Http\JsonResponse\|\Illuminate\View\View
32			*/
33			public function index(ContactsDataTable $contactsDataTable)
34			{
35			return $contactsDataTable->with([
36			'id' => 'adminarea-contacts-index-table',
37			])->render('cortex/foundation::adminarea.pages.datatable-index');
38			}
39
40			/**
41			* List contact logs.
42			*
43			* @param \Cortex\Contacts\Models\Contact $contact
44			* @param \Cortex\Foundation\DataTables\LogsDataTable $logsDataTable
45			*
46			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
			0 ignored issues – show Documentation introduced 2018-01-31 14:36 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\JsonRes...e\|\Illuminate\View\View`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
47			*/
48			public function logs(Contact $contact, LogsDataTable $logsDataTable)
49			{
50			return $logsDataTable->with([
51			'resource' => $contact,
52			'tabs' => 'adminarea.contacts.tabs',
53			'id' => "adminarea-contacts-{$contact->getRouteKey()}-logs-table",
54			])->render('cortex/foundation::adminarea.pages.datatable-tab');
55			}
56
57			/**
58			* Import contacts.
59			*
60			* @param \Cortex\Contacts\Models\Contact $contact
61			* @param \Cortex\Foundation\DataTables\ImportRecordsDataTable $importRecordsDataTable
62			*
63			* @return \Illuminate\View\View
64			*/
65			public function import(Contact $contact, ImportRecordsDataTable $importRecordsDataTable)
			0 ignored issues – show Comprehensibility Naming introduced 2018-05-21 16:53 UTC by Report Bug Copy Issue Report The variable name `$importRecordsDataTable` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
66			{
67			return $importRecordsDataTable->with([
68			'resource' => $contact,
69			'tabs' => 'adminarea.contacts.tabs',
70			'url' => route('adminarea.contacts.stash'),
71			'id' => "adminarea-contacts-{$contact->getRouteKey()}-import-table",
72			])->render('cortex/foundation::adminarea.pages.datatable-dropzone');
73			}
74
75			/**
76			* Stash contacts.
77			*
78			* @param \Cortex\Foundation\Http\Requests\ImportFormRequest $request
79			* @param \Cortex\Foundation\Importers\DefaultImporter $importer
80			*
81			* @return void
82			*/
83			public function stash(ImportFormRequest $request, Contact $contact, DefaultImporter $importer)
			0 ignored issues – show Unused Code introduced 2018-05-21 16:53 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
84			{
85			// Handle the import
86			$importer->config['resource'] = $contact;
87			$importer->handleImport();
88			}
89
90			/**
91			* Hoard contacts.
92			*
93			* @param \Cortex\Foundation\Http\Requests\ImportFormRequest $request
94			*
95			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
96			*/
97			public function hoard(ImportFormRequest $request)
98			{
99			foreach ((array) $request->get('selected_ids') as $recordId) {
100			$record = app('cortex.foundation.import_record')->find($recordId);
101
102			try {
103			$fillable = collect($record['data'])->intersectByKeys(array_flip(app('rinvex.contacts.contact')->getFillable()))->toArray();
			0 ignored issues – show Coding Style introduced 2018-05-21 16:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 140 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
104
105			tap(app('rinvex.contacts.contact')->firstOrNew($fillable), function ($instance) use ($record) {
106			$instance->save() && $record->delete();
107			});
108			} catch (Exception $exception) {
109			$record->notes = $exception->getMessage().(method_exists($exception, 'getMessageBag') ? "\n".json_encode($exception->getMessageBag())."\n\n" : '');
			0 ignored issues – show Bug introduced 2018-05-21 16:53 UTC by Report Bug Copy Issue Report The method `getMessageBag()` does not exist on `Exception`. Did you maybe mean `getMessage()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Coding Style introduced 2018-05-21 16:53 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 163 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
110			$record->status = 'fail';
111			$record->save();
112			}
113			}
114
115			return intend([
116			'back' => true,
117			'with' => ['success' => trans('cortex/foundation::messages.import_complete')],
118			]);
119			}
120
121			/**
122			* List contact import logs.
123			*
124			* @param \Cortex\Foundation\DataTables\ImportLogsDataTable $importLogsDatatable
125			*
126			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
			0 ignored issues – show Documentation introduced 2018-05-21 20:53 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\JsonRes...e\|\Illuminate\View\View`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
127			*/
128			public function importLogs(ImportLogsDataTable $importLogsDatatable)
129			{
130			return $importLogsDatatable->with([
131			'resource' => trans('cortex/contacts::common.contact'),
132			'tabs' => 'adminarea.contacts.tabs',
133			'id' => 'adminarea-contacts-import-logs-table',
134			])->render('cortex/foundation::adminarea.pages.datatable-tab');
135			}
136
137			/**
138			* Show contact create/edit form.
139			*
140			* @param \Cortex\Contacts\Models\Contact $contact
141			*
142			* @return \Illuminate\View\View
143			*/
144			protected function form(Contact $contact)
145			{
146			$countries = collect(countries())->map(function ($country, $code) {
147			return [
148			'id' => $code,
149			'text' => $country['name'],
150			'emoji' => $country['emoji'],
151			];
152			})->values();
153
154			$tags = app('rinvex.tags.tag')->pluck('name', 'id');
155			$languages = collect(languages())->pluck('name', 'iso_639_1');
156			$sources = app('rinvex.contacts.contact')->distinct()->get(['source'])->pluck('source', 'source')->toArray();
157			$methods = app('rinvex.contacts.contact')->distinct()->get(['method'])->pluck('method', 'method')->toArray();
158			$genders = ['male' => trans('cortex/contacts::common.male'), 'female' => trans('cortex/contacts::common.female')];
			0 ignored issues – show Coding Style introduced 2018-01-31 14:36 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 122 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
159
160			return view('cortex/contacts::adminarea.pages.contact', compact('contact', 'genders', 'countries', 'languages', 'sources', 'methods', 'tags'));
			0 ignored issues – show Coding Style introduced 2017-10-04 13:32 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 151 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
161			}
162
163			/**
164			* Store new contact.
165			*
166			* @param \Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest $request
167			* @param \Cortex\Contacts\Models\Contact $contact
168			*
169			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
170			*/
171			public function store(ContactFormRequest $request, Contact $contact)
172			{
173			return $this->process($request, $contact);
174			}
175
176			/**
177			* Update given contact.
178			*
179			* @param \Cortex\Contacts\Http\Requests\Adminarea\ContactFormRequest $request
180			* @param \Cortex\Contacts\Models\Contact $contact
181			*
182			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
183			*/
184			public function update(ContactFormRequest $request, Contact $contact)
185			{
186			return $this->process($request, $contact);
187			}
188
189			/**
190			* Process stored/updated contact.
191			*
192			* @param \Illuminate\Foundation\Http\FormRequest $request
193			* @param \Cortex\Contacts\Models\Contact $contact
194			*
195			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
196			*/
197			protected function process(FormRequest $request, Contact $contact)
198			{
199			// Prepare required input fields
200			$data = $request->validated();
201
202			// Save contact
203			$contact->fill($data)->save();
204
205			return intend([
206			'url' => route('adminarea.contacts.index'),
207			'with' => ['success' => trans('cortex/foundation::messages.resource_saved', ['resource' => trans('cortex/contacts::common.contact'), 'identifier' => $contact->full_name])],
			0 ignored issues – show Coding Style introduced 2018-04-09 09:36 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 184 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
208			]);
209			}
210
211			/**
212			* Destroy given contact.
213			*
214			* @param \Cortex\Contacts\Models\Contact $contact
215			*
216			* @throws \Exception
217			*
218			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
219			*/
220			public function destroy(Contact $contact)
221			{
222			$contact->delete();
223
224			return intend([
225			'url' => route('adminarea.contacts.index'),
226			'with' => ['warning' => trans('cortex/foundation::messages.resource_deleted', ['resource' => trans('cortex/contacts::common.contact'), 'identifier' => $contact->full_name])],
			0 ignored issues – show Coding Style introduced 2018-04-09 09:36 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 186 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
227			]);
228			}
229			}
230

rinvex / cortex-contacts

Push — develop ( a9345e...8ee936 )

ContactsController::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like