SocialAuthenticationController::getLocalUser() - Code Metrics - Inspection of "Fix social registration" - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( cfbb01...bb3328 )

by Abdelrahman

created 2018-01-05 07:23 UTC

SocialAuthenticationController::getLocalUser() A

↳ Parent: SocialAuthenticationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Controllers\Frontarea;

use Illuminate\Http\Request;
use Laravel\Socialite\Facades\Socialite;
use Illuminate\Database\Eloquent\Builder;

class SocialAuthenticationController extends AuthenticationController
{
    /**
     * Redirect the user to the provider authentication page.
     *
     * @param string $provider
     *
     * @return \Illuminate\Http\Response
     */
    public function redirectToProvider(string $provider)
    {
        return Socialite::driver($provider)->redirect();
    }

    /**
     * Obtain the user information from Provider.
     *
     * @param string $provider
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function handleProviderCallback(string $provider)
    {
        $providerUser = Socialite::driver($provider)->user();

        $attributes = [
            'id' => $providerUser->id,
            'email' => $providerUser->email,
            'username' => $providerUser->nickname ?? trim(strstr($providerUser->email, '@', true)),
            'first_name' => trim(strstr($providerUser->name, ' ', true)),
            'last_name' => trim(strstr($providerUser->name, ' ')),
        ];

        //switch ($provider) {

        //    case 'twitter':
        //        $attributes['bio'] = $providerUser->user['description'];

        //        $attributes['profile_picture'] = $providerUser->avatar_original;

        //        break;
        //    case 'github':
        //        $attributes['bio'] = $providerUser->user['bio'];

        //        $attributes['profile_picture'] = $providerUser->avatar;

        //        break;
        //    case 'facebook':
        //        $attributes['profile_picture'] = $providerUser->avatar_original;

        //        break;
        //    case 'linkedin':
        //        $attributes['bio'] = $providerUser->headline;

        //        $attributes['profile_picture'] = $providerUser->avatar_original;

        //        break;
        //    case 'google':
        //        $attributes['bio'] = $providerUser->tagline;

        //        $attributes['profile_picture'] = $providerUser->avatar_original;

        //        break;
        //}

        //dd($providerUser, $attributes);


        if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
            $localUser = $this->createLocalUser($provider, $attributes);
        }

        $loginResult = auth()->guard($this->getGuard())->attempt([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'is_active' => $localUser->is_active,
            'email' => $localUser->email,
            'social' => true,
        ], true);

        return $this->getLoginResponse(request(), $loginResult);
    }

    /**
     * Get local user for the given provider.
     *
     * @param string $provider
     * @param string $providerUserId
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function getLocalUser(string $provider, string $providerUserId)
    {
        return app('rinvex.fort.user')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {

            $builder->where('provider', $provider)->where('provider_uid', $providerUserId);
        })->first();
    }

    /**
     * Create local user for the given provider.
     *
     * @param string $provider
     * @param array  $attributes
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function createLocalUser(string $provider, array $attributes)
    {
        $localUser = app('rinvex.fort.user');
        $defaultRole = app('rinvex.fort.role')->where('slug', config('rinvex.fort.registration.default_role'))->first();

        $attributes['password'] = str_random();
        $attributes['email_verified'] = true;
        $attributes['email_verified_at'] = now();
        $attributes['is_active'] = ! config('rinvex.fort.registration.moderated');
        $attributes['roles'] = $defaultRole ? [$defaultRole->id] : null;

        $localUser->fill($attributes)->save();

        // Fire the register success event
        event('rinvex.fort.register.success', [$localUser]);

        $localUser->socialites()->create([
            'provider' => $provider,
            'provider_uid' => $attributes['id'],
        ]);

        return $localUser;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Controllers\Frontarea;
6
7			use Illuminate\Http\Request;
8			use Laravel\Socialite\Facades\Socialite;
9			use Illuminate\Database\Eloquent\Builder;
10
11			class SocialAuthenticationController extends AuthenticationController
12			{
13			/**
14			* Redirect the user to the provider authentication page.
15			*
16			* @param string $provider
17			*
18			* @return \Illuminate\Http\Response
19			*/
20			public function redirectToProvider(string $provider)
21			{
22			return Socialite::driver($provider)->redirect();
23			}
24
25			/**
26			* Obtain the user information from Provider.
27			*
28			* @param string $provider
29			*
30			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
31			*/
32			public function handleProviderCallback(string $provider)
33			{
34			$providerUser = Socialite::driver($provider)->user();
35
36			$attributes = [
37			'id' => $providerUser->id,
38			'email' => $providerUser->email,
39			'username' => $providerUser->nickname ?? trim(strstr($providerUser->email, '@', true)),
40			'first_name' => trim(strstr($providerUser->name, ' ', true)),
41			'last_name' => trim(strstr($providerUser->name, ' ')),
42			];
43
44			//switch ($provider) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
45			// case 'twitter':
46			// $attributes['bio'] = $providerUser->user['description'];
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
47			// $attributes['profile_picture'] = $providerUser->avatar_original;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			// break;
49			// case 'github':
50			// $attributes['bio'] = $providerUser->user['bio'];
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51			// $attributes['profile_picture'] = $providerUser->avatar;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			// break;
53			// case 'facebook':
54			// $attributes['profile_picture'] = $providerUser->avatar_original;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
55			// break;
56			// case 'linkedin':
57			// $attributes['bio'] = $providerUser->headline;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			// $attributes['profile_picture'] = $providerUser->avatar_original;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59			// break;
60			// case 'google':
61			// $attributes['bio'] = $providerUser->tagline;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
62			// $attributes['profile_picture'] = $providerUser->avatar_original;
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
63			// break;
64			//}
65
66			//dd($providerUser, $attributes);
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-05 07:02 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67
68			if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
69			$localUser = $this->createLocalUser($provider, $attributes);
70			}
71
72			$loginResult = auth()->guard($this->getGuard())->attempt([
			0 ignored issues – show Bug introduced 2018-01-05 04:41 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
73			'is_active' => $localUser->is_active,
74			'email' => $localUser->email,
75			'social' => true,
76			], true);
77
78			return $this->getLoginResponse(request(), $loginResult);
79			}
80
81			/**
82			* Get local user for the given provider.
83			*
84			* @param string $provider
85			* @param string $providerUserId
86			*
87			* @return \Illuminate\Database\Eloquent\Model\|null
88			*/
89			protected function getLocalUser(string $provider, string $providerUserId)
90			{
91			return app('rinvex.fort.user')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {
			0 ignored issues – show Coding Style introduced 2018-01-05 04:41 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 125 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
92			$builder->where('provider', $provider)->where('provider_uid', $providerUserId);
93			})->first();
94			}
95
96			/**
97			* Create local user for the given provider.
98			*
99			* @param string $provider
100			* @param array $attributes
101			*
102			* @return \Illuminate\Database\Eloquent\Model\|null
103			*/
104			protected function createLocalUser(string $provider, array $attributes)
105			{
106			$localUser = app('rinvex.fort.user');
107			$defaultRole = app('rinvex.fort.role')->where('slug', config('rinvex.fort.registration.default_role'))->first();
108
109			$attributes['password'] = str_random();
110			$attributes['email_verified'] = true;
111			$attributes['email_verified_at'] = now();
112			$attributes['is_active'] = ! config('rinvex.fort.registration.moderated');
113			$attributes['roles'] = $defaultRole ? [$defaultRole->id] : null;
114
115			$localUser->fill($attributes)->save();
116
117			// Fire the register success event
118			event('rinvex.fort.register.success', [$localUser]);
119
120			$localUser->socialites()->create([
121			'provider' => $provider,
122			'provider_uid' => $attributes['id'],
123			]);
124
125			return $localUser;
126			}
127			}
128

rinvex / cortex-auth

Push — develop ( cfbb01...bb3328 )

SocialAuthenticationController::getLocalUser() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like