EmailVerificationRequest::authorize() - Code Metrics - Inspection of "Refactor hardcoded account sidebar menu into dynam..." - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d878ad...d28e4b )

by Abdelrahman

created 2018-01-26 04:54 UTC

EmailVerificationRequest::authorize() A

↳ Parent: EmailVerificationRequest

Complexity

Conditions	4
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	4
nc	2
nop	0
dl	0
loc	9
rs	9.2
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Requests\Frontarea;

use Illuminate\Foundation\Http\FormRequest;
use Rinvex\Fort\Exceptions\GenericException;

class EmailVerificationRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @throws \Rinvex\Fort\Exceptions\GenericException
     *
     * @return bool
     */
    public function authorize(): bool
    {
        if (($user = $this->user() ?: $this->attemptUser()) && $user->email_verified) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            // Redirect users if their email already verified, no need to process their request
            throw new GenericException(trans('cortex/fort::messages.verification.email.already_verified'), route('frontarea.account.settings'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules(): array
    {
        return [];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Requests\Frontarea;
6
7			use Illuminate\Foundation\Http\FormRequest;
8			use Rinvex\Fort\Exceptions\GenericException;
9
10			class EmailVerificationRequest extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @throws \Rinvex\Fort\Exceptions\GenericException
16			*
17			* @return bool
18			*/
19			public function authorize(): bool
20			{
21			if (($user = $this->user() ?: $this->attemptUser()) && $user->email_verified) {
			0 ignored issues – show Documentation Bug introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The method `attemptUser` does not exist on `object<Cortex\Fort\Http\...ailVerificationRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
22			// Redirect users if their email already verified, no need to process their request
23			throw new GenericException(trans('cortex/fort::messages.verification.email.already_verified'), route('frontarea.account.settings'));
			0 ignored issues – show Documentation introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report `route('frontarea.account.settings')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2017-06-12 16:50 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 144 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
24			}
25
26			return true;
27			}
28
29			/**
30			* Get the validation rules that apply to the request.
31			*
32			* @return array
33			*/
34			public function rules(): array
35			{
36			return [];
37			}
38			}
39

rinvex / cortex-auth

Push — develop ( d878ad...d28e4b )

EmailVerificationRequest::authorize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like