PhoneVerificationRequest - Code Metrics - Inspection of "Refactor hardcoded account sidebar menu into dynam..." - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d878ad...d28e4b )

by Abdelrahman

created 2018-01-26 04:54 UTC

PhoneVerificationRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	48
rs	10
c	1
b	0
f	0
wmc	10
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
D	authorize()	0	28	9
A	rules()	0	4	1

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Requests\Frontarea;

use Illuminate\Foundation\Http\FormRequest;
use Rinvex\Fort\Exceptions\GenericException;

class PhoneVerificationRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @throws \Rinvex\Fort\Exceptions\GenericException
     *
     * @return bool
     */
    public function authorize(): bool
    {
        $user = $this->user()
                ?? $this->attemptUser()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                   ?? app('rinvex.fort.user')->whereNotNull('phone')->where('phone', $this->get('phone'))->first();

        if ($user && $user->phone_verified) {
            // Redirect users if their phone already verified, no need to process their request
            throw new GenericException(trans('cortex/fort::messages.verification.phone.already_verified'), route('frontarea.account.settings'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if ($user && ! $user->phone) {
            // Phone field required before verification
            throw new GenericException(trans('cortex/fort::messages.account.phone_required'), route('frontarea.account.settings'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if ($user && ! $user->country_code) {
            // Country field required for phone verification
            throw new GenericException(trans('cortex/fort::messages.account.country_required'), route('frontarea.account.settings'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if ($user && ! $user->email_verified) {
            // Email verification required for phone verification
            throw new GenericException(trans('cortex/fort::messages.account.email_verification_required'), route('frontarea.verification.email.request'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules(): array
    {
        return [];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Requests\Frontarea;
6
7			use Illuminate\Foundation\Http\FormRequest;
8			use Rinvex\Fort\Exceptions\GenericException;
9
10			class PhoneVerificationRequest extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @throws \Rinvex\Fort\Exceptions\GenericException
16			*
17			* @return bool
18			*/
19			public function authorize(): bool
20			{
21			$user = $this->user()
22			?? $this->attemptUser()
			0 ignored issues – show Documentation Bug introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The method `attemptUser` does not exist on `object<Cortex\Fort\Http\...oneVerificationRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
23			?? app('rinvex.fort.user')->whereNotNull('phone')->where('phone', $this->get('phone'))->first();
24
25			if ($user && $user->phone_verified) {
26			// Redirect users if their phone already verified, no need to process their request
27			throw new GenericException(trans('cortex/fort::messages.verification.phone.already_verified'), route('frontarea.account.settings'));
			0 ignored issues – show Documentation introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report `route('frontarea.account.settings')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 144 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
28			}
29
30			if ($user && ! $user->phone) {
31			// Phone field required before verification
32			throw new GenericException(trans('cortex/fort::messages.account.phone_required'), route('frontarea.account.settings'));
			0 ignored issues – show Documentation introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report `route('frontarea.account.settings')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 131 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
33			}
34
35			if ($user && ! $user->country_code) {
36			// Country field required for phone verification
37			throw new GenericException(trans('cortex/fort::messages.account.country_required'), route('frontarea.account.settings'));
			0 ignored issues – show Documentation introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report `route('frontarea.account.settings')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 133 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
38			}
39
40			if ($user && ! $user->email_verified) {
41			// Email verification required for phone verification
42			throw new GenericException(trans('cortex/fort::messages.account.email_verification_required'), route('frontarea.verification.email.request'));
			0 ignored issues – show Documentation introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report `route('frontarea.verification.email.request')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 154 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
43			}
44
45			return true;
46			}
47
48			/**
49			* Get the validation rules that apply to the request.
50			*
51			* @return array
52			*/
53			public function rules(): array
54			{
55			return [];
56			}
57			}
58

rinvex / cortex-auth

Push — develop ( d878ad...d28e4b )

PhoneVerificationRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like