AccountPasswordRequest - Code Metrics - Inspection of "Refactor hardcoded account sidebar menu into dynam..." - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d878ad...d28e4b )

by Abdelrahman

created 2018-01-26 04:54 UTC

AccountPasswordRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	35
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	authorize()	0	12	3
A	rules()	0	7	1

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Requests\Frontarea;

use Illuminate\Foundation\Http\FormRequest;
use Rinvex\Fort\Exceptions\GenericException;

class AccountPasswordRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @throws \Rinvex\Fort\Exceptions\GenericException
     *
     * @return bool
     */
    public function authorize(): bool
    {
        if (! auth()->guard()->getProvider()->validateCredentials($this->user(), ['password' => $this->get('old_password')])) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            throw new GenericException(trans('cortex/fort::messages.account.wrong_password'), route('frontarea.account.password'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if (auth()->guard()->getProvider()->validateCredentials($this->user(), ['password' => $this->get('new_password')])) {

            throw new GenericException(trans('cortex/fort::messages.account.different_password'), route('frontarea.account.password'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules(): array
    {
        return [
            'old_password' => 'required|min:'.config('rinvex.fort.password_min_chars'),
            'new_password' => 'required|confirmed|min:'.config('rinvex.fort.password_min_chars'),
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Requests\Frontarea;
6
7			use Illuminate\Foundation\Http\FormRequest;
8			use Rinvex\Fort\Exceptions\GenericException;
9
10			class AccountPasswordRequest extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @throws \Rinvex\Fort\Exceptions\GenericException
16			*
17			* @return bool
18			*/
19			public function authorize(): bool
20			{
21			if (! auth()->guard()->getProvider()->validateCredentials($this->user(), ['password' => $this->get('old_password')])) {
			0 ignored issues – show Bug introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Coding Style introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
22			throw new GenericException(trans('cortex/fort::messages.account.wrong_password'), route('frontarea.account.password'));
			0 ignored issues – show Documentation introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report `route('frontarea.account.password')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 131 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
23			}
24
25			if (auth()->guard()->getProvider()->validateCredentials($this->user(), ['password' => $this->get('new_password')])) {
			0 ignored issues – show Coding Style introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 125 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
26			throw new GenericException(trans('cortex/fort::messages.account.different_password'), route('frontarea.account.password'));
			0 ignored issues – show Documentation introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report `route('frontarea.account.password')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 135 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
27			}
28
29			return true;
30			}
31
32			/**
33			* Get the validation rules that apply to the request.
34			*
35			* @return array
36			*/
37			public function rules(): array
38			{
39			return [
40			'old_password' => 'required\|min:'.config('rinvex.fort.password_min_chars'),
41			'new_password' => 'required\|confirmed\|min:'.config('rinvex.fort.password_min_chars'),
42			];
43			}
44			}
45

rinvex / cortex-auth

Push — develop ( d878ad...d28e4b )

AccountPasswordRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like