PasswordResetController::process() - Code Metrics - Inspection of "Support fluent controller middleware syntax" - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 5abd4c...dae2aa )

by Abdelrahman

created 2018-02-17 19:22 UTC

PasswordResetController::process() B

↳ Parent: PasswordResetController

Complexity

Conditions	6
Paths	6

Size

Total Lines	30
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	30
rs	8.439
c	0
b	0
f	0
cc	6
eloc	22
nc	6
nop	1

<?php

declare(strict_types=1);

namespace Cortex\Auth\Http\Controllers\Adminarea;

use Illuminate\Support\Str;
use Rinvex\Auth\Contracts\PasswordResetBrokerContract;
use Cortex\Foundation\Http\Controllers\AbstractController;
use Cortex\Auth\Http\Requests\Adminarea\PasswordResetRequest;
use Cortex\Auth\Http\Requests\Adminarea\PasswordResetSendRequest;
use Cortex\Auth\Http\Requests\Adminarea\PasswordResetProcessRequest;
use Cortex\Auth\Http\Requests\Adminarea\PasswordResetPostProcessRequest;

class PasswordResetController extends AbstractController
{
    /**
     * Show the password reset request form.
     *
     * @param Cortex\Auth\Http\Requests\Adminarea\PasswordResetRequest
     *
     * @return \Illuminate\View\View
     */
    public function request(PasswordResetRequest $request)

    {
        return view('cortex/auth::adminarea.pages.passwordreset-request');
    }

    /**
     * Process the password reset request form.
     *
     * @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetSendRequest $request
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function send(PasswordResetSendRequest $request)
    {
        $result = app('auth.password')
            ->broker($this->getBroker())
            ->sendResetLink($request->only(['email']));

        switch ($result) {
            case PasswordResetBrokerContract::RESET_LINK_SENT:
                return intend([
                    'url' => route('adminarea.home'),
                    'with' => ['success' => trans($result)],
                ]);

            case PasswordResetBrokerContract::INVALID_USER:
            default:
                return intend([
                    'back' => true,
                    'withInput' => $request->only(['email']),
                    'withErrors' => ['email' => trans($result)],
                ]);
        }
    }

    /**
     * Show the password reset form.
     *
     * @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetProcessRequest $request
     *
     * @return \Illuminate\View\View
     */
    public function reset(PasswordResetProcessRequest $request)
    {
        $credentials = $request->only('email', 'expiration', 'token');

        return view('cortex/auth::adminarea.pages.passwordreset')->with($credentials);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Process the password reset form.
     *
     * @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetPostProcessRequest $request
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function process(PasswordResetPostProcessRequest $request)
    {
        $result = app('auth.password')
            ->broker($this->getBroker())
            ->reset($request->only(['email', 'expiration', 'token', 'password', 'password_confirmation']), function ($user, $password) {

                $user->fill([
                    'password' => $password,
                    'remember_token' => Str::random(60),
                ])->forceSave();
            });

        switch ($result) {
            case PasswordResetBrokerContract::PASSWORD_RESET:
                return intend([
                    'url' => route('adminarea.login'),
                    'with' => ['success' => trans($result)],
                ]);

            case PasswordResetBrokerContract::INVALID_USER:
            case PasswordResetBrokerContract::INVALID_TOKEN:
            case PasswordResetBrokerContract::EXPIRED_TOKEN:
            case PasswordResetBrokerContract::INVALID_PASSWORD:
            default:
                return intend([
                    'back' => true,
                    'withInput' => $request->only(['email']),
                    'withErrors' => ['email' => trans($result)],
                ]);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Auth\Http\Controllers\Adminarea;
6
7			use Illuminate\Support\Str;
8			use Rinvex\Auth\Contracts\PasswordResetBrokerContract;
9			use Cortex\Foundation\Http\Controllers\AbstractController;
10			use Cortex\Auth\Http\Requests\Adminarea\PasswordResetRequest;
11			use Cortex\Auth\Http\Requests\Adminarea\PasswordResetSendRequest;
12			use Cortex\Auth\Http\Requests\Adminarea\PasswordResetProcessRequest;
13			use Cortex\Auth\Http\Requests\Adminarea\PasswordResetPostProcessRequest;
14
15			class PasswordResetController extends AbstractController
16			{
17			/**
18			* Show the password reset request form.
19			*
20			* @param Cortex\Auth\Http\Requests\Adminarea\PasswordResetRequest
21			*
22			* @return \Illuminate\View\View
23			*/
24			public function request(PasswordResetRequest $request)
			0 ignored issues – show Unused Code introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
25			{
26			return view('cortex/auth::adminarea.pages.passwordreset-request');
27			}
28
29			/**
30			* Process the password reset request form.
31			*
32			* @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetSendRequest $request
33			*
34			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
35			*/
36			public function send(PasswordResetSendRequest $request)
37			{
38			$result = app('auth.password')
39			->broker($this->getBroker())
40			->sendResetLink($request->only(['email']));
41
42			switch ($result) {
43			case PasswordResetBrokerContract::RESET_LINK_SENT:
44			return intend([
45			'url' => route('adminarea.home'),
46			'with' => ['success' => trans($result)],
47			]);
48
49			case PasswordResetBrokerContract::INVALID_USER:
50			default:
51			return intend([
52			'back' => true,
53			'withInput' => $request->only(['email']),
54			'withErrors' => ['email' => trans($result)],
55			]);
56			}
57			}
58
59			/**
60			* Show the password reset form.
61			*
62			* @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetProcessRequest $request
63			*
64			* @return \Illuminate\View\View
65			*/
66			public function reset(PasswordResetProcessRequest $request)
67			{
68			$credentials = $request->only('email', 'expiration', 'token');
69
70			return view('cortex/auth::adminarea.pages.passwordreset')->with($credentials);
			0 ignored issues – show Bug introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71			}
72
73			/**
74			* Process the password reset form.
75			*
76			* @param \Cortex\Auth\Http\Requests\Adminarea\PasswordResetPostProcessRequest $request
77			*
78			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
79			*/
80			public function process(PasswordResetPostProcessRequest $request)
81			{
82			$result = app('auth.password')
83			->broker($this->getBroker())
84			->reset($request->only(['email', 'expiration', 'token', 'password', 'password_confirmation']), function ($user, $password) {
			0 ignored issues – show Coding Style introduced 2017-12-24 10:25 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 136 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
85			$user->fill([
86			'password' => $password,
87			'remember_token' => Str::random(60),
88			])->forceSave();
89			});
90
91			switch ($result) {
92			case PasswordResetBrokerContract::PASSWORD_RESET:
93			return intend([
94			'url' => route('adminarea.login'),
95			'with' => ['success' => trans($result)],
96			]);
97
98			case PasswordResetBrokerContract::INVALID_USER:
99			case PasswordResetBrokerContract::INVALID_TOKEN:
100			case PasswordResetBrokerContract::EXPIRED_TOKEN:
101			case PasswordResetBrokerContract::INVALID_PASSWORD:
102			default:
103			return intend([
104			'back' => true,
105			'withInput' => $request->only(['email']),
106			'withErrors' => ['email' => trans($result)],
107			]);
108			}
109			}
110			}
111

rinvex / cortex-auth

Push — develop ( 5abd4c...dae2aa )

PasswordResetController::process() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like